From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v2] drm/omapdrm: dispc: Refuse x-decimation above 4 for all but 8-bit formats Date: Thu, 16 Feb 2017 14:11:41 +0200 Message-ID: <729de675-bf6c-b2c2-e2d6-5b5ba77e6fb7@ti.com> References: <1486562886-15261-1-git-send-email-jsarha@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1588423872==" Return-path: Received: from fllnx209.ext.ti.com (fllnx209.ext.ti.com [198.47.19.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 397DD6EAE2 for ; Thu, 16 Feb 2017 12:12:29 +0000 (UTC) In-Reply-To: <1486562886-15261-1-git-send-email-jsarha@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org --===============1588423872== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MNql3mMVmMqFqcWTttwqsQoS7A8SETHhk" --MNql3mMVmMqFqcWTttwqsQoS7A8SETHhk Content-Type: multipart/mixed; boundary="s5Aa5t8Gow6tP3eSRmcthpf3aG7nrMtEK"; protected-headers="v1" From: Tomi Valkeinen To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: airlied@linux.ie, daniel@ffwll.ch, laurent.pinchart@ideasonboard.com Message-ID: <729de675-bf6c-b2c2-e2d6-5b5ba77e6fb7@ti.com> Subject: Re: [PATCH v2] drm/omapdrm: dispc: Refuse x-decimation above 4 for all but 8-bit formats References: <1486562886-15261-1-git-send-email-jsarha@ti.com> In-Reply-To: <1486562886-15261-1-git-send-email-jsarha@ti.com> --s5Aa5t8Gow6tP3eSRmcthpf3aG7nrMtEK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/02/17 16:08, Jyri Sarha wrote: > Let's disable all scaling that requires horizontal decimation with > higher factor than 4, until we have better estimates of what we can > and can not do. However, NV12 color format appears to work Ok with > all decimation factors. >=20 > When decimating horizontally by more that 4 the dss is not able to > fetch the data in burst mode. When this happens it is hard to tell if > there enough bandwidth. Despite what theory says this appears to be > true also for 16-bit color formats. >=20 > Signed-off-by: Jyri Sarha > --- > Chnages since first version: > - "color_mode_to_bpp(color_mode) > 8" -> "color_mode !=3D OMAP_DSS_COLO= R_NV12" > - commit message and comment updated too > - improve error print >=20 > drivers/gpu/drm/omapdrm/dss/dispc.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) Thanks, I've picked this up. Tomi --s5Aa5t8Gow6tP3eSRmcthpf3aG7nrMtEK-- --MNql3mMVmMqFqcWTttwqsQoS7A8SETHhk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYpZb9AAoJEPo9qoy8lh71IoEP/A2CmMYnRI6Un1EnpG01uYws Kw3NzQ8sZtaGPpLWXMdYyNzaWtitsUqtcP3+o/5ognQ/vP7FKTNd50dItOiiw6jX MoIakjE8Ytyn5WAmDEULRwoCkyDYfhWbCGstv2hmW8xN3Oi+4PLJL5VKui01hNgy voXPpMlX+iwLShPE8LGs1BStwWQjbxKG5Rn1sgqC/wtnVwl43Y7DIT4S33qgEDsU zzxEAa8J/W/OjK/jvLgMLI40KxPOz+/OEkRWyZlCEbyfUvXAjPt77T0mxi/8VzXB KWnidaXUYIcqJtqb/6cP/MgCsQNGnBeZrpf0d8TQ6rDZuriy63AHhY8J4DaV4b+P UOt93CVQ7vIyzXx3/JqHUyRRCEXDJ0KUtcKOh4DPY/CAwo5dhU8vYS65usIJT5rs 2MeHLe9v5wDEXTXYJlPASW2+nlqzoMGe1DN1PXHPmb/qt+5MeiiInH/KEcLrDwjH YM281MUrISfz4xybGKj1SYkcMlKlX6qmpgyl2cVrouavAWjSPFA9slA8mxq0hNVn hy85n68oruMCMv03zQiy3+AVD+UqoHSLH9RrvepuZYHA2h0FEj8IWqjQuZ0wJprK Mbd4iOIu3JLXiL+Jg6lRdmLyjF21F6Ef3FrsToDVblVA4kTnsrytu8wye59Z/kzS iedZhDqWS/ary60Dd2Kq =ogiL -----END PGP SIGNATURE----- --MNql3mMVmMqFqcWTttwqsQoS7A8SETHhk-- --===============1588423872== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1588423872==--