From: "Christian König" <christian.koenig@amd.com>
To: Chen Li <chenli@uniontech.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/amdgpu: use GTT for uvd_get_create/destory_msg
Date: Wed, 23 Dec 2020 09:54:42 +0100 [thread overview]
Message-ID: <73336ba2-343d-ddba-54fe-4ebf75654394@amd.com> (raw)
In-Reply-To: <87pn33y1fc.wl-chenli@uniontech.com>
Am 21.12.20 um 10:05 schrieb Chen Li:
> On modern gpus, GTT (system memory) works as well here, and this may
> also be a workaround for platforms which cannot map vram correctly.
>
> Signed-off-by: chenli <chenli@uniontech.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> index 8b989670ed66..e2ed4689118a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> @@ -1170,7 +1170,7 @@ int amdgpu_uvd_get_create_msg(struct amdgpu_ring *ring, uint32_t handle,
> int r, i;
>
> r = amdgpu_bo_create_reserved(adev, 1024, PAGE_SIZE,
> - AMDGPU_GEM_DOMAIN_VRAM,
> + AMDGPU_GEM_DOMAIN_GTT,
> &bo, NULL, (void **)&msg);
> if (r)
> return r;
> @@ -1202,7 +1202,7 @@ int amdgpu_uvd_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle,
> int r, i;
>
> r = amdgpu_bo_create_reserved(adev, 1024, PAGE_SIZE,
> - AMDGPU_GEM_DOMAIN_VRAM,
> + AMDGPU_GEM_DOMAIN_GTT,
> &bo, NULL, (void **)&msg);
> if (r)
> return r;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-12-23 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 8:57 [PATCH 1/2] drm/radeon: use writel to avoid gcc optimization Chen Li
2020-12-21 9:05 ` [PATCH 2/2] drm/amdgpu: use GTT for uvd_get_create/destory_msg Chen Li
2020-12-23 8:54 ` Christian König [this message]
2020-12-23 8:56 ` [PATCH 1/2] drm/radeon: use writel to avoid gcc optimization Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73336ba2-343d-ddba-54fe-4ebf75654394@amd.com \
--to=christian.koenig@amd.com \
--cc=chenli@uniontech.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox