From: "Koenig, Christian" <Christian.Koenig@amd.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/3] drm: introduce DRIVER_FORCE_AUTH
Date: Wed, 3 Jul 2019 14:33:18 +0000 [thread overview]
Message-ID: <744310ce-4546-4406-ad8d-49af0f06cd49@email.android.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 943 bytes --]
Am 03.07.2019 16:00 schrieb Emil Velikov <emil.l.velikov@gmail.com>:
On Wed, 3 Jul 2019 at 14:48, Koenig, Christian <Christian.Koenig@amd.com> wrote:
>
> Well this is still a NAK.
>
> As stated previously please just don't remove DRM_AUTH and keep the functionality as it is.
>
AFAICT nobody was in favour of your suggestion to remove DRM_AUTH from
the handle to/from fd ioclts.
Thus this seems like the second best option.
Well just keep it. As I said please don't change anything here.
Dropping DRM_AUTH from the driver IOCTLs was sufficient to work around the problems at hand far as I know.
And stopping those two at least prevents userspace to abuse this even more.
On the other hand I haven't seen any NAK on dropping DRM_AUTH from them.
Christian.
Third route that I see is doing driver_name == "amdgpu" || driver_name
== "radeon" in core.
If you have alternative solution I'm all ears.
-Emil
[-- Attachment #1.2: Type: text/html, Size: 2110 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2019-07-03 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 14:33 Koenig, Christian [this message]
[not found] ` <744310ce-4546-4406-ad8d-49af0f06cd49-2ueSQiBKiTY7tOexoI0I+QC/G2K4zDHf@public.gmane.org>
2019-07-03 14:51 ` [PATCH 2/3] drm: introduce DRIVER_FORCE_AUTH Emil Velikov
-- strict thread matches above, loose matches on Subject: below --
2019-07-06 6:16 Koenig, Christian
2019-07-03 14:58 Koenig, Christian
[not found] ` <0bc184ea-bcc3-48cb-9b28-42e8fc037303-2ueSQiBKiTY7tOexoI0I+QC/G2K4zDHf@public.gmane.org>
2019-07-03 15:14 ` Emil Velikov
[not found] ` <CACvgo52y50bV90+7JeABvKCNCwT_E7r7CXTw98bOgyiDDzG2Pg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-07-17 8:26 ` Koenig, Christian
2019-07-03 13:31 [PATCH 1/3] drm/vmwgfx: check master authentication in surface_ref ioctls Emil Velikov
[not found] ` <20190703133104.3211-1-emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-07-03 13:31 ` [PATCH 2/3] drm: introduce DRIVER_FORCE_AUTH Emil Velikov
2019-07-03 13:48 ` Koenig, Christian
2019-07-03 14:00 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=744310ce-4546-4406-ad8d-49af0f06cd49@email.android.com \
--to=christian.koenig@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).