From: Alex Hung <alex.hung@amd.com>
To: Hou Wenlong <houwenlong.hwl@antgroup.com>, linux-kernel@vger.kernel.org
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Alvin Lee" <alvin.lee2@amd.com>,
amd-gfx@lists.freedesktop.org,
"Ankit Nautiyal" <ankit.k.nautiyal@intel.com>,
"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
"Ausef Yousof" <auyousof@amd.com>,
"Bhuvanachandra Pinninti" <bpinnint@amd.com>,
"Chaitanya Kumar Borah" <chaitanya.kumar.borah@intel.com>,
"Charlene Liu" <charlene.liu@amd.com>,
"Chenyu Chen" <chen-yu.chen@amd.com>,
"Chris Park" <chris.park@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Dillon Varone" <dillon.varone@amd.com>,
"Dmytro Laktyushkin" <dmytro.laktyushkin@amd.com>,
dri-devel@lists.freedesktop.org,
"Gustavo Sousa" <gustavo.sousa@intel.com>,
"Harold Sun" <Harold.Sun@amd.com>,
"Harry Wentland" <harry.wentland@amd.com>,
intel-gfx@lists.freedesktop.org,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Jun Lei" <jun.lei@amd.com>,
"Karthi Kandasamy" <karthi.kandasamy@amd.com>,
"Leo Chen" <leo.chen@amd.com>, "Leo Li" <sunpeng.li@amd.com>,
"Lohita Mudimela" <lohita.mudimela@amd.com>,
"Lucas De Marchi" <demarchi@kernel.org>,
"Meenakshikumar Somasundaram"
<meenakshikumar.somasundaram@amd.com>,
"Nicholas Carbones" <Nicholas.Carbones@amd.com>,
"Ray Wu" <ray.wu@amd.com>, "Relja Vojvodic" <rvojvodi@amd.com>,
"Rodrigo Siqueira" <siqueira@igalia.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Ryan Seto" <ryanseto@amd.com>, "Samson Tam" <Samson.Tam@amd.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Timur Kristóf" <timur.kristof@gmail.com>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
"Wayne Lin" <wayne.lin@amd.com>,
"Wenjing Liu" <wenjing.liu@amd.com>, "Yan Li" <yan.li@amd.com>,
"Zhenyu Wang" <zhenyuw.linux@gmail.com>,
"Zhi Wang" <zhi.wang.linux@gmail.com>
Subject: Re: [PATCH 2/2] drm/amd/display: Rename enum 'pixel_format' to 'dc_pixel_format'
Date: Thu, 19 Mar 2026 21:58:43 -0600 [thread overview]
Message-ID: <7476bdd2-be51-4444-b0ac-bbc1d3225d4e@amd.com> (raw)
In-Reply-To: <d3b123a7d3192947e2eb4c33cd10cbaa8c79dfc1.1773629419.git.houwenlong.hwl@antgroup.com>
Reviewed-by: Alex Hung <alex.hung@amd.com>
On 3/15/26 21:46, Hou Wenlong wrote:
> [Some people who received this message don't often get email from houwenlong.hwl@antgroup.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Rename the enum 'pixel_format' to 'dc_pixel_format' to avoid potential
> name conflicts with the pixel_format struct defined in
> include/video/pixel_format.h.
>
> Signed-off-by: Hou Wenlong <houwenlong.hwl@antgroup.com>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 4 ++--
> drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 2 +-
> drivers/gpu/drm/amd/display/dc/dc_spl_translate.c | 3 ++-
> drivers/gpu/drm/amd/display/dc/dpp/dcn10/dcn10_dpp_dscl.c | 4 ++--
> drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c | 4 ++--
> drivers/gpu/drm/amd/display/dc/inc/hw/hw_shared.h | 2 +-
> drivers/gpu/drm/amd/display/dc/inc/hw/transform.h | 2 +-
> 7 files changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> index 03d125f794b0..cadc52728108 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> @@ -742,10 +742,10 @@ struct clock_source *resource_find_used_clk_src_for_sharing(
> return NULL;
> }
>
> -static enum pixel_format convert_pixel_format_to_dalsurface(
> +static enum dc_pixel_format convert_pixel_format_to_dalsurface(
> enum surface_pixel_format surface_pixel_format)
> {
> - enum pixel_format dal_pixel_format = PIXEL_FORMAT_UNKNOWN;
> + enum dc_pixel_format dal_pixel_format = PIXEL_FORMAT_UNKNOWN;
>
> switch (surface_pixel_format) {
> case SURFACE_PIXEL_FORMAT_GRPH_PALETA_256_COLORS:
> diff --git a/drivers/gpu/drm/amd/display/dc/dc_hw_types.h b/drivers/gpu/drm/amd/display/dc/dc_hw_types.h
> index cfa569a7bff1..81d12df8f54e 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc_hw_types.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc_hw_types.h
> @@ -218,7 +218,7 @@ enum surface_pixel_format {
>
>
> /* Pixel format */
> -enum pixel_format {
> +enum dc_pixel_format {
> /*graph*/
> PIXEL_FORMAT_UNINITIALIZED,
> PIXEL_FORMAT_INDEX8,
> diff --git a/drivers/gpu/drm/amd/display/dc/dc_spl_translate.c b/drivers/gpu/drm/amd/display/dc/dc_spl_translate.c
> index 37d1a79e8241..854d50ab1a6c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc_spl_translate.c
> +++ b/drivers/gpu/drm/amd/display/dc/dc_spl_translate.c
> @@ -63,7 +63,8 @@ static void populate_inits_from_splinits(struct scl_inits *inits,
> inits->h_c = dc_fixpt_from_int_dy(spl_inits->h_filter_init_int_c, spl_inits->h_filter_init_frac_c >> 5, 0, 19);
> inits->v_c = dc_fixpt_from_int_dy(spl_inits->v_filter_init_int_c, spl_inits->v_filter_init_frac_c >> 5, 0, 19);
> }
> -static void populate_splformat_from_format(enum spl_pixel_format *spl_pixel_format, const enum pixel_format pixel_format)
> +static void populate_splformat_from_format(enum spl_pixel_format *spl_pixel_format,
> + const enum dc_pixel_format pixel_format)
> {
> if (pixel_format < PIXEL_FORMAT_INVALID)
> *spl_pixel_format = (enum spl_pixel_format)pixel_format;
> diff --git a/drivers/gpu/drm/amd/display/dc/dpp/dcn10/dcn10_dpp_dscl.c b/drivers/gpu/drm/amd/display/dc/dpp/dcn10/dcn10_dpp_dscl.c
> index 808bca9fb804..0d2c9fcd3362 100644
> --- a/drivers/gpu/drm/amd/display/dc/dpp/dcn10/dcn10_dpp_dscl.c
> +++ b/drivers/gpu/drm/amd/display/dc/dpp/dcn10/dcn10_dpp_dscl.c
> @@ -102,7 +102,7 @@ static int dpp1_dscl_get_pixel_depth_val(enum lb_pixel_depth depth)
> }
> }
>
> -static bool dpp1_dscl_is_video_format(enum pixel_format format)
> +static bool dpp1_dscl_is_video_format(enum dc_pixel_format format)
> {
> if (format >= PIXEL_FORMAT_VIDEO_BEGIN
> && format <= PIXEL_FORMAT_VIDEO_END)
> @@ -111,7 +111,7 @@ static bool dpp1_dscl_is_video_format(enum pixel_format format)
> return false;
> }
>
> -static bool dpp1_dscl_is_420_format(enum pixel_format format)
> +static bool dpp1_dscl_is_420_format(enum dc_pixel_format format)
> {
> if (format == PIXEL_FORMAT_420BPP8 ||
> format == PIXEL_FORMAT_420BPP10)
> diff --git a/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c b/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c
> index a62c4733ed3b..e2489eaf0004 100644
> --- a/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c
> +++ b/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c
> @@ -94,7 +94,7 @@ static int dpp401_dscl_get_pixel_depth_val(enum lb_pixel_depth depth)
> }
> }
>
> -static bool dpp401_dscl_is_video_format(enum pixel_format format)
> +static bool dpp401_dscl_is_video_format(enum dc_pixel_format format)
> {
> if (format >= PIXEL_FORMAT_VIDEO_BEGIN
> && format <= PIXEL_FORMAT_VIDEO_END)
> @@ -103,7 +103,7 @@ static bool dpp401_dscl_is_video_format(enum pixel_format format)
> return false;
> }
>
> -static bool dpp401_dscl_is_420_format(enum pixel_format format)
> +static bool dpp401_dscl_is_420_format(enum dc_pixel_format format)
> {
> if (format == PIXEL_FORMAT_420BPP8 ||
> format == PIXEL_FORMAT_420BPP10)
> diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/hw_shared.h b/drivers/gpu/drm/amd/display/dc/inc/hw/hw_shared.h
> index a61d12ec61bc..b4a95807b73b 100644
> --- a/drivers/gpu/drm/amd/display/dc/inc/hw/hw_shared.h
> +++ b/drivers/gpu/drm/amd/display/dc/inc/hw/hw_shared.h
> @@ -240,7 +240,7 @@ struct default_adjustment {
> enum dc_color_space out_color_space;
> enum dc_color_space in_color_space;
> enum dc_color_depth color_depth;
> - enum pixel_format surface_pixel_format;
> + enum dc_pixel_format surface_pixel_format;
> enum graphics_csc_adjust_type csc_adjust_type;
> bool force_hw_default;
> };
> diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/transform.h b/drivers/gpu/drm/amd/display/dc/inc/hw/transform.h
> index 5a1d9b708a9d..30990355985d 100644
> --- a/drivers/gpu/drm/amd/display/dc/inc/hw/transform.h
> +++ b/drivers/gpu/drm/amd/display/dc/inc/hw/transform.h
> @@ -160,7 +160,7 @@ struct scaler_data {
> struct scaling_ratios ratios;
> struct scl_inits inits;
> struct sharpness_adj sharpness;
> - enum pixel_format format;
> + enum dc_pixel_format format;
> struct line_buffer_params lb_params;
> // Below struct holds the scaler values to program hw registers
> struct dscl_prog_data dscl_prog_data;
> --
> 2.31.1
>
prev parent reply other threads:[~2026-03-20 3:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 3:46 [PATCH 0/2] drm: Fix namespace clashes with 'pixel_format' Hou Wenlong
2026-03-16 3:46 ` [PATCH 1/2] drm/i915/gvt: Rename struct 'pixel_format' to 'gvt_pixel_format' Hou Wenlong
2026-03-16 8:52 ` Jani Nikula
2026-03-16 3:46 ` [PATCH 2/2] drm/amd/display: Rename enum 'pixel_format' to 'dc_pixel_format' Hou Wenlong
2026-03-20 3:58 ` Alex Hung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7476bdd2-be51-4444-b0ac-bbc1d3225d4e@amd.com \
--to=alex.hung@amd.com \
--cc=Harold.Sun@amd.com \
--cc=Nicholas.Carbones@amd.com \
--cc=Samson.Tam@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=alvin.lee2@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ankit.k.nautiyal@intel.com \
--cc=aurabindo.pillai@amd.com \
--cc=auyousof@amd.com \
--cc=bpinnint@amd.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=charlene.liu@amd.com \
--cc=chen-yu.chen@amd.com \
--cc=chris.park@amd.com \
--cc=christian.koenig@amd.com \
--cc=demarchi@kernel.org \
--cc=dillon.varone@amd.com \
--cc=dmytro.laktyushkin@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.sousa@intel.com \
--cc=harry.wentland@amd.com \
--cc=houwenlong.hwl@antgroup.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=jun.lei@amd.com \
--cc=karthi.kandasamy@amd.com \
--cc=leo.chen@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lohita.mudimela@amd.com \
--cc=meenakshikumar.somasundaram@amd.com \
--cc=ray.wu@amd.com \
--cc=rodrigo.vivi@intel.com \
--cc=rvojvodi@amd.com \
--cc=ryanseto@amd.com \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=sunpeng.li@amd.com \
--cc=timur.kristof@gmail.com \
--cc=tursulin@ursulin.net \
--cc=wayne.lin@amd.com \
--cc=wenjing.liu@amd.com \
--cc=yan.li@amd.com \
--cc=zhenyuw.linux@gmail.com \
--cc=zhi.wang.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox