From: Luben Tuikov <luben.tuikov@amd.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
bob.beckett@collabora.com, dri-devel@lists.freedesktop.org,
daniel@ffwll.ch
Subject: Re: Improve TTMs empty object handling
Date: Thu, 12 May 2022 23:43:38 -0400 [thread overview]
Message-ID: <750ebec4-d192-6fdd-c991-7705b6acc794@amd.com> (raw)
In-Reply-To: <20220509130951.486344-1-christian.koenig@amd.com>
Patch set reviewed. Good stuff.
Acked-by: Luben Tuikov <luben.tuikov@amd.com>
Regards,
Luben
On 2022-05-09 09:09, Christian König wrote:
> Hi everyone,
>
> re-sending this because Daniel was requesting a background why this is
> useful.
>
> When TTM creates a buffer this object initially should not have any
> backing store and there no resource object associated with it. The same
> can happen when a driver requests that the backing store of an object is
> destroyed without allocating a new one.
>
> This is really useful during initial buffer creation as well as temporary
> buffers and page tables which content doesn't need to be preserved when
> they are evicted.
>
> Currently TTM allocates dummy system resources for that because drivers
> couldn't handle a NULL pointer there. Audit the drivers and then clean
> up TTM to stop making those dummy allocations.
>
> Please review and comment,
> Christian.
>
>
next prev parent reply other threads:[~2022-05-13 3:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 13:09 Improve TTMs empty object handling Christian König
2022-05-09 13:09 ` [PATCH 01/11] drm/radeon: switch over to ttm_bo_init_reserved Christian König
2022-05-09 13:09 ` [PATCH 02/11] drm/nouveau: " Christian König
2022-05-09 13:09 ` [PATCH 03/11] drm/vram-helper: " Christian König
2022-05-09 13:09 ` [PATCH 04/11] drm/ttm: move default BO destructor into VMWGFX Christian König
2022-05-09 13:09 ` [PATCH 05/11] drm/ttm: drop ttm_bo_init Christian König
2022-05-09 13:09 ` [PATCH 06/11] drm/ttm: rename and cleanup ttm_bo_init_reserved Christian König
2022-05-09 13:09 ` [PATCH 07/11] drm/amdgpu: audit bo->resource usage Christian König
2022-05-09 13:09 ` [PATCH 08/11] drm/nouveau: " Christian König
2022-05-09 13:09 ` [PATCH 09/11] drm/ttm: " Christian König
2022-05-09 13:09 ` [PATCH 10/11] drm/ttm: stop allocating dummy resources during BO creation Christian König
2022-05-09 13:09 ` [PATCH 11/11] drm/ttm: stop allocating a dummy resource for pipelined gutting Christian König
2022-05-11 19:49 ` Improve TTMs empty object handling Daniel Vetter
2022-05-13 3:43 ` Luben Tuikov [this message]
2022-05-13 9:21 ` Matthew Auld
2022-05-13 13:03 ` Christian König
2022-05-13 13:27 ` Matthew Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=750ebec4-d192-6fdd-c991-7705b6acc794@amd.com \
--to=luben.tuikov@amd.com \
--cc=bob.beckett@collabora.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox