From: jshekhar-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
To: Tanmay Shah <tanmay-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: manojavm-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [DPU PATCH v1] drm/msm/dpu: Change RGB565 and BGR565 format map.
Date: Sat, 15 Dec 2018 00:06:43 +0530 [thread overview]
Message-ID: <7773e92e8550c08ecb9ab6577b24e1c5@codeaurora.org> (raw)
In-Reply-To: <9ad795cd7e2a31887deaa5affd407c29-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On 2018-12-15 00:04, jshekhar@codeaurora.org wrote:
> On 2018-12-14 23:53, Tanmay Shah wrote:
>> Red and Blue colors will be interchanged on display with
>> current format maps for RGB565 and BGR565.
>>
>> Change both format maps to dispaly correct colors.
>>
spelling: dispaly/display
>> Signed-off-by: Tanmay Shah <tanmay@codeaurora.org>
>
> LGTM.
>
> Reviewed-by: Jayant Shekhar <jshekhar@codeaurora.org>
>
>> ---
>> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
>> b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
>> index d53abc8ce670..f59fe1a9f4b9 100644
>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
>> @@ -263,13 +263,13 @@ static const struct dpu_format dpu_format_map[]
>> = {
>>
>> INTERLEAVED_RGB_FMT(RGB565,
>> 0, COLOR_5BIT, COLOR_6BIT, COLOR_5BIT,
>> - C1_B_Cb, C0_G_Y, C2_R_Cr, 0, 3,
>> + C2_R_Cr, C0_G_Y, C1_B_Cb, 0, 3,
>> false, 2, 0,
>> DPU_FETCH_LINEAR, 1),
>>
>> INTERLEAVED_RGB_FMT(BGR565,
>> 0, COLOR_5BIT, COLOR_6BIT, COLOR_5BIT,
>> - C2_R_Cr, C0_G_Y, C1_B_Cb, 0, 3,
>> + C1_B_Cb, C0_G_Y, C2_R_Cr, 0, 3,
>> false, 2, 0,
>> DPU_FETCH_LINEAR, 1),
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
prev parent reply other threads:[~2018-12-14 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 18:23 [DPU PATCH v1] drm/msm/dpu: Change RGB565 and BGR565 format map Tanmay Shah
[not found] ` <20181214182340.1195-1-tanmay-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-12-14 18:34 ` jshekhar-sgV2jX0FEOL9JmXXK+q4OQ
[not found] ` <9ad795cd7e2a31887deaa5affd407c29-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-12-14 18:36 ` jshekhar-sgV2jX0FEOL9JmXXK+q4OQ [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7773e92e8550c08ecb9ab6577b24e1c5@codeaurora.org \
--to=jshekhar-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
--cc=abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=manojavm-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=tanmay-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox