From: "Christian König" <christian.koenig@amd.com>
To: Dave Airlie <airlied@gmail.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/ttm: drop evicted from ttm_bo.
Date: Thu, 17 Sep 2020 10:02:42 +0200 [thread overview]
Message-ID: <77fee681-dd79-86f5-d1cf-646b7d1504f5@amd.com> (raw)
In-Reply-To: <20200917064132.148521-3-airlied@gmail.com>
Am 17.09.20 um 08:41 schrieb Dave Airlie:
> From: Dave Airlie <airlied@redhat.com>
>
> This was unused.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 4 ----
> include/drm/ttm/ttm_bo_api.h | 1 -
> 2 files changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 279a0e44a5ed..7562b0844c75 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -298,8 +298,6 @@ static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo,
> }
>
> moved:
> - bo->evicted = false;
> -
> ctx->bytes_moved += bo->num_pages << PAGE_SHIFT;
> return 0;
>
> @@ -638,9 +636,7 @@ static int ttm_bo_evict(struct ttm_buffer_object *bo,
> if (ret != -ERESTARTSYS)
> pr_err("Buffer eviction failed\n");
> ttm_resource_free(bo, &evict_mem);
> - goto out;
> }
> - bo->evicted = true;
> out:
> return ret;
> }
> diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h
> index 36ff64e2736c..03b4761a3ea3 100644
> --- a/include/drm/ttm/ttm_bo_api.h
> +++ b/include/drm/ttm/ttm_bo_api.h
> @@ -141,7 +141,6 @@ struct ttm_buffer_object {
> struct ttm_resource mem;
> struct file *persistent_swap_storage;
> struct ttm_tt *ttm;
> - bool evicted;
> bool deleted;
>
> /**
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-09-17 8:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 6:41 [PATCH 0/2] ttm follow-on cleanups Dave Airlie
2020-09-17 6:41 ` [PATCH 1/2] drm/ttm: drop special pipeline accel cleanup function Dave Airlie
2020-09-17 8:01 ` Christian König
2020-09-17 6:41 ` [PATCH 2/2] drm/ttm: drop evicted from ttm_bo Dave Airlie
2020-09-17 8:02 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77fee681-dd79-86f5-d1cf-646b7d1504f5@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox