From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Subject: Re: [PATCH v4 12/19] drm/bochs: Convert bochs driver to VRAM MM Date: Mon, 6 May 2019 15:15:34 +0200 Message-ID: <78ce7242-81c0-e617-c181-5686aba3847b@suse.de> References: <20190506082649.942-1-tzimmermann@suse.de> <20190506082649.942-13-tzimmermann@suse.de> <20190506124031.jwo5exbz6xk5fjan@sirius.home.kraxel.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0459294212==" Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7FAFD89739 for ; Mon, 6 May 2019 13:15:39 +0000 (UTC) In-Reply-To: <20190506124031.jwo5exbz6xk5fjan@sirius.home.kraxel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: airlied@linux.ie, puck.chen@hisilicon.com, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, z.liuxinliang@hisilicon.com, hdegoede@redhat.com, kong.kongxinwei@hisilicon.com, ray.huang@amd.com, zourongrong@gmail.com, sam@ravnborg.org, christian.koenig@amd.com List-Id: dri-devel@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0459294212== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vXKLReJpdRKvT2Z7i8m4x6LWYEM8s1Ai6" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vXKLReJpdRKvT2Z7i8m4x6LWYEM8s1Ai6 Content-Type: multipart/mixed; boundary="AB6gkshIrH37BwtImZ1wI4IS4ODICVRhY"; protected-headers="v1" From: Thomas Zimmermann To: Gerd Hoffmann Cc: daniel@ffwll.ch, airlied@linux.ie, christian.koenig@amd.com, ray.huang@amd.com, hdegoede@redhat.com, noralf@tronnes.org, sam@ravnborg.org, z.liuxinliang@hisilicon.com, zourongrong@gmail.com, kong.kongxinwei@hisilicon.com, puck.chen@hisilicon.com, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org Message-ID: <78ce7242-81c0-e617-c181-5686aba3847b@suse.de> Subject: Re: [PATCH v4 12/19] drm/bochs: Convert bochs driver to VRAM MM References: <20190506082649.942-1-tzimmermann@suse.de> <20190506082649.942-13-tzimmermann@suse.de> <20190506124031.jwo5exbz6xk5fjan@sirius.home.kraxel.org> In-Reply-To: <20190506124031.jwo5exbz6xk5fjan@sirius.home.kraxel.org> --AB6gkshIrH37BwtImZ1wI4IS4ODICVRhY Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 06.05.19 um 14:40 schrieb Gerd Hoffmann: > Hi, >=20 >> static const struct file_operations bochs_fops =3D { >> .owner =3D THIS_MODULE, >> - .open =3D drm_open, >> - .release =3D drm_release, >> - .unlocked_ioctl =3D drm_ioctl, >> - .compat_ioctl =3D drm_compat_ioctl, >> - .poll =3D drm_poll, >> - .read =3D drm_read, >> .llseek =3D no_llseek, >> - .mmap =3D bochs_mmap, >> + DRM_VRAM_MM_FILE_OPERATIONS >> }; >=20 > What about llseek? I think it should either be deleted (if not needed)= > or added to DRM_VRAM_MM_FILE_OPERATIONS (if needed). Some drivers set no_llseek, some leave the .llseek field to NULL. So I don't set the field from DRM_VRAM_MM_FILE_OPERATIONS. But now that you asked, I found that DRM actually requires no_llseek. I'll add it to the default operations in the next iteration of the patch set. Best regards Thomas > cheers, > Gerd >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 21284 (AG N=C3=BCrnberg) --AB6gkshIrH37BwtImZ1wI4IS4ODICVRhY-- --vXKLReJpdRKvT2Z7i8m4x6LWYEM8s1Ai6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAlzQM3YACgkQaA3BHVML eiNZsQgAh0PLjirbrnGoNT5rW/dvvnSfuenANfNjY/z/rUKQCDyLqudpFShQN7PC rWBMVSG+nfwAu0XZpoI2JDmt3gRleeZ9krUs0Q6Ea5/cdBNohyv6QM9HP+8LQ7/h NxJVcoAHTvSLpVvLBAw6QHzBLJm/px7zgyNNsnss6eagTZlk5tzh4hvpYaTAiO3W f73Z3jPnXYJAH8ySjhef1IhAcKlh+lHTaontag+tq2RWTt5RaahLqoJgmHy2chGV n7F7IWyMQHF+3U4Lu8eOD0yhSSFD+IXNUMME9xOfi3Q9WAlxkXXbJGqBkFpLqegC RJjXv1PAzDQs0e8FoqAartEnq7Swlw== =17sq -----END PGP SIGNATURE----- --vXKLReJpdRKvT2Z7i8m4x6LWYEM8s1Ai6-- --===============0459294212== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0459294212==--