From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 1/1] Revert "gpu: drm: omapdrm: dss-of: add missing of_node_put after calling of_parse_phandle" Date: Tue, 6 Sep 2016 15:18:36 +0300 Message-ID: <79f4ebd5-bb8b-fd33-c4aa-e0f342407407@ti.com> References: <1470908694-16362-1-git-send-email-peter.chen@nxp.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2093397172==" Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by gabe.freedesktop.org (Postfix) with ESMTPS id D4E596E14C for ; Tue, 6 Sep 2016 12:18:41 +0000 (UTC) In-Reply-To: <1470908694-16362-1-git-send-email-peter.chen@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: airlied@linux.ie Cc: Peter Chen , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2093397172== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lJHNTAGmburbCENMUAn5QQRfjLmos3BAN" --lJHNTAGmburbCENMUAn5QQRfjLmos3BAN Content-Type: multipart/mixed; boundary="VRgwB3DmRSN1UoVhX4WjOObePmmhndmne"; protected-headers="v1" From: Tomi Valkeinen To: airlied@linux.ie Cc: Peter Chen , seanpaul@chromium.org, dri-devel@lists.freedesktop.org Message-ID: <79f4ebd5-bb8b-fd33-c4aa-e0f342407407@ti.com> Subject: Re: [PATCH 1/1] Revert "gpu: drm: omapdrm: dss-of: add missing of_node_put after calling of_parse_phandle" References: <1470908694-16362-1-git-send-email-peter.chen@nxp.com> In-Reply-To: <1470908694-16362-1-git-send-email-peter.chen@nxp.com> --VRgwB3DmRSN1UoVhX4WjOObePmmhndmne Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Dave, Can you pick this for drm-fixes? The bug is causing scary looking stack dumps when loading omapdrm. Apparently this fix went into drm-next accidentally instead of drm-fixes. I hope having the same patch in both trees won't be causing any extra conflicts. Tomi On 11/08/16 12:44, Peter Chen wrote: > This reverts commit 2ab9f5879162499e1c4e48613287e3f59e593c4f. >=20 > The of_get_next_parent will drop refcount on the passed node, so the re= verted > patch is wrong, thanks for Tomi Valkeinen points it. >=20 > Cc: Tomi Valkeinen > Signed-off-by: Peter Chen > --- > drivers/gpu/drm/omapdrm/dss/dss-of.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/gpu/drm/omapdrm/dss/dss-of.c b/drivers/gpu/drm/oma= pdrm/dss/dss-of.c > index e256d87..dfd4e96 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dss-of.c > +++ b/drivers/gpu/drm/omapdrm/dss/dss-of.c > @@ -125,16 +125,15 @@ u32 dss_of_port_get_port_number(struct device_nod= e *port) > =20 > static struct device_node *omapdss_of_get_remote_port(const struct dev= ice_node *node) > { > - struct device_node *np, *np_parent; > + struct device_node *np; > =20 > np =3D of_parse_phandle(node, "remote-endpoint", 0); > if (!np) > return NULL; > =20 > - np_parent =3D of_get_next_parent(np); > - of_node_put(np); > + np =3D of_get_next_parent(np); > =20 > - return np_parent; > + return np; > } > =20 > struct device_node * >=20 --VRgwB3DmRSN1UoVhX4WjOObePmmhndmne-- --lJHNTAGmburbCENMUAn5QQRfjLmos3BAN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXzrQcAAoJEPo9qoy8lh71DQIP/2Xm97inY2cc8tDdA2H/N6R4 E8SD84O8GrF/btNoSlQb57EMiVGeDC372aXoWYw4sAxrFmfEKXR0Me7IUd22cxIG GLClE7PmAl5/j9hAqI2xC1iCpLl1Oc7Pb4Jpja9m8YA8nQtZvydrrk0qK02Eey2O DhPW4+JwnrPnEo/RIqT1339/sowCmKyWJlTipqgySx2sSKEzx2NiNf/K08xZwKiu jxU9Ypu8KzkW6tBiKMOfsJjxivXzwdET2o+mwA/IjPcbAZgv4MMSexWQnNrzPtUS C77recmFSfyfP9zDaoO50Rro8j/WtCKUM2Z3RTDp4E/eW80ZH1xFET7XGrJHOT3b mjFchwErNB0ObRA99sUZfnxjQ7PrcECFGnT+bQXM4baS9RX6t8+cMIhw3GWkvLmB syQScSWEefC2o96LkXqCyw6iaN5aWfaf8H8NLfysCTS5bsyEba8bKYvJj8PtBRxl xSNUgxCCIhcQA8oLiBQGq1kQMN7g17UClyn/4PLW6ILGGd2iZXWn5BkMkMeFtwmb wWgN+vf9J3eNZH9JKHDkP9Pmb55GMU8hfpQlp6MNA6Cf3zu7RjN3FaJWqgCgrUcS pmztgeG/dIqDbKkQV4mHCvmwI22ZGivnMcztKxXUwsHxCcbWKJgYNCfWqq8PCGfJ Fkk2VBcrkv0TWkRk8gG0 =jYiM -----END PGP SIGNATURE----- --lJHNTAGmburbCENMUAn5QQRfjLmos3BAN-- --===============2093397172== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============2093397172==--