From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2730BCCF9E3 for ; Fri, 24 Oct 2025 14:23:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 942C510EAA8; Fri, 24 Oct 2025 14:23:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="nY5OaQve"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7082510EAA4 for ; Fri, 24 Oct 2025 14:23:13 +0000 (UTC) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59OBtUhL022251 for ; Fri, 24 Oct 2025 14:23:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /EgZaEEAtQpIr/mZaxCGpC9Z/zSaRdUrKgdMD6X3vlY=; b=nY5OaQve8G5EIpFm rYPkwyaycSFwxx9VkYXWvNsPm0D7qWqt5lxOmbkwJxRqm5BIs5wf9GSTl6yW6xPv NgpidjM2fE4dnlVVnL0N5f/Pu12FQFJheeMVvhB8H5OlFfA4nQSjAwc9R3aXRRR6 xY/hZqCgsskE2TLmOtII7ASb1aM1mdVlNM/p4KlBYXyXzkaDOCZvcU0McgMRHali BBhlCsHAsXXO+5cLj0J2XtSbAkhcbb7KW/hpmGdl7mDwBvg+YNxOekORtu3Q7sYc GtMEaPm5/PBFNFMzkpeJBZp5skCOFZwaQcTy7v39PSsIM75esnudy+wLI+dtVBPV MrhtgQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49xhe0t8m2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 24 Oct 2025 14:23:12 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-272b7bdf41fso22850655ad.0 for ; Fri, 24 Oct 2025 07:23:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761315791; x=1761920591; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/EgZaEEAtQpIr/mZaxCGpC9Z/zSaRdUrKgdMD6X3vlY=; b=MIHsA2dc+aL6K8I/71FOmTJ78U26uoT5uQKRiToFLFqsv/ZkBfVYVUe4/5p8Xzzc/U 41Isj7mrV9UOkerTJVxenXfdi9C8gl4gC4oeN864SuawVRo3Mr9as8ga5UJJ/Zzg8s1E EvLeJB9/6nW+7QiTSp2or00OK6jhCYqLMLo2/6zYq0t89Aqx1lKgjfWO6o4AdgKTnOuO awu0tBSKfZfrkH88/SkdnI7WUKFl+j1hKRCYU9iZwYuKd3FThBXDvanLnFOANf6v7N36 XcdXDlT76DA4nYKcMgY0N49Z70MJCUuN8Nbl7wPa3Vy+0GzRimlgscbtcl8f7SgI40O8 xLtQ== X-Forwarded-Encrypted: i=1; AJvYcCVP8NoizkbcNYmWv6znRVSWZKVuhlKkZyVNSeZPQwGZTUK89NKdAtMiBqFvuuLJ28lBZsosEq0hGxY=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzKDz9+/EoI5rLV99LO04bHIgiMzM7xizBAjyw1vHqHCgrhHbdW T/nmJXJVMu+Yu6RXXTbWqMrSEagURVkdoxJuH9L7gE+xcANxGHcmwcInOnR+JyXGjOMQ82zVjfW HIoUC7YrSQv1DlxJJHEqNe2vEhGGCTyJPHv+HkI//ytl5JxPh9hIGhqbzP2DjOMG8PIfYbcQ= X-Gm-Gg: ASbGnctops7VnvlRYe9SBFkUVfVg7g9pMHrWhqKkN3KS9sk4IdcGWofZtCjujqcyAdf N8TCnKx81mNdc27EwPYiOKkPXqnUMZ0wSZKIv3HL+oHyW6vpqeo1NAKeO3Wxy5qizlYz63km9Lg W1ViPb3VfMpaU0y8VNANcKGPe6DUn/vU6I2taXYzFr+5rOFPkVwOESb4Ie75ddDopgJePTsXSZy CMXUZnrUDgAexWpSB03cXPMgAp7cl3sekRgNbNiMb0TRWlAV9APMqEHHdSvKPQV+vs6g8XHMPTP SI7CUhxBRm0Ws79aR9ydugBI1xGmyC8RDt3ByIDnu9Jr8z0m/gUW/qlnk4wKRrlO/aln/eiru5s fIz3bXcNFypCNiXgzizJpow== X-Received: by 2002:a17:902:f64a:b0:294:7048:643 with SMTP id d9443c01a7336-29470480f8fmr67499645ad.15.1761315790765; Fri, 24 Oct 2025 07:23:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF4MPeSwFhzPTKvaKRf1XESN9sP6R6a1VjFKBw7Sdaagyby5CvwLmehW1f6noOGu/6x8AKqOA== X-Received: by 2002:a17:902:f64a:b0:294:7048:643 with SMTP id d9443c01a7336-29470480f8fmr67499295ad.15.1761315790217; Fri, 24 Oct 2025 07:23:10 -0700 (PDT) Received: from [10.204.104.20] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33e1ed68869sm5129253a91.0.2025.10.24.07.23.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Oct 2025 07:23:09 -0700 (PDT) Message-ID: <7c563e83-031c-445c-bcfa-c04f4729622d@oss.qualcomm.com> Date: Fri, 24 Oct 2025 19:53:03 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] drm/msm/a6xx: Add support for Adreno 612 To: rob.clark@oss.qualcomm.com, Konrad Dybcio Cc: Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Jie Zhang References: <20251017-qcs615-spin-2-v1-0-0baa44f80905@oss.qualcomm.com> <20251017-qcs615-spin-2-v1-1-0baa44f80905@oss.qualcomm.com> <44ff81bf-8970-475c-a4f5-c03220bc8c3f@oss.qualcomm.com> <97aeb6a1-fda2-440f-b14b-2f3dbc2d7e8e@oss.qualcomm.com> <5e64c246-a424-42c9-b102-e1a2af579936@oss.qualcomm.com> Content-Language: en-US From: Akhil P Oommen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDIxMDE2NyBTYWx0ZWRfXwu9eTbwFNkbU 3BY6WUOaH59sRtANLFY2t8Q0yaAYiJvzXU5ybTUOlH9bMxKw4YuhQu3WCnygIqRt2sfRfY9TRsp 0RKx5sampRkCmCi3uBeZhTGyCBEyOh1zjeo1Y+DdjITi2YnMcjbH4IRiQzN5QUNUctlIjMvSa5n 3n50MRr0ZL8wvAsq09lTeFpWUlE4JRtRBrc8ZSdfVZTpjOkch8b1kIXRGtOihYa9A6OSjYxPckd 7qXbiXYcvqtBSvV9WjcjPnQeum2uIiF7I6D8Vh8yNLpZ1hsGg4YX5Y7clU46iQK3bQXTLG38JdB ImmaIfgsMQuNnIRG3q5+aXms5huTfJm4RV9qoWaPSjoz77x5jmueGD6pqIxBZdTRPKWVjms1cb7 Yv/94gfv+O29He3+p3J2QNb71rmXlg== X-Proofpoint-ORIG-GUID: 44vCp_k2vtFve1XcSdYzDDF9KNm4picc X-Authority-Analysis: v=2.4 cv=WYUBqkhX c=1 sm=1 tr=0 ts=68fb8bd0 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=COk6AnOGAAAA:8 a=Kgau_Mukr_2Uqyo6pRUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: 44vCp_k2vtFve1XcSdYzDDF9KNm4picc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-24_02,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 bulkscore=0 impostorscore=0 spamscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510210167 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 10/24/2025 6:46 PM, Rob Clark wrote: > On Fri, Oct 24, 2025 at 12:55 AM Konrad Dybcio > wrote: >> >> On 10/24/25 12:57 AM, Akhil P Oommen wrote: >>> On 10/22/2025 8:43 PM, Konrad Dybcio wrote: >>>> On 10/17/25 7:08 PM, Akhil P Oommen wrote: >>>>> From: Jie Zhang >>>>> >>>>> Add support for Adreno 612 GPU found in SM6150/QCS615 chipsets. >>>>> A612 falls under ADRENO_6XX_GEN1 family and is a cut down version >>>>> of A615 GPU. >>>>> >>>>> A612 has a new IP called Reduced Graphics Management Unit or RGMU >>>>> which is a small state machine which helps to toggle GX GDSC >>>>> (connected to CX rail) to implement IFPC feature. It doesn't support >>>>> any other features of a full fledged GMU like clock control, resource >>>>> voting to rpmh etc. So we need linux clock driver support like other >>>>> gmu-wrapper implementations to control gpu core clock and gpu GX gdsc. >>>>> This patch skips RGMU core initialization and act more like a >>>>> gmu-wrapper case. >>>>> >>>>> Co-developed-by: Akhil P Oommen >>>>> Signed-off-by: Jie Zhang >>>>> Signed-off-by: Akhil P Oommen >>>>> --- >>>> >>>> [...] >>>> >>>>> @@ -350,12 +350,18 @@ static const struct a6xx_gmu_oob_bits a6xx_gmu_oob_bits[] = { >>>>> /* Trigger a OOB (out of band) request to the GMU */ >>>>> int a6xx_gmu_set_oob(struct a6xx_gmu *gmu, enum a6xx_gmu_oob_state state) >>>>> { >>>>> + struct a6xx_gpu *a6xx_gpu = container_of(gmu, struct a6xx_gpu, gmu); >>>>> + struct adreno_gpu *adreno_gpu = &a6xx_gpu->base; >>>>> int ret; >>>>> u32 val; >>>>> int request, ack; >>>>> >>>>> WARN_ON_ONCE(!mutex_is_locked(&gmu->lock)); >>>>> >>>>> + /* Skip OOB calls since RGMU is not enabled */ >>>> >>>> "RGMU doesn't handle OOB calls" >>> >>> Technically RGMU can handle OOB calls. But we are not initializing rgmu. >> >> Oh, I glossed over that.. >> >> IIRC the reason we delayed 612 support in the past was to make sure >> that the RGMU FW is consumed, so that runtime requirements don't >> suddenly change one day. >> >> If you have no interest/way in getting it wholly supported right now, >> can you at least make sure that the driver requests the firmware and >> exits if it's absent? > > adreno_load_gpu() calls adreno_load_fw() first thing, and will bail if > gmu fw is missing. (zap fw is a bit more awkward since that could > come from dt or device table.) Correct. And RGMU firmware is available in linux-firmware repo. -Akhil. > > BR, > -R