From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
daniel@ffwll.ch, airlied@gmail.com, mripard@kernel.org,
maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/2] drm/atomic-helper: Add {begin,end}_fb_access to plane helpers
Date: Tue, 8 Nov 2022 13:10:05 +0100 [thread overview]
Message-ID: <7d0c25c3-8609-f8d1-b6ba-d9e6aaee9252@redhat.com> (raw)
In-Reply-To: <20221025101737.8874-2-tzimmermann@suse.de>
Hello Thomas,
On 10/25/22 12:17, Thomas Zimmermann wrote:> Add {begin,end}_fb_access helpers to run at the beginning and end of
> an atomic commit. The begin_fb_access helper aquires resources that
acquires
> are necessary to perform the atomic commit. It it similar to prepare_fb,
> except that the resources are to be released at the end of the commit.
> Resources acquired by prepare_fb are held until after the next pageflip.
>
> The end_fb_access helper performs the corresponding resource cleanup.
> Atomic helpers call it with the new plane state. This is differnt from
different
> cleanup_fb, which releases resources of the old plane state.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
The change makes sense to me.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2022-11-08 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 10:17 [PATCH v2 0/2] drm: Add new plane helpers to begin/end FB access Thomas Zimmermann
2022-10-25 10:17 ` [PATCH v2 1/2] drm/atomic-helper: Add {begin, end}_fb_access to plane helpers Thomas Zimmermann
2022-11-08 12:10 ` Javier Martinez Canillas [this message]
2022-10-25 10:17 ` [PATCH v2 2/2] drm/gem: Implement shadow-plane {begin, end}_fb_access with vmap Thomas Zimmermann
2022-11-08 12:18 ` [PATCH v2 2/2] drm/gem: Implement shadow-plane {begin,end}_fb_access " Javier Martinez Canillas
2022-10-31 9:46 ` [PATCH v2 0/2] drm: Add new plane helpers to begin/end FB access Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d0c25c3-8609-f8d1-b6ba-d9e6aaee9252@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).