From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 8/8] omapdrm: hdmi4: hook up the HDMI CEC support Date: Mon, 8 May 2017 13:26:39 +0300 Message-ID: <7d3ab159-9284-bcc8-80f0-cbc621769203@ti.com> References: <20170414102512.48834-1-hverkuil@xs4all.nl> <20170414102512.48834-9-hverkuil@xs4all.nl> <144b95df-8eb2-1307-1157-2eb2572c51aa@xs4all.nl> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0786722652==" Return-path: Received: from fllnx210.ext.ti.com (fllnx210.ext.ti.com [198.47.19.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 59F2489D4F for ; Mon, 8 May 2017 10:26:43 +0000 (UTC) In-Reply-To: <144b95df-8eb2-1307-1157-2eb2572c51aa@xs4all.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans Verkuil , linux-media@vger.kernel.org Cc: Peter Ujfalusi , Hans Verkuil , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0786722652== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mOtCcgobi96rDw5D6fOXSwWtKFPmpU0JB" --mOtCcgobi96rDw5D6fOXSwWtKFPmpU0JB Content-Type: multipart/mixed; boundary="fLVeqnQvpxH5TbpQtmm3J1cILeApiL5KH"; protected-headers="v1" From: Tomi Valkeinen To: Hans Verkuil , linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Hans Verkuil , Peter Ujfalusi Message-ID: <7d3ab159-9284-bcc8-80f0-cbc621769203@ti.com> Subject: Re: [PATCH 8/8] omapdrm: hdmi4: hook up the HDMI CEC support References: <20170414102512.48834-1-hverkuil@xs4all.nl> <20170414102512.48834-9-hverkuil@xs4all.nl> <144b95df-8eb2-1307-1157-2eb2572c51aa@xs4all.nl> In-Reply-To: <144b95df-8eb2-1307-1157-2eb2572c51aa@xs4all.nl> --fLVeqnQvpxH5TbpQtmm3J1cILeApiL5KH Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/05/17 14:58, Hans Verkuil wrote: > My assumption was that hdmi_display_disable() was called when the hotpl= ug would go > away. But I discovered that that isn't the case, or at least not when X= is running. > It seems that the actual HPD check is done in hdmic_detect() in > omapdrm/displays/connector-hdmi.c. For some HW it's done there (in the case there's no IP handling the HPD), but in some cases it's done in tpd12s015 driver (e.g. pandaboard), and in some cases it also could be done in the hdmi driver (if the HPD is handled by the HDMI IP, but at the moment we don't have this case supported in the SW). > But there I have no access to hdmi.core (needed for the hdmi4_cec_set_p= hys_addr() call). >=20 > Any idea how to solve this? I am not all that familiar with drm, let al= one omapdrm, > so if you can point me in the right direction, then that would be very = helpful. Hmm, indeed, looks the the output is kept enabled even if HPD drops and the connector status is changed to disconnected. I don't have a very good solution... I think we have to add a function to omapdss_hdmi_ops, which the connector-hdmi and tpd12s015 drivers can call when they detect a HPD change. That call would go to the HDMI IP driver. Peter is about to send hotplug-interrupt-handling series, I think the HPD function work should be done on top of that, as otherwise it'll just conflict horribly. Tomi --fLVeqnQvpxH5TbpQtmm3J1cILeApiL5KH-- --mOtCcgobi96rDw5D6fOXSwWtKFPmpU0JB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZEEffAAoJEPo9qoy8lh71HzMP/jFLAU/SdF+FAyllt2iXxqXo Y3nQq2aO6ubxL5zg6484ryv8xMur2D8+2xmzi/OECC0ayhKePKN3tFEVMy4SVB+z 4hY0tjawEY455MSpKMjuSHM+XhEfCZwel1C7OjhE/34yJGWG9o9zPC5Pt11QwAw0 jqpq/8Ook4K5AXs+fc9XakvzJA2vM6vntiLm4oZOUjsP4lLnhPfvkCX15+ilmyCT P8K4CPdu0TEpK6PXsI9du53vvXlHqJjWif592ih7JERyVv5sBG1aQaSyM6vWyvV9 IaLgG6ov1JBamkumsg0oYiiHWaU5PHOgenzlizM/aBqhe1uX9qNVmyU1R0+561Rk rjakLVcOOHelNodskMO05gEQkQeNY0zHPIQI6G2rBPbHS1kHtjssD76G5KqTEjLi lPCPk+MY9S2pLxa+RzIUKrQk9jC9jtK/Uog1JDruUMzfrr2V0TbROLkcqnW9j+2u gH2mfAQIToMrFFFeBssr45K/H+XB18dMEJdQzssayGXdSv/JcVWRksqS+tDFJc8c stF1ABEQrEiKUnhkcfANUWImPI80Oy7URWPyTC2EBapll2l3wzgI2By1AOI2aBSL U35da6vt+SRwhDi4l1ktfO2owcVsKrUEYkV7uePSWdyST5Hc47mwEm48lljzcGKE +McqsyZsIBwNNniN6v8K =OXE+ -----END PGP SIGNATURE----- --mOtCcgobi96rDw5D6fOXSwWtKFPmpU0JB-- --===============0786722652== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0786722652==--