From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F1B2C4332F for ; Thu, 20 Oct 2022 07:30:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 17AE210E3CF; Thu, 20 Oct 2022 07:30:27 +0000 (UTC) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by gabe.freedesktop.org (Postfix) with ESMTPS id F232010E3CF for ; Thu, 20 Oct 2022 07:30:25 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id F31755808CC; Thu, 20 Oct 2022 03:30:24 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Thu, 20 Oct 2022 03:30:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1666251024; x=1666258224; bh=wOxLCzcVu+ q+SEyBn/M4QllQRne63QwVrmt2BoYxq6o=; b=DB0KPjPqIj/nbnYmjgdk0kCApn aVNrHAQUjdw5QcGUS9R59jqK3joi2g74adqnI0MmeDADz+cBP8HjR3FjsgxGJszU p7fKM+Yv2Fz+EuiBub/9XJaJVi/9TirMoM1DjawknQWEzHchWNPsl6pnKdzdgKgm HvgBa7nfN6nWlTRqU05OkOZwHXJo+MwEcGdGgEHDxOMRBuGQISe87t4xOJKUHYra sMFrtpuBVPevYu2OkPxDX6bxJZ38fenQBKR+9kX4f+tCmeFFSHIYyDUmpKbjyRUq dpKGnV8CZUqRSZ6eN3b8CXbIKEZqyylRN+lsUr65byN/Hk1sl9+IVSko+5QQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1666251024; x=1666258224; bh=wOxLCzcVu+q+SEyBn/M4QllQRne6 3QwVrmt2BoYxq6o=; b=URPrxE7B17bixo89Pz9gzBBvqySx2hF97gJCAd+ebL/7 kcG0y4nvK22Qh9tt4OKq8DtlgClI/rhX96NTFg1Hngkyyq5qF6fXp845XARp65bt wEnkduta/m/nuPAEj+loUCHG0sm9CqNdEds3ZxbVU9y4oenFNSi4W6XHHipJHXUO irBXEM1d7oo/igL7tNEEJSt2M6tp3/nWO5tN55L05H//4mZp/c56nwyWm2lw0yMH MDMzLWwiJHCteWb4eOBQewYJMD1Z4V1vnr7UPgKMlFu3zR2kGeeCreGbh455udxg b8Qkvq7qOkGpMcj9NyxDlv4QsnBI1g5eMXza/DX8Dw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeelhedguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeevhfffledtgeehfeffhfdtgedvheejtdfgkeeuvefgudffteettdekkeeu feehudenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 12D00B60086; Thu, 20 Oct 2022 03:30:22 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1047-g9e4af4ada4-fm-20221005.001-g9e4af4ad Mime-Version: 1.0 Message-Id: <7d9eebc8-39b6-4dc1-9ffc-f17ec584bee2@app.fastmail.com> In-Reply-To: References: <20221019161831.3864786-1-arnd@kernel.org> Date: Thu, 20 Oct 2022 09:30:03 +0200 From: "Arnd Bergmann" To: "Robert Jarzmik" , "Arnd Bergmann" Subject: Re: [PATCH 00/30] ARM: pxa: remove all unused boards&drivers Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-usb@vger.kernel.org, Vignesh Raghavendra , lgirdwood@gmail.com, Viresh Kumar , Ulf Hansson , Dominik Brodowski , perex@perex.cz, Wolfram Sang , patches@opensource.cirrus.com, linux-mtd@lists.infradead.org, philipp.zabel@gmail.com, Miquel Raynal , Damien Le Moal , kernel@wantstofly.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, Bartosz Golaszewski , Lee Jones , Russell King , marek.vasut@gmail.com, Alan Stern , lost.distance@yahoo.com, slapin@ossfans.org, alsa-devel@alsa-project.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Haojian Zhuang , "open list:GPIO SUBSYSTEM" , Mark Brown , sre@kernel.org, linux-fbdev@vger.kernel.org, tiwai@suse.com, linux-arm-kernel@lists.infradead.org, Felipe Balbi , mkpetch@internode.on.net, Sergey Shtylyov , linux-ide@vger.kernel.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, Dmitry Torokhov , "linux-mmc @ vger . kernel . org" , linux-kernel@vger.kernel.org, Sudip Mukherjee , Linux-Renesas , Greg Kroah-Hartman , Helge Deller , Daniel Mack Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Oct 19, 2022, at 23:13, Robert Jarzmik wrote: > Arnd Bergmann writes: > >> From: Arnd Bergmann > ...zip... > >> A good number of drivers become impossible to select after this, so >> each of these also get dropped. I'm including the driver patches in the >> series here and can either merge them through the soc tree, or they >> can get picked up by the individual subsystem maintainers. Since both >> the platform and the drivers get removed, the order should not matter. > This part is a bit ... bothering. > I at least identified these : >> delete mode 100644 drivers/input/touchscreen/wm9705.c >> delete mode 100644 drivers/input/touchscreen/wm9712.c >> delete mode 100644 drivers/input/touchscreen/wm9713.c >> delete mode 100644 drivers/input/touchscreen/wm97xx-core.c >> delete mode 100644 drivers/mfd/wm97xx-core.c >> delete mode 100644 sound/ac97/bus.c >> delete mode 100644 sound/ac97/codec.c >> delete mode 100644 sound/ac97/snd_ac97_compat.c > > For the existing platforms working with devicetree support (mioa701 for > example), the wm9713 was properly used, providing both sound support and input > touchscreen. > So was the a97 part, providing a framework to make the wm9713 work. > > So I'm wondering how the choice to chop these drivers was done, and it is > necessary to remove them. If so, maybe pxa support in the kernel should be > removed all together, as people playing with it loose part of the working DT > platforms they had. If the files are used for DT based machines, then they should definitely stay, the intention of my series was to only remove known dead code. What I did was to remove CONFIG_UNUSED_BOARD_FILES and then recursively trim out all code that could be compiled in before but not after this change, assuming that this would be safe. What I see here is that AC97_BUS_NEW and SND_PXA2XX_SOC_AC97 are selected by eight legacy board files (tosa, e740, e750, e800, em_x270, palm27x, zylonite and mioa701), but no DT based machine, so without CONFIG_UNUSED_BOARD_FILES, the entire AC97_BUS_NEW infrastructure and all drivers depending on this became dead code. Unfortunately I ran into problems sending out the rest of the series after sending the cover letter, so the explanations I put in the individual patches were not here. See [1] for the actual series. Since it looks like I'll have to redo half of the PXA patches after leaving AC97_BUS_NEW in, I won't post the full version first. Any idea where I went wrong here? Did I make a mistake in following the Kconfig dependencies, or are some parts of this incorrectly annotated? Arnd [1] https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=boardfile-remove&id=73c4b7cfbc2b2