From: Hans de Goede <hdegoede@redhat.com>
To: "Noralf Trønnes" <noralf@tronnes.org>, dri-devel@lists.freedesktop.org
Cc: jy0922.shim@samsung.com, daniel.vetter@ffwll.ch,
tomi.valkeinen@ti.com, sw0312.kim@samsung.com,
inki.dae@samsung.com, kyungmin.park@samsung.com,
bskeggs@redhat.com, rodrigo.vivi@intel.com,
alexander.deucher@amd.com, linux@armlinux.org.uk,
intel-gfx@lists.freedesktop.org, christian.koenig@amd.com,
mark.yao@rock-chips.com
Subject: Re: [PATCH 15/15] staging: vboxvideo: Use drm_fb_helper_lastclose()
Date: Mon, 23 Oct 2017 08:43:28 +0200 [thread overview]
Message-ID: <7f36a797-8901-9c2f-08c9-167d71a1cd2e@redhat.com> (raw)
In-Reply-To: <20171019230213.63521-16-noralf@tronnes.org>
HI,
On 20-10-17 01:02, Noralf Trønnes wrote:
> This driver can use drm_fb_helper_lastclose() as its .lastclose callback.
>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Thank you for doing this, looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/staging/vboxvideo/vbox_drv.c | 2 +-
> drivers/staging/vboxvideo/vbox_drv.h | 1 -
> drivers/staging/vboxvideo/vbox_main.c | 12 ------------
> 3 files changed, 1 insertion(+), 14 deletions(-)
>
> diff --git a/drivers/staging/vboxvideo/vbox_drv.c b/drivers/staging/vboxvideo/vbox_drv.c
> index e18642e5027e..a4d8d7898e3d 100644
> --- a/drivers/staging/vboxvideo/vbox_drv.c
> +++ b/drivers/staging/vboxvideo/vbox_drv.c
> @@ -229,7 +229,7 @@ static struct drm_driver driver = {
>
> .load = vbox_driver_load,
> .unload = vbox_driver_unload,
> - .lastclose = vbox_driver_lastclose,
> + .lastclose = drm_fb_helper_lastclose,
> .master_set = vbox_master_set,
> .master_drop = vbox_master_drop,
>
> diff --git a/drivers/staging/vboxvideo/vbox_drv.h b/drivers/staging/vboxvideo/vbox_drv.h
> index 4b9302703b36..7273d7e9bc9b 100644
> --- a/drivers/staging/vboxvideo/vbox_drv.h
> +++ b/drivers/staging/vboxvideo/vbox_drv.h
> @@ -128,7 +128,6 @@ struct vbox_private {
>
> int vbox_driver_load(struct drm_device *dev, unsigned long flags);
> void vbox_driver_unload(struct drm_device *dev);
> -void vbox_driver_lastclose(struct drm_device *dev);
>
> struct vbox_gem_object;
>
> diff --git a/drivers/staging/vboxvideo/vbox_main.c b/drivers/staging/vboxvideo/vbox_main.c
> index 80bd039fa08e..c3d756620fd5 100644
> --- a/drivers/staging/vboxvideo/vbox_main.c
> +++ b/drivers/staging/vboxvideo/vbox_main.c
> @@ -421,18 +421,6 @@ void vbox_driver_unload(struct drm_device *dev)
> vbox_hw_fini(vbox);
> }
>
> -/**
> - * @note this is described in the DRM framework documentation. AST does not
> - * have it, but we get an oops on driver unload if it is not present.
> - */
> -void vbox_driver_lastclose(struct drm_device *dev)
> -{
> - struct vbox_private *vbox = dev->dev_private;
> -
> - if (vbox->fbdev)
> - drm_fb_helper_restore_fbdev_mode_unlocked(&vbox->fbdev->helper);
> -}
> -
> int vbox_gem_create(struct drm_device *dev,
> u32 size, bool iskernel, struct drm_gem_object **obj)
> {
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-10-23 6:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 23:01 [PATCH 00/15] drm/fb-helper: Add .last_close and .output_poll_changed helpers Noralf Trønnes
2017-10-19 23:01 ` [PATCH 01/15] drm/fb-helper: Handle function NULL argument Noralf Trønnes
2017-10-19 23:02 ` [PATCH 02/15] drm: Add drm_device->drm_fb_helper_private pointer Noralf Trønnes
2017-10-20 13:29 ` Daniel Vetter
2017-10-20 13:52 ` Ville Syrjälä
2017-10-20 15:44 ` Noralf Trønnes
2017-10-20 16:00 ` Ville Syrjälä
2017-10-20 17:11 ` Noralf Trønnes
2017-10-30 9:25 ` Daniel Vetter
2017-10-19 23:02 ` [PATCH 03/15] drm/fb-helper: Add .last_close and .output_poll_changed helpers Noralf Trønnes
2017-10-19 23:02 ` [PATCH 04/15] drm/amdgpu: Use drm_fb_helper_lastclose() and _poll_changed() Noralf Trønnes
2017-10-19 23:02 ` [PATCH 05/15] drm/armada: " Noralf Trønnes
2017-10-23 10:10 ` Russell King - ARM Linux
2017-10-19 23:02 ` [PATCH 06/15] drm/exynos: " Noralf Trønnes
2017-10-19 23:02 ` [PATCH 07/15] drm/gma500: " Noralf Trønnes
2017-10-19 23:02 ` [PATCH 08/15] drm/i915: Use drm_fb_helper_output_poll_changed() Noralf Trønnes
2017-10-19 23:02 ` [PATCH 09/15] drm/msm: Use drm_fb_helper_lastclose() and _poll_changed() Noralf Trønnes
2017-10-19 23:02 ` [PATCH 10/15] drm/nouveau: Use drm_fb_helper_output_poll_changed() Noralf Trønnes
2017-10-19 23:02 ` [PATCH 11/15] drm/omap: Use drm_fb_helper_lastclose() and _poll_changed() Noralf Trønnes
2017-10-19 23:02 ` [PATCH 12/15] drm/radeon: " Noralf Trønnes
2017-10-19 23:02 ` [PATCH 13/15] drm/rockchip: " Noralf Trønnes
2017-10-19 23:02 ` [PATCH 14/15] drm/tegra: " Noralf Trønnes
2017-10-19 23:02 ` [PATCH 15/15] staging: vboxvideo: Use drm_fb_helper_lastclose() Noralf Trønnes
2017-10-23 6:43 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f36a797-8901-9c2f-08c9-167d71a1cd2e@redhat.com \
--to=hdegoede@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux@armlinux.org.uk \
--cc=mark.yao@rock-chips.com \
--cc=noralf@tronnes.org \
--cc=rodrigo.vivi@intel.com \
--cc=sw0312.kim@samsung.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox