dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: tanmay@codeaurora.org
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
	dri-devel <dri-devel-bounces@lists.freedesktop.org>,
	linux-arm-msm@vger.kernel.org, abhinavk@codeaurora.org,
	swboyd@chromium.org, seanpaul@chromium.org,
	dri-devel@lists.freedesktop.org, varar@codeaurora.org,
	aravindh@codeaurora.org, freedreno@lists.freedesktop.org
Subject: Re: [PATCH 1/2] dt-bindings: msm: disp: Add Display Port HPD GPIO bindings
Date: Mon, 27 Apr 2020 16:09:06 -0700	[thread overview]
Message-ID: <7fb3a6c19c244c4a37bded7cd249a1f8@codeaurora.org> (raw)
In-Reply-To: <20200415152439.GA9882@bogus>

Thanks Rob for reviews.

We are using Display Port Controller block to detect hot plug.
So we won't be using that pin as GPIO.

I found now that we don't need any bindings for that pin in such case.
So I am abandoning this patch series and upload new patch.

Thanks.

On 2020-04-15 08:24, Rob Herring wrote:
> On Tue, Apr 07, 2020 at 03:48:28PM -0700, Tanmay Shah wrote:
>> Add Display Port HPD GPIO description in bindings
>> 
>> This Patch depends on:
>> 	https://patchwork.kernel.org/patch/11468505/
> 
> This belongs below the '---' and probably means you should send all 
> this
> as one series.
> 
>> 
>> Signed-off-by: Tanmay Shah <tanmay@codeaurora.org>
>> ---
>>  Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml | 7
> +++++++
>>  1 file changed, 7 insertions(+)
>> 
>> diff --git
> a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml
> b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml
>> index 761a01d..003f5f7 100644
>> --- a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml
>> @@ -155,6 +155,11 @@ properties:
>>       data-lanes:
>>         description: Maximum number of lanes that can be used for
> Display port.
>> 
>> +     dp-hpd-gpio:
> 
> We already have a standard property for this. Use it.
> 
> It belongs in the connector node as HPD is part of the connector.
> 
>> +       maxItems: 1
>> +       description: Specifies HPD gpio for DP connector without
>> +                    USB PHY or AUX switch.
>> +
>>       usbplug-cc-gpio:
> 
> Note that this too should be in a connector node.
> 
>>         maxItems: 1
>>         description: Specifies the usbplug orientation gpio.
>> @@ -282,6 +287,8 @@ examples:
>>          aux-sel-gpio = <&msmgpio 110 1>;
>>          usbplug-cc-gpio = <&msmgpio 90 1>;
>> 
>> +        dp-hpd-gpio = <&msmgpio 117 0>;
>> +
>>          ports {
>>              #address-cells = <1>;
>>              #size-cells = <0>;
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
> Forum,
>> a Linux Foundation Collaborative Project
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2020-04-27 23:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07 22:48 [PATCH 1/2] dt-bindings: msm: disp: Add Display Port HPD GPIO bindings Tanmay Shah
2020-04-07 22:48 ` [PATCH 2/2] drm/msm/dp: Add Hot Plug Detect feature Tanmay Shah
2020-04-15 15:24 ` [PATCH 1/2] dt-bindings: msm: disp: Add Display Port HPD GPIO bindings Rob Herring
2020-04-27 23:09   ` tanmay [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7fb3a6c19c244c4a37bded7cd249a1f8@codeaurora.org \
    --to=tanmay@codeaurora.org \
    --cc=abhinavk@codeaurora.org \
    --cc=aravindh@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel-bounces@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=seanpaul@chromium.org \
    --cc=swboyd@chromium.org \
    --cc=varar@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).