From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 8/8] dma-buf: nuke reservation_object seq number Date: Wed, 7 Aug 2019 14:08:38 +0200 Message-ID: <7fc516cd-bbd7-1829-1851-7d7deadb0468@gmail.com> References: <20190806150134.104222-1-christian.koenig@amd.com> <20190806150134.104222-8-christian.koenig@amd.com> <156512144622.6198.5051468008483309313@skylake-alporthouse-com> Reply-To: christian.koenig@amd.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <156512144622.6198.5051468008483309313@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org List-Id: dri-devel@lists.freedesktop.org QW0gMDYuMDguMTkgdW0gMjE6NTcgc2NocmllYiBDaHJpcyBXaWxzb246Cj4gUXVvdGluZyBDaHJp c3RpYW4gS8O2bmlnICgyMDE5LTA4LTA2IDE2OjAxOjM0KQo+PiBUaGUgb25seSByZW1haW5pbmcg dXNlIGZvciB0aGlzIGlzIHRvIHByb3RlY3QgYWdhaW5zdCBzZXR0aW5nIGEgbmV3IGV4Y2x1c2l2 ZQo+PiBmZW5jZSB3aGlsZSB3ZSBncmFiIGJvdGggZXhjbHVzaXZlIGFuZCBzaGFyZWQuIFRoYXQg Y2FuIGFsc28gYmUgYXJjaGl2ZWQgYnkKPj4gbG9va2luZyBpZiB0aGUgZXhjbHVzaXZlIGZlbmNl IGhhcyBjaGFuZ2VkIG9yIG5vdCBhZnRlciBjb21wbGV0aW5nIHRoZQo+PiBvcGVyYXRpb24uCj4+ Cj4+IFNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1k LmNvbT4KPj4gLS0tCj4+ICAgZHJpdmVycy9kbWEtYnVmL3Jlc2VydmF0aW9uLmMgfCAyMCArKyst LS0tLS0tLS0tLS0tLS0tLQo+PiAgIGluY2x1ZGUvbGludXgvcmVzZXJ2YXRpb24uaCAgIHwgIDkg KystLS0tLS0tCj4+ICAgMiBmaWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDI0IGRlbGV0 aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kbWEtYnVmL3Jlc2VydmF0aW9uLmMg Yi9kcml2ZXJzL2RtYS1idWYvcmVzZXJ2YXRpb24uYwo+PiBpbmRleCA4MzlkNzJhZjdhZDguLjQz NTQ5YTRkNjY1OCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9kbWEtYnVmL3Jlc2VydmF0aW9uLmMK Pj4gKysrIGIvZHJpdmVycy9kbWEtYnVmL3Jlc2VydmF0aW9uLmMKPj4gQEAgLTQ5LDEyICs0OSw2 IEBACj4+ICAgREVGSU5FX1dEX0NMQVNTKHJlc2VydmF0aW9uX3d3X2NsYXNzKTsKPj4gICBFWFBP UlRfU1lNQk9MKHJlc2VydmF0aW9uX3d3X2NsYXNzKTsKPj4gICAKPj4gLXN0cnVjdCBsb2NrX2Ns YXNzX2tleSByZXNlcnZhdGlvbl9zZXFjb3VudF9jbGFzczsKPj4gLUVYUE9SVF9TWU1CT0wocmVz ZXJ2YXRpb25fc2VxY291bnRfY2xhc3MpOwo+PiAtCj4+IC1jb25zdCBjaGFyIHJlc2VydmF0aW9u X3NlcWNvdW50X3N0cmluZ1tdID0gInJlc2VydmF0aW9uX3NlcWNvdW50IjsKPj4gLUVYUE9SVF9T WU1CT0wocmVzZXJ2YXRpb25fc2VxY291bnRfc3RyaW5nKTsKPj4gLQo+PiAgIC8qKgo+PiAgICAq IHJlc2VydmF0aW9uX29iamVjdF9saXN0X2FsbG9jIC0gYWxsb2NhdGUgZmVuY2UgbGlzdAo+PiAg ICAqIEBzaGFyZWRfbWF4OiBudW1iZXIgb2YgZmVuY2VzIHdlIG5lZWQgc3BhY2UgZm9yCj4+IEBA IC0xMDMsOSArOTcsNiBAQCBzdGF0aWMgdm9pZCByZXNlcnZhdGlvbl9vYmplY3RfbGlzdF9mcmVl KHN0cnVjdCByZXNlcnZhdGlvbl9vYmplY3RfbGlzdCAqbGlzdCkKPj4gICB2b2lkIHJlc2VydmF0 aW9uX29iamVjdF9pbml0KHN0cnVjdCByZXNlcnZhdGlvbl9vYmplY3QgKm9iaikKPj4gICB7Cj4+ ICAgICAgICAgIHd3X211dGV4X2luaXQoJm9iai0+bG9jaywgJnJlc2VydmF0aW9uX3d3X2NsYXNz KTsKPj4gLQo+PiAtICAgICAgIF9fc2VxY291bnRfaW5pdCgmb2JqLT5zZXEsIHJlc2VydmF0aW9u X3NlcWNvdW50X3N0cmluZywKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgJnJlc2VydmF0aW9u X3NlcWNvdW50X2NsYXNzKTsKPj4gICAgICAgICAgUkNVX0lOSVRfUE9JTlRFUihvYmotPmZlbmNl LCBOVUxMKTsKPj4gICAgICAgICAgUkNVX0lOSVRfUE9JTlRFUihvYmotPmZlbmNlX2V4Y2wsIE5V TEwpOwo+PiAgIH0KPj4gQEAgLTI4MiwxMiArMjczLDEwIEBAIHZvaWQgcmVzZXJ2YXRpb25fb2Jq ZWN0X2FkZF9leGNsX2ZlbmNlKHN0cnVjdCByZXNlcnZhdGlvbl9vYmplY3QgKm9iaiwKPj4gICAg ICAgICAgICAgICAgICBkbWFfZmVuY2VfZ2V0KGZlbmNlKTsKPj4gICAKPj4gICAgICAgICAgcHJl ZW1wdF9kaXNhYmxlKCk7Cj4+IC0gICAgICAgd3JpdGVfc2VxY291bnRfYmVnaW4oJm9iai0+c2Vx KTsKPj4gLSAgICAgICAvKiB3cml0ZV9zZXFjb3VudF9iZWdpbiBwcm92aWRlcyB0aGUgbmVjZXNz YXJ5IG1lbW9yeSBiYXJyaWVyICovCj4+ICAgICAgICAgIFJDVV9JTklUX1BPSU5URVIob2JqLT5m ZW5jZV9leGNsLCBmZW5jZSk7Cj4gSSB0aGluaywgbm93IGhhcyB0byBiZSByY3VfYXNzaWduX3Bv aW50ZXIuCj4KPiAgICogSW5pdGlhbGl6ZSBhbiBSQ1UtcHJvdGVjdGVkIHBvaW50ZXIgaW4gc3Bl Y2lhbCBjYXNlcyB3aGVyZSByZWFkZXJzCj4gICAqIGRvIG5vdCBuZWVkIG9yZGVyaW5nIGNvbnN0 cmFpbnRzIG9uIHRoZSBDUFUgb3IgdGhlIGNvbXBpbGVyLiAgVGhlc2UKPiAgICogc3BlY2lhbCBj YXNlcyBhcmU6Cj4gICAqCj4gICAqIDEuICAgVGhpcyB1c2Ugb2YgUkNVX0lOSVRfUE9JTlRFUigp IGlzIE5VTExpbmcgb3V0IHRoZSBwb2ludGVyICpvcioKPiAgICogMi4gICBUaGUgY2FsbGVyIGhh cyB0YWtlbiB3aGF0ZXZlciBzdGVwcyBhcmUgcmVxdWlyZWQgdG8gcHJldmVudAo+ICAgKiAgICAg IFJDVSByZWFkZXJzIGZyb20gY29uY3VycmVudGx5IGFjY2Vzc2luZyB0aGlzIHBvaW50ZXIgKm9y Kgo+ICAgKiAzLiAgIFRoZSByZWZlcmVuY2VkIGRhdGEgc3RydWN0dXJlIGhhcyBhbHJlYWR5IGJl ZW4gZXhwb3NlZCB0bwo+ICAgKiAgICAgIHJlYWRlcnMgZWl0aGVyIGF0IGNvbXBpbGUgdGltZSBv ciB2aWEgcmN1X2Fzc2lnbl9wb2ludGVyKCkgKmFuZCoKPiAgICoKPiAgICogICAgICBhLiAgICAg IFlvdSBoYXZlIG5vdCBtYWRlICphbnkqIHJlYWRlci12aXNpYmxlIGNoYW5nZXMgdG8KPiAgICog ICAgICAgICAgICAgIHRoaXMgc3RydWN0dXJlIHNpbmNlIHRoZW4gKm9yKgo+ICAgKiAgICAgIGIu ICAgICAgSXQgaXMgT0sgZm9yIHJlYWRlcnMgYWNjZXNzaW5nIHRoaXMgc3RydWN0dXJlIGZyb20g aXRzCj4gICAqICAgICAgICAgICAgICBuZXcgbG9jYXRpb24gdG8gc2VlIHRoZSBvbGQgc3RhdGUg b2YgdGhlIHN0cnVjdHVyZS4gIChGb3IKPiAgICogICAgICAgICAgICAgIGV4YW1wbGUsIHRoZSBj aGFuZ2VzIHdlcmUgdG8gc3RhdGlzdGljYWwgY291bnRlcnMgb3IgdG8KPiAgICogICAgICAgICAg ICAgIG90aGVyIHN0YXRlIHdoZXJlIGV4YWN0IHN5bmNocm9uaXphdGlvbiBpcyBub3QgcmVxdWly ZWQuKQo+Cj4gV2UgdXNlZCB0byBhcHBseSAyIGZyb20gdGhlIHNlcWNvdW50LCBhbmQgMyBkb2Vz IG5vdCBhcHBseSBoZXJlLgo+Cj4+ICsgICAgICAgLyogcG9pbnRlciB1cGRhdGUgbXVzdCBiZSB2 aXNpYmxlIGJlZm9yZSB3ZSBtb2RpZnkgdGhlIHNoYXJlZF9jb3VudCAqLwo+PiAgICAgICAgICBp ZiAob2xkKQo+PiAtICAgICAgICAgICAgICAgb2xkLT5zaGFyZWRfY291bnQgPSAwOwo+PiAtICAg ICAgIHdyaXRlX3NlcWNvdW50X2VuZCgmb2JqLT5zZXEpOwo+PiArICAgICAgICAgICAgICAgc21w X3N0b3JlX21iKG9sZC0+c2hhcmVkX2NvdW50LCAwKTsKPiBIbW0uIE9rLCBJIHRoaW5rLgo+Cj4+ ICAgewo+PiAtICAgICAgIHVuc2lnbmVkIGludCBzZXE7Cj4+IC0KPj4gICAgICAgICAgZG8gewo+ PiAtICAgICAgICAgICAgICAgc2VxID0gcmVhZF9zZXFjb3VudF9iZWdpbigmb2JqLT5zZXEpOwo+ PiAgICAgICAgICAgICAgICAgICpleGNsID0gcmN1X2RlcmVmZXJlbmNlKG9iai0+ZmVuY2VfZXhj bCk7Cj4+ICAgICAgICAgICAgICAgICAgKmxpc3QgPSByY3VfZGVyZWZlcmVuY2Uob2JqLT5mZW5j ZSk7Cj4+IC0gICAgICAgfSB3aGlsZSAocmVhZF9zZXFjb3VudF9yZXRyeSgmb2JqLT5zZXEsIHNl cSkpOwo+PiArICAgICAgICAgICAgICAgc21wX3JtYigpOyAvKiBTZWUgcmVzZXJ2YXRpb25fb2Jq ZWN0X2FkZF9leGNsX2ZlbmNlICovCj4+ICsgICAgICAgfSB3aGlsZSAocmN1X2FjY2Vzc19wb2lu dGVyKG9iai0+ZmVuY2VfZXhjbCkgIT0gKmV4Y2wpOwo+PiAgIH0KPiBTbywgaWYgd2UgYXJlIGFk ZF9leGNsX2ZlbmNlIGFuZCBjYW5jZWxsaW5nIGEgc2hhcmVkLWxpc3QsIGJlZm9yZSB3ZQo+IHJl dHVybiB3ZSBndWFyYW50ZWUgdGhhdCB0aGUgc2hhcmVkLWxpc3QgaXMgc2V0IHRvIHplcm8gaWYg ZXhjbCBpcyBzZXQKPiBhcyB3ZSByZWFkLgo+Cj4gSWYgd2UgYWRkIHRvIHNoYXJlZC1saXN0IGR1 cmluZyB0aGUgcmVhZCwgLi4uIEhtbSwgYWN0dWFsbHkgd2Ugc2hvdWxkCj4gcmV0dXJuIG51bV9s aXN0LCBpLmUuCj4KPiBkbyB7Cj4gCSpsaXN0ID0gcmN1X2RlcmVmZXJlbmNlKG9iai0+ZmVuY2Up Owo+IAludW1fbGlzdCA9ICpsaXN0ID8gKCpsaXN0KS0+Y291bnQgOiAwOwo+IAlzbXBfcm1iKCk7 Cj4gfSB3aGlsZSAoLi4uKQo+Cj4gcmV0dXJuIG51bV9saXN0Lgo+Cj4gYXMgdGhlIHJlbGF0aW9u c2hpcCBiZXR3ZWVuIHRoZSBjb3VudCBhbmQgdGhlIGZlbmNlIGVudHJpZXMgaXMgYWxzbwo+IGRl dGVybWluZWQgYnkgdGhlIG1iIGluIGFkZF9zaGFyZWRfZmVuY2UuCgpJJ3ZlIHJlYWQgdGhhdCBt dWx0aXBsZSB0aW1lcyBub3csIGJ1dCBjYW4ndCBmb2xsb3cuIFdoeSBzaG91bGQgd2UgZG8gdGhp cz8KClRoZSBvbmx5IGltcG9ydGFudCB0aGluZyBpcyB0aGF0IHRoZSByZWFkZXJzIHNlZSB0aGUg bmV3IGZlbmNlIGJlZm9yZSAKdGhlIGluY3JlbWVudCBvZiB0aGUgbnVtYmVyIG9mIGZlbmNlcy4K CldoZW4geW91IHNlZSB0aGlzIGlzIHJhdGhlciBpcnJlbGV2YW50LgoKQ2hyaXN0aWFuLgoKPgo+ IE9vcHMsIHRoYXQgd2FzIGFuIG92ZXJzaWdodCBpbiB0aGUgcHJldmlvdXMgcmV2aWV3Lgo+Cj4+ ICAgICAgICAgIHByZWVtcHRfZW5hYmxlKCk7Cj4+ICAgCj4+ICAgICAgICAgIC8qIGlucGxhY2Ug dXBkYXRlLCBubyBzaGFyZWQgZmVuY2VzICovCj4+IEBAIC0zNzAsMTEgKzM1OSw4IEBAIGludCBy ZXNlcnZhdGlvbl9vYmplY3RfY29weV9mZW5jZXMoc3RydWN0IHJlc2VydmF0aW9uX29iamVjdCAq ZHN0LAo+PiAgICAgICAgICBvbGQgPSByZXNlcnZhdGlvbl9vYmplY3RfZ2V0X2V4Y2woZHN0KTsK Pj4gICAKPj4gICAgICAgICAgcHJlZW1wdF9kaXNhYmxlKCk7Cj4+IC0gICAgICAgd3JpdGVfc2Vx Y291bnRfYmVnaW4oJmRzdC0+c2VxKTsKPj4gLSAgICAgICAvKiB3cml0ZV9zZXFjb3VudF9iZWdp biBwcm92aWRlcyB0aGUgbmVjZXNzYXJ5IG1lbW9yeSBiYXJyaWVyICovCj4+ICAgICAgICAgIFJD VV9JTklUX1BPSU5URVIoZHN0LT5mZW5jZV9leGNsLCBuZXcpOwo+IHJjdV9hc3NpZ25fcG9pbnRl ciBhZ2FpbiBJIGJlbGlldmUuCj4gLUNocmlzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWw=