From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 0/9] drm: meson: global clean-up (use proper macros, update comments ...) Date: Mon, 24 Jun 2019 16:24:35 -0700 Message-ID: <7ho92mwor0.fsf@baylibre.com> References: <86zhm782g5.fsf@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <86zhm782g5.fsf@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org To: Neil Armstrong Cc: linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Julien Masson List-Id: dri-devel@lists.freedesktop.org Julien Masson writes: > This patch series aims to clean-up differents parts of the drm meson > code source. > > Couple macros have been defined and used to set several registers > instead of using magic constants. > > I also took the opportunity to: > - add/remove/update comments > - remove useless code > - minor fix/improvment Nice set of cleanups, thanks! I especially like the extra in-code comments. Could you also add to the cover-letter how this was tested, and on what platforms so we know it's not going to introduce any regressions. Thanks, Kevin