dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/armada: Use the correct prototype for a struct file_operations .write function
@ 2025-08-09 21:16 Christophe JAILLET
  0 siblings, 0 replies; only message in thread
From: Christophe JAILLET @ 2025-08-09 21:16 UTC (permalink / raw)
  To: Russell King, David Airlie, Simona Vetter, Rob Clark
  Cc: linux-kernel, kernel-janitors, Christophe JAILLET, Russell King,
	dri-devel

.write functions from struct file_operations return a ssize_t not an int.

This is maybe not an issue for architectures that use this driver, but it
is nicer to explicitly use the correct return type.

Fixes: 96f60e37dc66 ("DRM: Armada: Add Armada DRM driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Spotted while looking at something else and trying to compile the file on a
x86_64 using:
  make -j8 drivers/gpu/drm/armada/armada_debugfs.o
---
 drivers/gpu/drm/armada/armada_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/armada/armada_debugfs.c b/drivers/gpu/drm/armada/armada_debugfs.c
index a763349dd89f..96aebd56272f 100644
--- a/drivers/gpu/drm/armada/armada_debugfs.c
+++ b/drivers/gpu/drm/armada/armada_debugfs.c
@@ -49,7 +49,7 @@ static int armada_debugfs_crtc_reg_open(struct inode *inode, struct file *file)
 			   inode->i_private);
 }
 
-static int armada_debugfs_crtc_reg_write(struct file *file,
+static ssize_t armada_debugfs_crtc_reg_write(struct file *file,
 	const char __user *ptr, size_t len, loff_t *off)
 {
 	struct armada_crtc *dcrtc;
-- 
2.50.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2025-08-09 21:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-09 21:16 [PATCH] drm/armada: Use the correct prototype for a struct file_operations .write function Christophe JAILLET

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).