From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53B31C433EF for ; Fri, 6 May 2022 08:54:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4FF7010EFE7; Fri, 6 May 2022 08:54:28 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0284C10EFD5 for ; Fri, 6 May 2022 08:54:26 +0000 (UTC) Received: from p508fcb34.dip0.t-ipconnect.de ([80.143.203.52] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmtjD-0005t9-LO; Fri, 06 May 2022 10:54:23 +0200 From: Heiko Stuebner To: Sascha Hauer Subject: Re: [PATCH v11 16/24] arm64: dts: rockchip: rk356x: Add VOP2 nodes Date: Fri, 06 May 2022 10:54:18 +0200 Message-ID: <8099476.NyiUUSuA9g@phil> In-Reply-To: <20220506071028.GS4012@pengutronix.de> References: <20220422072841.2206452-1-s.hauer@pengutronix.de> <2508329.Lt9SDvczpP@diego> <20220506071028.GS4012@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Peter Geis , Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Andy Yan , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am Freitag, 6. Mai 2022, 09:10:28 CEST schrieb Sascha Hauer: > On Thu, May 05, 2022 at 09:23:03AM +0200, Heiko St=FCbner wrote: > > Am Donnerstag, 5. Mai 2022, 08:41:31 CEST schrieb Sascha Hauer: > > > On Thu, May 05, 2022 at 02:28:24AM +0200, Heiko St=FCbner wrote: > > > > Am Freitag, 22. April 2022, 09:28:33 CEST schrieb Sascha Hauer: > > > > > The VOP2 is the display output controller on the RK3568. Add the = node > > > > > for it to the dtsi file along with the required display-subsystem= node > > > > > and the iommu node. > > > > >=20 > > > > > Signed-off-by: Sascha Hauer > > > > > Acked-by: Rob Herring > > > > > --- > > > > > + vop: vop@fe040000 { > > > > > + reg =3D <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x100= 0>; > > > > > + reg-names =3D "regs", "gamma_lut"; > > > >=20 > > > > reg-names does not seem to be part of the dt-binding. > > > > Though now in the vop2-driver I see that the code uses that naming. > > > >=20 > > > > I guess we might want to just go the vop1-way by using numbered > > > > platform-resources via a follow-up patch and drop the regnames here? > > >=20 > > > Or we could document the reg-names properties in a follow-up patch. > > > Wouldn't that be better? > >=20 > > Also a possibility. Although that of course leads us into the naming > > bike-shed ;-) ... i.e. for reg-names I'd do "vop" + "gamme-lut" (dash i= nstead > > of underscore) - instead of the ones used right now. >=20 > I also like dashes better than underscores and "vop" describes it better > than the generic "reg" name, so at least the two of us don't need to > dive deeper into the naming bike-shed ;) :-D ... one problem solved already > > While using numbered resources would keep the commonality between > > both vops >=20 > I like the named resources better, but I'll leave it up to you. You > decide, I'll create fixup patches in either direction. ok, then let's go with the named-resources. As we'll need an Ack from DT-people, we should probably expedite this. Ideally I guess, do the dt-binding fixup + resend the fixed dt-node patches with it. From the original series those dt-nodes + the hdmi rate stuff is the only thing missing and the rates can be a separate thing. Heiko