From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Subject: Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup Date: Mon, 24 Dec 2018 15:52:55 +0100 Message-ID: <80d98ab2-dbf8-8d77-e5ca-07995cef0f1b@tronnes.org> References: <20181223004315.GA11455@al> <20181223005507.28328-1-peter@lekensteyn.nl> <20181223231033.GA31596@al> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id E215F6E5DB for ; Mon, 24 Dec 2018 14:53:02 +0000 (UTC) In-Reply-To: <20181223231033.GA31596@al> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Peter Wu Cc: lkp@01.org, rong.a.chen@intel.com, Daniel Vetter , Linux List Kernel Mailing , dri-devel@lists.freedesktop.org, kraxel@redhat.com, Linus Torvalds List-Id: dri-devel@lists.freedesktop.org CgpEZW4gMjQuMTIuMjAxOCAwMC4xMCwgc2tyZXYgUGV0ZXIgV3U6Cj4gT24gU3VuLCBEZWMgMjMs IDIwMTggYXQgMDI6NTU6NTJQTSArMDEwMCwgTm9yYWxmIFRyw7hubmVzIHdyb3RlOgo+Pgo+Pgo+ PiBEZW4gMjMuMTIuMjAxOCAwMS41NSwgc2tyZXYgUGV0ZXIgV3U6Cj4+PiBBZnRlciBkcm1fZmJf aGVscGVyX2ZiZGV2X3NldHVwIGNhbGxzIGRybV9mYl9oZWxwZXJfaW5pdCwKPj4+ICJkZXYtPmZi X2hlbHBlciIgd2lsbCBiZSBpbml0aWFsaXplZCAoYW5kIHRodXMgZHJtX2ZiX2hlbHBlcl9maW5p IHdpbGwKPj4+IGhhdmUgc29tZSBlZmZlY3QpLiBBZnRlciB0aGF0LCBkcm1fZmJfaGVscGVyX2lu aXRpYWxfY29uZmlnIGlzIGNhbGxlZAo+Pj4gd2hpY2ggbWF5IGNhbGwgdGhlICJmYl9wcm9iZSIg ZHJpdmVyIGNhbGxiYWNrLgo+Pj4KPj4+IFRoaXMgZHJpdmVyIGNhbGxiYWNrIG1heSBjYWxsIGRy bV9mYl9oZWxwZXJfZGVmaW9faW5pdCAoYXMgaXMgZG9uZSBieQo+Pj4gZHJtX2ZiX2hlbHBlcl9n ZW5lcmljX3Byb2JlKSBvciBzZXQgYSBmcmFtZWJ1ZmZlciAoYXMgaXMgZG9uZSBieSBib2NocykK Pj4+IGFzIGRvY3VtZW50ZWQuIFRoZXNlIGFyZSBub3JtYWxseSBjbGVhbmVkIHVwIG9uIGV4aXQg YnkKPj4+IGRybV9mYl9oZWxwZXJfZmJkZXZfdGVhcmRvd24gd2hpY2ggYWxzbyBjYWxscyBkcm1f ZmJfaGVscGVyX2ZpbmkuCj4+Pgo+Pj4gSWYgYW4gZXJyb3Igb2NjdXJzIGFmdGVyICJmYl9wcm9i ZSIsIGJ1dCBiZWZvcmUgc2V0dXAgaXMgY29tcGxldGUsIHRoZW4KPj4+IGNhbGxpbmcganVzdCBk cm1fZmJfaGVscGVyX2Zpbmkgd2lsbCBsZWFrIHJlc291cmNlcy4gVGhpcyB3YXMgdHJpZ2dlcmVk Cj4+PiBieSBkZjIwNTJjYzkyMiAoImJvY2hzOiBjb252ZXJ0IHRvIGRybV9mYl9oZWxwZXJfZmJk ZXZfc2V0dXAvdGVhcmRvd24iKToKPj4+Cj4+PiAgICAgICBbICAgNTAuMDA4MDMwXSBib2Noc2Ry bWZiOiBlbmFibGUgQ09ORklHX0ZCX0xJVFRMRV9FTkRJQU4gdG8gc3VwcG9ydCB0aGlzIGZyYW1l YnVmZmVyCj4+PiAgICAgICBbICAgNTAuMDA5NDM2XSBib2Nocy1kcm0gMDAwMDowMDowMi4wOiBb ZHJtOmRybV9mYl9oZWxwZXJfZmJkZXZfc2V0dXBdICpFUlJPUiogZmJkZXY6IEZhaWxlZCB0byBz ZXQgY29uZmlndXJhdGlvbiAocmV0PS0zOCkKPj4+ICAgICAgIFsgICA1MC4wMTE0NTZdIFtkcm1d IEluaXRpYWxpemVkIGJvY2hzLWRybSAxLjAuMCAyMDEzMDkyNSBmb3IgMDAwMDowMDowMi4wIG9u IG1pbm9yIDIKPj4+ICAgICAgIFsgICA1MC4wMTM2MDRdIFdBUk5JTkc6IENQVTogMSBQSUQ6IDEg YXQgZHJpdmVycy9ncHUvZHJtL2RybV9tb2RlX2NvbmZpZy5jOjQ3NyBkcm1fbW9kZV9jb25maWdf Y2xlYW51cCsweDI4MC8weDJhMAo+Pj4gICAgICAgWyAgIDUwLjAxNjE3NV0gQ1BVOiAxIFBJRDog MSBDb21tOiBzd2FwcGVyLzAgVGFpbnRlZDogRyAgICAgICAgICAgICAgICBUIDQuMjAuMC1yYzcg IzEKPj4+ICAgICAgIFsgICA1MC4wMTc3MzJdIEVJUDogZHJtX21vZGVfY29uZmlnX2NsZWFudXAr MHgyODAvMHgyYTAKPj4+ICAgICAgIC4uLgo+Pj4gICAgICAgWyAgIDUwLjAyMzE1NV0gQ2FsbCBU cmFjZToKPj4+ICAgICAgIFsgICA1MC4wMjMxNTVdICA/IGJvY2hzX2ttc19maW5pKzB4MWUvMHgz MAo+Pj4gICAgICAgWyAgIDUwLjAyMzE1NV0gID8gYm9jaHNfdW5sb2FkKzB4MTgvMHg0MAo+Pj4K Pj4+IFRoaXMgY2FuIGJlIHJlcHJvZHVjZWQgd2l0aCBRRU1VIGFuZCBDT05GSUdfRkJfTElUVExF X0VORElBTj1uLgo+Pj4KPj4+IExpbms6IGh0dHBzOi8vbGttbC5rZXJuZWwub3JnL3IvMjAxODEy MjEwODMyMjYuR0kyMzMzMkBzaGFvMi1kZWJpYW4KPj4+IExpbms6IGh0dHBzOi8vbGttbC5rZXJu ZWwub3JnL3IvMjAxODEyMjMwMDQzMTUuR0ExMTQ1NUBhbAo+Pj4gRml4ZXM6IDg3NDEyMTYzOTZi MiAoImRybS9mYi1oZWxwZXI6IEFkZCBkcm1fZmJfaGVscGVyX2ZiZGV2X3NldHVwL3RlYXJkb3du KCkiKQo+Pj4gUmVwb3J0ZWQtYnk6IGtlcm5lbCB0ZXN0IHJvYm90IDxyb25nLmEuY2hlbkBpbnRl bC5jb20+Cj4+PiBDYzogTm9yYWxmIFRyw7hubmVzIDxub3JhbGZAdHJvbm5lcy5vcmc+Cj4+PiBT aWduZWQtb2ZmLWJ5OiBQZXRlciBXdSA8cGV0ZXJAbGVrZW5zdGV5bi5ubD4KPj4+IC0tLQo+Pj4g ICAgZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYyB8IDIgKy0KPj4+ICAgIDEgZmlsZSBj aGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+Pj4KPj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9m Yl9oZWxwZXIuYwo+Pj4gaW5kZXggOWQ2NGY4NzRmOTY1Li40MzJlMGYzYjkyNjcgMTAwNjQ0Cj4+ PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4+PiArKysgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4+PiBAQCAtMjg2MCw3ICsyODYwLDcgQEAgaW50IGRy bV9mYl9oZWxwZXJfZmJkZXZfc2V0dXAoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPj4+ICAgIAly ZXR1cm4gMDsKPj4+ICAgIGVycl9kcm1fZmJfaGVscGVyX2Zpbmk6Cj4+PiAtCWRybV9mYl9oZWxw ZXJfZmluaShmYl9oZWxwZXIpOwo+Pj4gKwlkcm1fZmJfaGVscGVyX2ZiZGV2X3RlYXJkb3duKGRl dik7Cj4+Cj4+IFRoaXMgY2hhbmdlIHdpbGwgYnJlYWsgdGhlIGVycm9yIHBhdGggZm9yIGRybV9m YmRldl9nZW5lcmljX3NldHVwKCkKPj4gYmVjYXVzZSBkcm1fZmJfaGVscGVyX2dlbmVyaWNfcHJv YmUoKSBjbGVhbnMgdXAgb24gZXJyb3IgYnV0IGRvZXNuJ3QKPj4gY2xlYXIgZHJtX2ZiX2hlbHBl ci0+ZmIgcmVzdWx0aW5nIGluIGEgZG91YmxlIGRybV9mcmFtZWJ1ZmZlcl9yZW1vdmUoKS4KPiAK PiBUaGlzIHNob3VsZCBwcm9iYWJseSBjb25zaWRlcmVkIGEgYnVnIG9mIGRybV9mYl9oZWxwZXJf Z2VuZXJpY19wcm9iZS4KPiBPd25lcnNoaXAgb2YgZmJfaGVscGVyIHNob3VsZCByZW1haW4gd2l0 aCB0aGUgY2FsbGVyLiBUaGUgY2FsbGVyIGNhbgo+IGRldGVjdCBhbiBlcnJvciBhbmQgYWN0IGFj Y29yZGluZ2x5Lgo+IAo+PiBNeSBhc3N1bXB0aW9uIGhhcyBiZWVuIHRoYXQgdGhlIGRybV9mYl9o ZWxwZXJfZnVuY3MtPmZiX3Byb2JlIGNhbGxiYWNrCj4+IGNsZWFucyB1cCBpdHMgcmVzb3VyY2Vz IG9uIGVycm9yLiBDbGVhcmx5IHRoaXMgaXMgbm90IHRoZSBjYXNlIGZvciBib2Nocywgc28KPj4g bXkgdGFrZSBvbiB0aGlzIGlzIHRoYXQgYm9jaHNmYl9jcmVhdGUoKSBuZWVkcyB0byBjbGVhbiB1 cCBvbiBlcnJvci4KPiAKPiBUaGF0IGFzc3VtcHRpb24gc3RpbGwgaG9sZHMgZm9yIGJvY2hzLiBU aGUgcHJvYmxlbSBpcyB0aGlzIHNlcXVlbmNlOgo+IC0gZHJtX2ZiX2hlbHBlcl9mYmRldl9zZXR1 cCBpcyBjYWxsZWQuCj4gLSBmYl9wcm9iZSBzdWNjZWVkcyAodGhpcyBpcyBjcnVjaWFsKS4KPiAt IHJlZ2lzdGVyX2ZyYW1lYnVmZmVyIGZhaWxzLgo+IC0gZXJyb3IgcGF0aCBvZiBzZXR1cCBpcyB0 cmlnZ2VyZWQuCj4gCj4gQXMgZmJfaGVscGVyIGlzIGZ1bGx5IHNldHVwIGJ5IGRyaXZlcnMsIHRo ZSBkcm1fZmJfaGVscGVyIGNvcmUgc2hvdWxkCj4gZnVsbHkgZGVhbGxvY2F0ZSBpdCBhZ2FpbiBv biB0aGUgZXJyb3IgcGF0aCBvciBlbHNlIGEgbGVhayBvY2N1cnMuCj4gCj4+IEdlcmQgaGFzIGEg cGF0Y2hzZXQgdGhhdCBzd2l0Y2hlcyBib2NocyBvdmVyIHRvIHRoZSBnZW5lcmljIGZiZGV2Cj4+ IGVtdWxhdGlvbiwgYnV0IG9mYyB0aGF0IGRvZXNuJ3QgaGVscCB3aXRoIDQuMjA6Cj4+IGh0dHBz Oi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9zZXJpZXMvNTQyNjkvCj4gCj4gQW5kIHRoYXQg ZG9lcyBub3QgaGVscCB3aXRoIG90aGVyIHVzZXJzIG9mIHRoZSBkcm1fZmJfaGVscGVyIHdobyB1 c2UKPiBmdW5jdGlvbnMgbGlrZSBkcm1fZmJfaGVscGVyX2RlZmlvX2luaXQuIFRoZXkgd2lsbCBs aWtlbHkgcnVuIGluIHRoZQo+IHNhbWUgcHJvYmxlbS4KPiAKPiBJIGRvbid0IGhhdmUgYSB3YXkg dG8gdGVzdCB0aW55ZHJtIG9yIG90aGVyIGRyaXZlcnMsIGJ1dCBpZiB5b3UgZm9yY2UKPiByZWdp c3Rlcl9mcmFtZWJ1ZmZlciB0byBmYWlsLCB5b3Ugc2hvdWxkIGJlIGFibGUgdG8gcmVwcm9kdWNl IHRoZQo+IHByb2JsZW0gd2l0aCBkcm1fZmJfaGVscGVyX2dlbmVyaWNfcHJvYmUuCj4gCgpOb3cg SSB1bmRlcnN0YW5kLiBJIGhhdmUgbG9va2VkIGF0IHRoZSBkcml2ZXJzIHRoYXQgdXNlIGRybV9m Yl9oZWxwZXIKYW5kIG5vIG9uZSBzZWVtIHRvIGhhbmRsZSB0aGUgY2FzZSB3aGVyZSByZWdpc3Rl cl9mcmFtZWJ1ZmZlcigpIGlzCmZhaWxpbmcuCgpIZXJlJ3Mgd2hhdCBkcml2ZXJzIGRvIHdoZW4g ZHJtX2ZiX2hlbHBlcl9pbml0aWFsX2NvbmZpZygpIGZhaWxzOgoKRG9lc24ndCBjaGVjazoKYW1k Z3B1CnZpcnRpbwoKQ2FsbHMgZHJtX2ZiX2hlbHBlcl9maW5pKCk6CmFybWFkYQphc3QKZXh5bm9z CmdtYTUwMApoaXNpbGljb24KbWdhZzIwMAptc20Kbm91dmVhdQpvbWFwCnJhZGVvbgpyb2NrY2hp cAp0ZWdyYQp1ZGwKYm9jaHMgLSBVc2VzIGRybV9mYl9oZWxwZXJfZmJkZXZfc2V0dXAoKQpxeGwg LSBVc2VzIGRybV9mYl9oZWxwZXJfZmJkZXZfc2V0dXAoKQp2Ym94dmlkZW8gLSBVc2VzIGRybV9m Yl9oZWxwZXJfZmJkZXZfc2V0dXAoKQoKTWlnaHQgY2xlYW4gdXAsIG5vdCBzdXJlOgpjaXJydXMK Ckxvb2tzIHN1c3BpY2lvdXM6Cmk5MTUKCkkgbG9va2VkIGF0IGJvY2hzIGJlZm9yZSBpdCBzd2l0 Y2hlZCB0byBkcm1fZmJfaGVscGVyX2ZiZGV2X3NldHVwKCkgYW5kCml0IGFsc28ganVzdCBjYWxs ZWQgZHJtX2ZiX2hlbHBlcl9maW5pKCkuCgpJdCBsb29rcyBsaWtlIHlvdSd2ZSB1bmNvdmVyZWQg c29tZXRoaW5nIG5vIG9uZSBoYXMgdGhvdWdoIGFib3V0IChvcgpub3QgaW1wbGVtZW50ZWQgYXQg bGVhc3QpLgoKSXQncyBub3QganVzdCB0aGUgZnJhbWVidWZmZXIgdGhhdCdzIG5vdCBkZXN0cm95 ZWQsIHRoZSBidWZmZXIgb2JqZWN0CmlzIGFsc28gbGVha2VkLiBkcm1fbW9kZV9jb25maWdfY2xl YW51cCgpIHllbGxzIGFib3V0IHRoZSBmcmFtZWJ1ZmZlcgooYW5kIGZyZWVzIGl0KSwgYnV0IHNh eXMgbm90aGluZyBhYm91dCB0aGUgYnVmZmVyIG9iamVjdC4gSXQgbWlnaHQgYmUKdGhhdCBpdCBj YW4ndCBldmVuIGJlIG1hZGUgdG8gZGV0ZWN0IHRoYXQgc2luY2Ugc29tZSBkcml2ZXJzIGRvIHNw ZWNpYWwKc3R1ZmYgZm9yIHRoZSBmYmRldiBidWZmZXIuCgpJJ2xsIHBpY2sgdXAgb24gdGhpcyBh bmQgZG8gc29tZSB0ZXN0aW5nIGFmdGVyIHRoZSBDaHJpc3RtYXMgaG9saWRheXMuCgpOb3JhbGYu Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=