From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/ttm: stop always moving BOs on the LRU on page fault
Date: Fri, 11 Jan 2019 20:12:50 +0100 [thread overview]
Message-ID: <810303e7-d1bd-1e04-4e73-33d8202b2a05@gmail.com> (raw)
In-Reply-To: <ed9615c4-99be-c690-6ea0-bbe3e107bab3-otUistvHUpPR7s880joybQ@public.gmane.org>
Am 11.01.19 um 15:17 schrieb Michel Dänzer:
> On 2019-01-11 2:15 p.m., Christian König wrote:
>> Move the BO on the LRU only when it is actually moved by a DMA
>> operation.
>>
>> [...]
>>
>> @@ -177,6 +175,13 @@ static vm_fault_t ttm_bo_vm_fault(struct vm_fault *vmf)
>> ret = VM_FAULT_SIGBUS;
>> goto out_unlock;
>> }
>> +
>> + if (bo->moving != moving) {
> Hmm, could a driver just update the existing fence instead of attaching
> a new one?
Mhm, not as far as I know. That would violate similar checks elsewhere.
Christian.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2019-01-11 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 13:15 [PATCH] drm/ttm: stop always moving BOs on the LRU on page fault Christian König
2019-01-11 14:15 ` Michel Dänzer
[not found] ` <20190111131525.1269-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
2019-01-11 14:17 ` Michel Dänzer
[not found] ` <ed9615c4-99be-c690-6ea0-bbe3e107bab3-otUistvHUpPR7s880joybQ@public.gmane.org>
2019-01-11 19:12 ` Christian König [this message]
[not found] ` <810303e7-d1bd-1e04-4e73-33d8202b2a05-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-01-14 16:27 ` Michel Dänzer
2019-01-14 7:06 ` zhoucm1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=810303e7-d1bd-1e04-4e73-33d8202b2a05@gmail.com \
--to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=michel-otUistvHUpPR7s880joybQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox