From: "Christian König" <christian.koenig@amd.com>
To: Karolina Stolarek <karolina.stolarek@intel.com>,
dri-devel@lists.freedesktop.org
Cc: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>,
Andi Shyti <andi.shyti@linux.intel.com>,
Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [PATCH v7 4/8] drm/ttm/tests: Fix argument in ttm_tt_kunit_init()
Date: Tue, 21 Nov 2023 16:09:24 +0100 [thread overview]
Message-ID: <81280618-dd36-43cb-86bb-e124f505f8b8@amd.com> (raw)
In-Reply-To: <119b80776b83fa71b67ce746afcc3c2ee8342fe2.1700207346.git.karolina.stolarek@intel.com>
Am 17.11.23 um 09:49 schrieb Karolina Stolarek:
> Remove a leftover definition of page order and pass an empty flag value
> in ttm_pool_pre_populated().
>
> Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
> Tested-by: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/ttm/tests/ttm_pool_test.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_pool_test.c b/drivers/gpu/drm/ttm/tests/ttm_pool_test.c
> index 2d9cae8cd984..b97f7b6daf5b 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_pool_test.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_pool_test.c
> @@ -78,10 +78,9 @@ static struct ttm_pool *ttm_pool_pre_populated(struct kunit *test,
> struct ttm_test_devices *devs = priv->devs;
> struct ttm_pool *pool;
> struct ttm_tt *tt;
> - unsigned long order = __fls(size / PAGE_SIZE);
> int err;
>
> - tt = ttm_tt_kunit_init(test, order, caching, size);
> + tt = ttm_tt_kunit_init(test, 0, caching, size);
> KUNIT_ASSERT_NOT_NULL(test, tt);
>
> pool = kunit_kzalloc(test, sizeof(*pool), GFP_KERNEL);
next prev parent reply other threads:[~2023-11-21 15:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 8:49 [PATCH v7 0/8] Improve test coverage of TTM Karolina Stolarek
2023-11-17 8:49 ` [PATCH v7 1/8] drm/ttm/tests: Add tests for ttm_resource and ttm_sys_man Karolina Stolarek
2023-11-21 9:25 ` Christian König
2023-11-17 8:49 ` [PATCH v7 2/8] drm/ttm/tests: Add tests for ttm_tt Karolina Stolarek
2023-11-17 8:49 ` [PATCH v7 3/8] drm/ttm/tests: Add tests for ttm_bo functions Karolina Stolarek
2023-11-21 14:29 ` Christian König
2023-11-22 10:39 ` Karolina Stolarek
2023-11-28 15:25 ` Andi Shyti
2023-11-17 8:49 ` [PATCH v7 4/8] drm/ttm/tests: Fix argument in ttm_tt_kunit_init() Karolina Stolarek
2023-11-17 11:54 ` [v7,4/8] " Dominik Karol Piatkowski
2023-11-21 15:09 ` Christian König [this message]
2023-11-17 8:49 ` [PATCH v7 5/8] drm/ttm/tests: Use an init function from the helpers lib Karolina Stolarek
2023-11-17 8:49 ` [PATCH v7 6/8] drm/ttm/tests: Test simple BO creation and validation Karolina Stolarek
2023-11-17 18:54 ` kernel test robot
2023-11-21 15:55 ` Christian König
2023-11-17 8:49 ` [PATCH v7 7/8] drm/ttm/tests: Add tests with mock resource managers Karolina Stolarek
2023-11-22 13:48 ` Christian König
2023-11-17 8:49 ` [PATCH v7 8/8] drm/ttm/tests: Add test cases dependent on fence signaling Karolina Stolarek
2023-11-17 13:31 ` [PATCH v7 0/8] Improve test coverage of TTM Christian König
2023-11-18 13:32 ` Somalapuram, Amaranath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81280618-dd36-43cb-86bb-e124f505f8b8@amd.com \
--to=christian.koenig@amd.com \
--cc=Amaranath.Somalapuram@amd.com \
--cc=andi.shyti@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=karolina.stolarek@intel.com \
--cc=nirmoy.das@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox