dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Schwartz <matthew.schwartz@linux.dev>
To: Melissa Wen <mwen@igalia.com>,
	harry.wentland@amd.com, sunpeng.li@amd.com, siqueira@igalia.com,
	alexander.deucher@amd.com, christian.koenig@amd.com,
	airlied@gmail.com, simona@ffwll.ch
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	kernel-dev@igalia.com, Alex Hung <alex.hung@amd.com>
Subject: Re: [PATCH] drm/amd/display: expose plane blend LUT in HW with MCM
Date: Mon, 2 Feb 2026 18:05:49 -0800	[thread overview]
Message-ID: <8196dd34-048a-452f-b01b-978f7d78df84@linux.dev> (raw)
In-Reply-To: <003737a0-7777-45f3-af55-4cee7a73ab9d@igalia.com>

On 2/2/26 6:03 PM, Melissa Wen wrote:
> 
> On 09/12/2025 12:09, Melissa Wen wrote:
>> Since commit 39923050615cd ("drm/amd/display: Clear DPP 3DLUT Cap")
>> there is a flag in the mpc_color_caps that indicates the pre-blend usage
>> of MPC color caps. Do the same as commit a0c3e8bfbab6 ("drm/amd/display:
>> Use mpc.preblend flag to indicate preblend") and use the mpc.preblend
>> flag to expose plane blend LUT/TF properties on AMD display driver.
> 
> A gentle ping here.
> 
> Melissa
> 
>>
>> CC: Matthew Schwartz <matthew.schwartz@linux.dev>

I can confirm this adds back color management capabilities in gamescope on DCN35 and DCN351.

Tested-by: Matthew Schwartz <matthew.schwartz@linux.dev>

>> Signed-off-by: Melissa Wen <mwen@igalia.com>
>> ---
>>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
>> index 56cb866ac6f8..b15f0cf86008 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
>> @@ -1649,7 +1649,7 @@ dm_atomic_plane_attach_color_mgmt_properties(struct amdgpu_display_manager *dm,
>>                          MAX_COLOR_3DLUT_SIZE);
>>       }
>>   -    if (dpp_color_caps.ogam_ram) {
>> +    if (dpp_color_caps.ogam_ram || dm->dc->caps.color.mpc.preblend) {
>>           drm_object_attach_property(&plane->base,
>>                          mode_info.plane_blend_lut_property, 0);
>>           drm_object_attach_property(&plane->base,
> 


  reply	other threads:[~2026-02-03  2:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-09 15:09 [PATCH] drm/amd/display: expose plane blend LUT in HW with MCM Melissa Wen
2026-02-03  2:03 ` Melissa Wen
2026-02-03  2:05   ` Matthew Schwartz [this message]
2026-02-04 19:44 ` Alex Hung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8196dd34-048a-452f-b01b-978f7d78df84@linux.dev \
    --to=matthew.schwartz@linux.dev \
    --cc=airlied@gmail.com \
    --cc=alex.hung@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=kernel-dev@igalia.com \
    --cc=mwen@igalia.com \
    --cc=simona@ffwll.ch \
    --cc=siqueira@igalia.com \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox