dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-renesas-soc@vger.kernel.org,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4 11/16] ARM: dts: r8a7791: Convert to new LVDS DT bindings
Date: Tue, 27 Feb 2018 12:26:25 +0200	[thread overview]
Message-ID: <8228792.JG3Xuh41Ml@avalon> (raw)
In-Reply-To: <29b21328-c718-91a5-fc49-5034715f5539@cogentembedded.com>

Hi Sergei,

On Friday, 23 February 2018 11:51:59 EET Sergei Shtylyov wrote:
> On 2/21/2018 2:10 AM, Laurent Pinchart wrote:
> > The internal LVDS encoder now has DT bindings separate from the DU. Port
> > the device tree over to the new model.
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> 
> [...]
> 
> > diff --git a/arch/arm/boot/dts/r8a7791.dtsi
> > b/arch/arm/boot/dts/r8a7791.dtsi index 008a260f86a5..8660f8a329c7 100644
> > --- a/arch/arm/boot/dts/r8a7791.dtsi
> > +++ b/arch/arm/boot/dts/r8a7791.dtsi
> 
> [...]
> 
> > @@ -1126,6 +1123,33 @@
> >   			port@1 {
> >   				reg = <1>;
> >   				du_out_lvds0: endpoint {
> > +					remote-endpoint = <&lvds0_in>;
> > +				};
> > +			};
> > +		};
> > +	};
> > +
> > +	lvds0: lvds@feb90000 {
> 
> I suggest that we use the label "lvds" w/o #, compatible with the manual...

The manual uses "LVDS" in some places (figure 25.1b or table 25.1 for 
instance) and LVDS0 in other (table 25.3 for instance). I don't think this is 
a big deal, and if we need to refer to the LVDS node by phandle, I'd rather 
use lvds0 consistently on all SoCs to make writing shared DT sources easier.

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-02-27 10:25 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-20 23:10 [PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 01/16] dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings Laurent Pinchart
2018-02-21  8:35   ` Sergei Shtylyov
2018-02-21 19:50     ` Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 02/16] dt-bindings: display: renesas: Deprecate LVDS support in the DU bindings Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 03/16] of: dynamic: Add __of_node_dupv() Laurent Pinchart
2018-02-21 10:26   ` Geert Uytterhoeven
2018-02-21 12:15     ` Laurent Pinchart
2018-02-21 23:16   ` Rob Herring
2018-02-20 23:10 ` [PATCH v4 04/16] of: changesets: Introduce changeset helper methods Laurent Pinchart
2018-02-21 10:21   ` Geert Uytterhoeven
2018-02-21 12:19     ` Laurent Pinchart
2018-02-21 15:23     ` Rob Herring
2018-02-21 15:46       ` Geert Uytterhoeven
2018-02-21 23:14   ` Rob Herring
2018-02-20 23:10 ` [PATCH v4 05/16] of: changeset: Add of_changeset_node_move method Laurent Pinchart
2018-02-21 23:20   ` Rob Herring
2018-02-21 23:40     ` Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 06/16] of: unittest: changeset helpers Laurent Pinchart
2018-02-21 23:10   ` Rob Herring
2018-02-21 23:39     ` Laurent Pinchart
2018-02-21 23:49       ` Rob Herring
2018-02-20 23:10 ` [PATCH v4 07/16] i2c: demux: Use changeset helpers for clarity Laurent Pinchart
2018-02-21  8:06   ` Wolfram Sang
2018-02-20 23:10 ` [PATCH v4 08/16] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes Laurent Pinchart
2018-02-21 23:28   ` Rob Herring
2018-02-21 23:54     ` Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 09/16] drm: rcar-du: Convert LVDS encoder code to bridge driver Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 10/16] ARM: dts: r8a7790: Convert to new LVDS DT bindings Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 11/16] ARM: dts: r8a7791: " Laurent Pinchart
2018-02-23  9:32   ` Sergei Shtylyov
2018-02-23  9:37     ` Laurent Pinchart
2018-02-23  9:51   ` Sergei Shtylyov
2018-02-27 10:26     ` Laurent Pinchart [this message]
2018-02-20 23:10 ` [PATCH v4 12/16] ARM: dts: r8a7792: Convert to new DU " Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 13/16] ARM: dts: r8a7793: Convert to new LVDS " Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 14/16] ARM: dts: r8a7794: Convert to new DU " Laurent Pinchart
2018-02-21  8:26   ` Sergei Shtylyov
2018-02-20 23:10 ` [PATCH v4 15/16] arm64: dts: renesas: r8a7795: Convert to new LVDS " Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 16/16] arm64: dts: renesas: r8a7796: " Laurent Pinchart
2018-02-21 16:39 ` [PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver Simon Horman
2018-02-22  6:07 ` Frank Rowand
2018-02-22 10:25   ` Laurent Pinchart
2018-02-23  3:20     ` Frank Rowand
2018-02-23  9:25       ` Laurent Pinchart
2018-02-23 19:35         ` Frank Rowand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8228792.JG3Xuh41Ml@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox