dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
	Dominik 'Rathann' Mierzejewski <dominik@greysector.net>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/gma500: Add CedarView LVDS blacklist
Date: Wed, 10 Apr 2019 11:08:59 +0200	[thread overview]
Message-ID: <82afbb86-433a-a0ba-e06f-8badd5862943@redhat.com> (raw)
In-Reply-To: <CAMeQTsaa3KC=53N_fZRK0FGdCfGyBB78k50-KORZGcZ0f1PHxg@mail.gmail.com>

Hi,

On 10-04-19 11:00, Patrik Jakobsson wrote:
> On Wed, Apr 10, 2019 at 9:27 AM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Hi,
>>
>> On 09-04-19 21:31, Dominik 'Rathann' Mierzejewski wrote:
>>> Hello,
>>>
>>> On Tuesday, 09 April 2019 at 16:44, Hans de Goede wrote:
>>>> Hi,
>>>>
>>>> On 09-04-19 14:05, Patrik Jakobsson wrote:
>>>>> On Tue, Apr 9, 2019 at 12:20 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> On 09-04-19 11:47, Patrik Jakobsson wrote:
>>>>>>> On Tue, Apr 9, 2019 at 8:51 AM Hans de Goede <hdegoede@redhat.com> wrote:
>>>>>>>>
>>>>>>>> Some CedarView VBT-s claim that there is a LVDS panel, while there is none.
>>>>>>>> Specifically this happens on the Thecus N2800 / N5550 NAS models.
>>>>>>>>
>>>>>>>> This commit adds a LVDS blacklist to deal with this and adds an entry for
>>>>>>>> the Thecus NAS-es.
>>>>>>>
>>>>>>> Hi Hans,
>>>>>>> Sometimes LVDS can be configured in the BIOS on CDV devices. Can you
>>>>>>> check that it's not just a bad BIOS configuration first?
>>>>>>
>>>>>> I've asked the reporter to test, but even if there is a BIOS option it
>>>>>> seems that the BIOS default setting is wrong and we cannot expect every
>>>>>> user to go into the BIOS to fix a wrong BIOS setting.
>>>>>>
>>>>>> According to this blogpost, which is about the Linux the device ships with:
>>>>>> https://astroweasel.blogspot.com/2016/02/updating-thecus-n5550-nas-to-report.html
>>>>>>
>>>>>> The pre-installed grub config includes 'video=LVDS-1:d' on the kernel
>>>>>> commandline, so this clearly seems to be a case where the system is just
>>>>>> shipping with a broken BIOS or at least with default BIOS settings which
>>>>>> is just as bad.
>>>>>
>>>>> I agree that we should try to fix a broken default but are you sure
>>>>> this will only affect the n5550? IIUC Milstead / Granite Well is an
>>>>> Intel product / board name and perhaps some of those use LVDS.
>>>>
>>>> Milstead is the name of Intel's NAS reference design:
>>>>
>>>> https://www.hardwarezone.com.my/tech-news-intel-unveils-milstead-platform-nas-devices
>>>>
>>>> I seriously doubt that any NAS-es have a LVDS (laptop/tablet) LCD panel.
>>>>
>>>>> Also, if the pre-installed OS solves this on the cmdline then it's
>>>>> only a problem if the user is trying to install a custom OS on the
>>>>> device. I would expect such a user to be able to change bios settings.
>>>>>
>>>>> I'm not totally against this but not sure about the consequences. Is
>>>>> there perhaps a better dmi string to match against?
>>>>
>>>> No there are no better DMI strings to match against I'm afraid.
>>>
>>> I did load default settings in BIOS setup and there's no change in
>>> behaviour. LVDS gets detected as connected:
>>> $ cat /sys/class/drm/card0-LVDS-1/status
>>> connected
>>>
>>> Only VGA output is physically connected at the moment.
>>
>> To be clear what Dominik means here is that he has a VGA monitor
>> connected. There is no LVDS panel in this device at all.
> 
> Thanks for testing. I dusted off my DN2800MT and tried turning LVDS
> on/off in the BIOS. With LVDS disabled gma500 reports it as connected.
> When LVDS is enabled in bios I instead get a connected eDP connector.
> I'm starting to think that broken VBT parsing might be the actual
> problem.

Maybe, but I assume there are CedarView based laptops with LVDS panels
which works, so I suspect this might be more of a bug in your BIOS.

So what is the next step in debugging this?

Regards,

Hans

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-04-10  9:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09  6:51 [PATCH] drm/gma500: Add CedarView LVDS blacklist Hans de Goede
2019-04-09  9:47 ` Patrik Jakobsson
2019-04-09 10:20   ` Hans de Goede
2019-04-09 12:05     ` Patrik Jakobsson
2019-04-09 14:44       ` Hans de Goede
2019-04-09 19:31         ` Dominik 'Rathann' Mierzejewski
2019-04-10  7:27           ` Hans de Goede
2019-04-10  9:00             ` Patrik Jakobsson
2019-04-10  9:08               ` Hans de Goede [this message]
2019-04-10 11:18                 ` Dominik 'Rathann' Mierzejewski
2019-04-10 11:33                   ` Patrik Jakobsson
2019-04-10 11:51                     ` Dominik 'Rathann' Mierzejewski
2019-04-16 14:32                       ` Patrik Jakobsson
2019-04-16 15:36                         ` Hans de Goede
2019-04-10 11:37                 ` Patrik Jakobsson
2019-04-10 10:43               ` Ville Syrjälä
2019-04-10 11:34                 ` Patrik Jakobsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82afbb86-433a-a0ba-e06f-8badd5862943@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dominik@greysector.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=patrik.r.jakobsson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox