Re: [PATCH V6 5/5] arm64: dts: qcom: glymur-crd: add Audio sound card node

[Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>]

On 5/20/26 12:29 PM, Krzysztof Kozlowski wrote:
> On 25/03/2026 04:53, Sibi Sankar wrote:
>> From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
>>
>> Add the sound card of Glymur-crd board with the routing for speakers.
>>
>> Add device nodes for the sound support with WSA884x smart speakers
>> and playback via speakers and recording via DMIC microphones.
>>
>> Co-developed-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
>> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> ---
>>  arch/arm64/boot/dts/qcom/glymur-crd.dtsi | 110 +++++++++++++++++++++++
>>  1 file changed, 110 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
>> index 690b90e3d6ce..88a5c63e8ac2 100644
>> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
>> @@ -118,6 +118,54 @@ vreg_wwan: regulator-wwan {
>>  		pinctrl-0 = <&wwan_reg_en>;
>>  		pinctrl-names = "default";
>>  	};
>> +
>> +	sound {
>> +		compatible = "qcom,glymur-sndcard";
>> +		model = "glymur-crd";
> 
> That's not the name which was already used in Audioreach topology and
> maybe other places.
I agree this should be GLYMUR-CRD as per
https://github.com/linux-msm/audioreach-topology/blob/main/CMakeLists.txt#L24

--srini
> 
> While it is fine to use whatever case you wish, please also fix that
> users of this name.
> 
> Best regards,
> Krzysztof