From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Kocialkowski Subject: Re: [PATCH 4/4] drm/v3d: Fix and extend MMU error handling. Date: Fri, 19 Apr 2019 10:52:28 +0200 Message-ID: <8417895942db33dcf7c63b67a4db2786638df79b.camel@bootlin.com> References: <20190419001014.23579-1-eric@anholt.net> <20190419001014.23579-4-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A85C8922A for ; Fri, 19 Apr 2019 08:52:32 +0000 (UTC) In-Reply-To: <20190419001014.23579-4-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt , dri-devel@lists.freedesktop.org Cc: Maxime Ripard , david.emett@broadcom.com, thomas.spurden@broadcom.com, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGksCgpPbiBUaHUsIDIwMTktMDQtMTggYXQgMTc6MTAgLTA3MDAsIEVyaWMgQW5ob2x0IHdyb3Rl Ogo+IFdlIHdlcmUgc2V0dGluZyB0aGUgd3JvbmcgZmxhZ3MgdG8gZW5hYmxlIFBUSSBlcnJvcnMs IHNvIHdlIHdlcmUKPiBzZWVpbmcgcmVhZHMgdG8gaW52YWxpZCBQVEVzIHNob3cgdXAgYXMgd3Jp dGUgZXJyb3JzLiAgQWxzbywgd2UKPiB3ZXJlbid0IHR1cm5pbmcgb24gdGhlIGludGVycnVwdHMu ICBUaGUgQVhJIElEcyB3ZSB3ZXJlIGR1bXBpbmcKPiBpbmNsdWRlZCB0aGUgb3V0c3RhbmRpbmcg d3JpdGUgbnVtYmVyIGFuZCBzbyB0aGV5IGxvb2tlZCBiYXNpY2FsbHkKPiByYW5kb20uICBBbmQg dGhlIFZJT19BRERSIGRlY29kaW5nIHdhcyBiYXNlZCBvbiB0aGUgTU1VIFZBX1dJRFRIIGZvcgo+ IHRoZSBmaXJzdCBwbGF0Zm9ybSBJIHdvcmtlZCBvbiBhbmQgd2FzIHdyb25nIG9uIG90aGVycy4g IEluIHNob3J0LAo+IHRoaXMgd2FzIGEgdGhvcm91Z2ggbWVzcyBmcm9tIGVhcmx5IEhXIGVuYWJs aW5nLgo+IAo+IFRlc3RlZCBvbiBWM0QgNC4xIGFuZCA0LjIgd2l0aCBpbnRlbnRpb25hbCBMMlQs IENMRSwgUFRCLCBhbmQgVExCCj4gZmF1bHRzLgoKRGlkbid0IGNoZWNrIHRoZSBkb2NzIGJ1dCBs b29rcyBzYW5lIHRvbyEKClJldmlld2VkLWJ5OiBQYXVsIEtvY2lhbGtvd3NraSA8cGF1bC5rb2Np YWxrb3dza2lAYm9vdGxpbi5jb20+CgpDaGVlcnMsCgpQYXVsCgo+IFNpZ25lZC1vZmYtYnk6IEVy aWMgQW5ob2x0IDxlcmljQGFuaG9sdC5uZXQ+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS92M2Qv djNkX2Rydi5jICB8ICAxICsKPiAgZHJpdmVycy9ncHUvZHJtL3YzZC92M2RfZHJ2LmggIHwgIDIg KysKPiAgZHJpdmVycy9ncHUvZHJtL3YzZC92M2RfaXJxLmMgIHwgMzEgKysrKysrKysrKysrKysr KysrKysrKysrKysrLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vdjNkL3YzZF9tbXUuYyAgfCAgNyAr KysrKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS92M2QvdjNkX3JlZ3MuaCB8ICAzICsrLQo+ICA1IGZp bGVzIGNoYW5nZWQsIDM3IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS92M2QvdjNkX2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL3Yz ZC92M2RfZHJ2LmMKPiBpbmRleCA3YWIzNjE5MmU2YmMuLjljZTJlNGVmNmMyYSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vdjNkL3YzZF9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS92M2QvdjNkX2Rydi5jCj4gQEAgLTQ5NCw2ICs0OTQsNyBAQCBzdGF0aWMgaW50IHYzZF9wbGF0 Zm9ybV9kcm1fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCW1tdV9kZWJ1 ZyA9IFYzRF9SRUFEKFYzRF9NTVVfREVCVUdfSU5GTyk7Cj4gIAlkZXYtPmNvaGVyZW50X2RtYV9t YXNrID0KPiAgCQlETUFfQklUX01BU0soMzAgKyBWM0RfR0VUX0ZJRUxEKG1tdV9kZWJ1ZywgVjNE X01NVV9QQV9XSURUSCkpOwo+ICsJdjNkLT52YV93aWR0aCA9IDMwICsgVjNEX0dFVF9GSUVMRCht bXVfZGVidWcsIFYzRF9NTVVfVkFfV0lEVEgpOwo+ICAKPiAgCWlkZW50MSA9IFYzRF9SRUFEKFYz RF9IVUJfSURFTlQxKTsKPiAgCXYzZC0+dmVyID0gKFYzRF9HRVRfRklFTEQoaWRlbnQxLCBWM0Rf SFVCX0lERU5UMV9UVkVSKSAqIDEwICsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3Yz ZC92M2RfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vdjNkL3YzZF9kcnYuaAo+IGluZGV4IDZkMzFh NmE1YTA4ZS4uNjQ2ODI5MjMwMThkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92M2Qv djNkX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3YzZC92M2RfZHJ2LmgKPiBAQCAtNjMs NiArNjMsOCBAQCBzdHJ1Y3QgdjNkX2RldiB7Cj4gIAkgKi8KPiAgCXZvaWQgKm1tdV9zY3JhdGNo Owo+ICAJZG1hX2FkZHJfdCBtbXVfc2NyYXRjaF9wYWRkcjsKPiArCS8qIHZpcnR1YWwgYWRkcmVz cyBiaXRzIGZyb20gVjNEIHRvIHRoZSBNTVUuICovCj4gKwlpbnQgdmFfd2lkdGg7Cj4gIAo+ICAJ LyogTnVtYmVyIG9mIFYzRCBjb3Jlcy4gKi8KPiAgCXUzMiBjb3JlczsKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL3YzZC92M2RfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vdjNkL3YzZF9p cnEuYwo+IGluZGV4IGZhYzNjNTQyODYwYi4uMjY4ZDhhODg5YWM1IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS92M2QvdjNkX2lycS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3YzZC92 M2RfaXJxLmMKPiBAQCAtMTYyLDEwICsxNjIsMzMgQEAgdjNkX2h1Yl9pcnEoaW50IGlycSwgdm9p ZCAqYXJnKQo+ICAJCSAgICAgIFYzRF9IVUJfSU5UX01NVV9QVEkgfAo+ICAJCSAgICAgIFYzRF9I VUJfSU5UX01NVV9DQVApKSB7Cj4gIAkJdTMyIGF4aV9pZCA9IFYzRF9SRUFEKFYzRF9NTVVfVklP X0lEKTsKPiAtCQl1NjQgdmlvX2FkZHIgPSAodTY0KVYzRF9SRUFEKFYzRF9NTVVfVklPX0FERFIp IDw8IDg7Cj4gLQo+IC0JCWRldl9lcnIodjNkLT5kZXYsICJNTVUgZXJyb3IgZnJvbSBjbGllbnQg JWQgYXQgMHglMDhsbHglcyVzJXNcbiIsCj4gLQkJCWF4aV9pZCwgKGxvbmcgbG9uZyl2aW9fYWRk ciwKPiArCQl1NjQgdmlvX2FkZHIgPSAoKHU2NClWM0RfUkVBRChWM0RfTU1VX1ZJT19BRERSKSA8 PAo+ICsJCQkJKHYzZC0+dmFfd2lkdGggLSAzMikpOwo+ICsJCXN0YXRpYyBjb25zdCBjaGFyICpj b25zdCB2M2Q0MV9heGlfaWRzW10gPSB7Cj4gKwkJCSJMMlQiLAo+ICsJCQkiUFRCIiwKPiArCQkJ IlBTRSIsCj4gKwkJCSJUTEIiLAo+ICsJCQkiQ0xFIiwKPiArCQkJIlRGVSIsCj4gKwkJCSJNTVUi LAo+ICsJCQkiR01QIiwKPiArCQl9Owo+ICsJCWNvbnN0IGNoYXIgKmNsaWVudCA9ICI/IjsKPiAr Cj4gKwkJVjNEX1dSSVRFKFYzRF9NTVVfQ1RMLAo+ICsJCQkgIFYzRF9SRUFEKFYzRF9NTVVfQ1RM KSAmIChWM0RfTU1VX0NUTF9DQVBfRVhDRUVERUQgfAo+ICsJCQkJCQkgICBWM0RfTU1VX0NUTF9Q VF9JTlZBTElEIHwKPiArCQkJCQkJICAgVjNEX01NVV9DVExfV1JJVEVfVklPTEFUSU9OKSk7Cj4g Kwo+ICsJCWlmICh2M2QtPnZlciA+PSA0MSkgewo+ICsJCQlheGlfaWQgPSBheGlfaWQgPj4gNTsK PiArCQkJaWYgKGF4aV9pZCA8IEFSUkFZX1NJWkUodjNkNDFfYXhpX2lkcykpCj4gKwkJCQljbGll bnQgPSB2M2Q0MV9heGlfaWRzW2F4aV9pZF07Cj4gKwkJfQo+ICsKPiArCQlkZXZfZXJyKHYzZC0+ ZGV2LCAiTU1VIGVycm9yIGZyb20gY2xpZW50ICVzICglZCkgYXQgMHglbGx4JXMlcyVzXG4iLAo+ ICsJCQljbGllbnQsIGF4aV9pZCwgKGxvbmcgbG9uZyl2aW9fYWRkciwKPiAgCQkJKChpbnRzdHMg JiBWM0RfSFVCX0lOVF9NTVVfV1JWKSA/Cj4gIAkJCSAiLCB3cml0ZSB2aW9sYXRpb24iIDogIiIp LAo+ICAJCQkoKGludHN0cyAmIFYzRF9IVUJfSU5UX01NVV9QVEkpID8KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL3YzZC92M2RfbW11LmMgYi9kcml2ZXJzL2dwdS9kcm0vdjNkL3YzZF9t bXUuYwo+IGluZGV4IDdhMjFmMTc4N2FiMS4uMzk1ZTgxZDk3MTYzIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS92M2QvdjNkX21tdS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3YzZC92 M2RfbW11LmMKPiBAQCAtNjksMTAgKzY5LDEzIEBAIGludCB2M2RfbW11X3NldF9wYWdlX3RhYmxl KHN0cnVjdCB2M2RfZGV2ICp2M2QpCj4gIAlWM0RfV1JJVEUoVjNEX01NVV9QVF9QQV9CQVNFLCB2 M2QtPnB0X3BhZGRyID4+IFYzRF9NTVVfUEFHRV9TSElGVCk7Cj4gIAlWM0RfV1JJVEUoVjNEX01N VV9DVEwsCj4gIAkJICBWM0RfTU1VX0NUTF9FTkFCTEUgfAo+IC0JCSAgVjNEX01NVV9DVExfUFRf SU5WQUxJRCB8Cj4gKwkJICBWM0RfTU1VX0NUTF9QVF9JTlZBTElEX0VOQUJMRSB8Cj4gIAkJICBW M0RfTU1VX0NUTF9QVF9JTlZBTElEX0FCT1JUIHwKPiArCQkgIFYzRF9NTVVfQ1RMX1BUX0lOVkFM SURfSU5UIHwKPiAgCQkgIFYzRF9NTVVfQ1RMX1dSSVRFX1ZJT0xBVElPTl9BQk9SVCB8Cj4gLQkJ ICBWM0RfTU1VX0NUTF9DQVBfRVhDRUVERURfQUJPUlQpOwo+ICsJCSAgVjNEX01NVV9DVExfV1JJ VEVfVklPTEFUSU9OX0lOVCB8Cj4gKwkJICBWM0RfTU1VX0NUTF9DQVBfRVhDRUVERURfQUJPUlQg fAo+ICsJCSAgVjNEX01NVV9DVExfQ0FQX0VYQ0VFREVEX0lOVCk7Cj4gIAlWM0RfV1JJVEUoVjNE X01NVV9JTExFR0FMX0FERFIsCj4gIAkJICAodjNkLT5tbXVfc2NyYXRjaF9wYWRkciA+PiBWM0Rf TU1VX1BBR0VfU0hJRlQpIHwKPiAgCQkgIFYzRF9NTVVfSUxMRUdBTF9BRERSX0VOQUJMRSk7Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS92M2QvdjNkX3JlZ3MuaCBiL2RyaXZlcnMvZ3B1 L2RybS92M2QvdjNkX3JlZ3MuaAo+IGluZGV4IGVkYTFlMjg5OTc2Zi4uOWJjYjU3NzgxZDMxIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92M2QvdjNkX3JlZ3MuaAo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS92M2QvdjNkX3JlZ3MuaAo+IEBAIC0xNTIsNyArMTUyLDggQEAKPiAgIyBkZWZp bmUgVjNEX01NVV9DVExfUFRfSU5WQUxJRF9BQk9SVCAgICAgICAgICAgICAgICAgIEJJVCgxOSkK PiAgIyBkZWZpbmUgVjNEX01NVV9DVExfUFRfSU5WQUxJRF9JTlQgICAgICAgICAgICAgICAgICAg IEJJVCgxOCkKPiAgIyBkZWZpbmUgVjNEX01NVV9DVExfUFRfSU5WQUxJRF9FWENFUFRJT04gICAg ICAgICAgICAgIEJJVCgxNykKPiAtIyBkZWZpbmUgVjNEX01NVV9DVExfV1JJVEVfVklPTEFUSU9O ICAgICAgICAgICAgICAgICAgIEJJVCgxNikKPiArIyBkZWZpbmUgVjNEX01NVV9DVExfUFRfSU5W QUxJRF9FTkFCTEUgICAgICAgICAgICAgICAgIEJJVCgxNikKPiArIyBkZWZpbmUgVjNEX01NVV9D VExfV1JJVEVfVklPTEFUSU9OICAgICAgICAgICAgICAgICAgIEJJVCgxMikKPiAgIyBkZWZpbmUg VjNEX01NVV9DVExfV1JJVEVfVklPTEFUSU9OX0FCT1JUICAgICAgICAgICAgIEJJVCgxMSkKPiAg IyBkZWZpbmUgVjNEX01NVV9DVExfV1JJVEVfVklPTEFUSU9OX0lOVCAgICAgICAgICAgICAgIEJJ VCgxMCkKPiAgIyBkZWZpbmUgVjNEX01NVV9DVExfV1JJVEVfVklPTEFUSU9OX0VYQ0VQVElPTiAg ICAgICAgIEJJVCg5KQotLSAKUGF1bCBLb2NpYWxrb3dza2ksIEJvb3RsaW4KRW1iZWRkZWQgTGlu dXggYW5kIGtlcm5lbCBlbmdpbmVlcmluZwpodHRwczovL2Jvb3RsaW4uY29tCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=