From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laszlo Ersek Subject: Re: Regression: drm: Lobotomize set_busid nonsense for !pci drivers (a325725633c2) Date: Fri, 30 Sep 2016 17:33:17 +0200 Message-ID: <8469d2ee-958a-514f-b625-a586d111444d@redhat.com> References: <1466499262-18717-7-git-send-email-daniel.vetter@ffwll.ch> <1466510913-17958-1-git-send-email-daniel.vetter@ffwll.ch> <503b3377-5e61-75c7-1d33-a44c89028a79@redhat.com> <798c8b2d-1da9-51a3-8be7-b23d4cb26f3f@redhat.com> <9d5cd002-eb29-bc4d-89e8-a4a594dd84ad@redhat.com> <1bb8741c-3411-ce56-9e84-f85433af05f0@redhat.com> <26ac8ab0-fe8c-ea8a-08fb-905c873b5fef@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------B8CB89D074D50ACD8C8516FE" Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 250C86EA87 for ; Fri, 30 Sep 2016 15:33:21 +0000 (UTC) In-Reply-To: <26ac8ab0-fe8c-ea8a-08fb-905c873b5fef@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans de Goede , Daniel Vetter Cc: Emil Velikov , dri-devel@lists.freedesktop.org, "Thorsten Leemhuis (regressions address)" , Gerd Hoffmann , Daniel Vetter , David Airlie , Joachim Frieben , Gustavo Padovan List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --------------B8CB89D074D50ACD8C8516FE Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 09/30/16 16:59, Hans de Goede wrote: > Hi, > > On 30-09-16 16:51, Laszlo Ersek wrote: >> On 09/30/16 12:35, Hans de Goede wrote: >> >>> Attached are 2 patches against the xserver which should fix this, >>> please give them a try. >> >> Sorry about the delay. >> >> The patches don't seem to fix the issue for me. Please see the Xorg log >> attached. >> >> I tested the patches as follows. Given that my bisection had been done >> in a Fedora 24 guest, using >> >> xorg-x11-server-1.18.4-4.fc24 >> http://koji.fedoraproject.org/koji/buildinfo?buildID=794494 >> >> I now rebuilt the guest kernel exactly at the failing commit (a325725 >> "drm: Lobotomize set_busid nonsense for !pci drivers"), and first >> reproduced the issue with the above X server. >> >> Then, I ported your patches to "xorg-server-1.18.4" (using the upstream >> xserver tree), and rebuilt the Fedora package with the backport. For the >> backport, I had to cherry-pick the following two patches from master >> first: >> >> 1 ca8d88e50310 xfree86: recognize primary BUS_PCI device in >> xf86IsPrimaryPlatform() >> 2 ea91db4b8331 config: fix GPUDevice fail when AutoAddGPU off + BusID >> >> This way your patches applied cleanly. (Cherry pick #1 above is actually >> necessary for semantics, while cherry pick #2 is needed for a clean >> context only, and has no impact for this test.) >> >> That is, in total, I added the following four patches to the Fedora 24 >> package: >> >> 1 xfree86: recognize primary BUS_PCI device in xf86IsPrimaryPlatform() >> 2 config: fix GPUDevice fail when AutoAddGPU off + BusID >> 3 xfree86: Make adding unclaimed devices as GPU devices a separate step >> 4 xfree86: Try harder to find atleast 1 non GPU Screen >> >> You can find the scratch build that I used for testing here: >> >> xorg-x11-server-1.18.4-4.hans_bz1366842_2.fc24 >> http://koji.fedoraproject.org/koji/taskinfo?taskID=15875087 >> >> Another reason I used F24's X server as basis, rather than upstream >> HEAD, is that Fedora 24 is pretty young, and it's already on kernel >> 4.7.4, and I believe it will soon move to kernel 4.8, without >> (necessarily) rebasing its X server package to upstream. IOW the kernel >> upgrade to 4.8 will break X in Fedora 24 too, and then I expect the >> Fedora X maintainers would have to cherry pick those two patches as >> dependencies just the same. >> >> To summarize, the patches don't seem to help. I shall nonetheless thank >> you for spending your Friday on this! > > Hmm, do you have a xorg.conf file lying around somewhere, the message > about the xserver not being able to find an entry for screen 0 does > not make sense ... Good catch, I actually had two files under "/etc/X11/xorg.conf.d/": * "00-keyboard.conf", from package "systemd-229-13.fc24.x86_64", with contents ------------ # Read and parsed by systemd-localed. It's probably wise not to edit this file # manually too freely. Section "InputClass" Identifier "system-keyboard" MatchIsKeyboard "on" Option "XkbLayout" "us" EndSection ------------ * "01-resolution.conf", which I had created, in order to set the preferred display resolution: ------------ Section "Screen" Identifier "Default Screen" Device "Default Device" Monitor "Default Monitor" EndSection Section "Device" Identifier "Default Device" Driver "modesetting" EndSection Section "Monitor" Identifier "Default Monitor" Option "PreferredMode" "640x480" # Option "PreferredMode" "1440x900" EndSection ------------ I removed these files now, and repeated the test. Again, the X server wouldn't start, but I think the log file looks a bit different now. Attached. > Anyways, Monday is another day we can look at this ... Sure; many thanks! Laszlo --------------B8CB89D074D50ACD8C8516FE Content-Type: text/x-log; name="Xorg.0.log" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="Xorg.0.log" [ 9.853] X.Org X Server 1.18.4 Release Date: 2016-07-19 [ 9.853] X Protocol Version 11, Revision 0 [ 9.853] Build Operating System: 4.7.2-201.fc24.x86_64 [ 9.853] Current Operating System: Linux ovmf-fedora 4.7.0-rc2+ #7 SMP Fri Sep 30 12:05:35 CEST 2016 x86_64 [ 9.853] Kernel command line: BOOT_IMAGE=/vmlinuz-4.7.0-rc2+ root=/dev/mapper/fedora-root ro rd.lvm.lv=fedora/swap vconsole.font=latarcyrheb-sun16 rd.lvm.lv=fedora/root rhgb quiet video=640x480 no_console_suspend console=tty console=ttyS0,115200 ignore_loglevel LANG=en_US.UTF-8 [ 9.853] Build Date: 30 September 2016 02:16:20PM [ 9.853] Build ID: xorg-x11-server 1.18.4-4.hans_bz1366842_2.fc24 [ 9.853] Current version of pixman: 0.34.0 [ 9.853] Before reporting problems, check http://wiki.x.org to make sure that you have the latest version. [ 9.853] Markers: (--) probed, (**) from config file, (==) default setting, (++) from command line, (!!) notice, (II) informational, (WW) warning, (EE) error, (NI) not implemented, (??) unknown. [ 9.853] (==) Log file: "/var/log/Xorg.0.log", Time: Fri Sep 30 17:25:34 2016 [ 9.853] (==) Using system config directory "/usr/share/X11/xorg.conf.d" [ 9.854] (==) No Layout section. Using the first Screen section. [ 9.854] (==) No screen section available. Using defaults. [ 9.854] (**) |-->Screen "Default Screen Section" (0) [ 9.854] (**) | |-->Monitor "" [ 9.854] (==) No monitor specified for screen "Default Screen Section". Using a default monitor configuration. [ 9.854] (==) Automatically adding devices [ 9.854] (==) Automatically enabling devices [ 9.854] (==) Automatically adding GPU devices [ 9.854] (==) Max clients allowed: 256, resource mask: 0x1fffff [ 9.854] (==) FontPath set to: catalogue:/etc/X11/fontpath.d, built-ins [ 9.854] (==) ModulePath set to "/usr/lib64/xorg/modules" [ 9.854] (II) The server relies on udev to provide the list of input devices. If no devices become available, reconfigure udev or disable AutoAddDevices. [ 9.854] (II) Loader magic: 0x825dc0 [ 9.854] (II) Module ABI versions: [ 9.854] X.Org ANSI C Emulation: 0.4 [ 9.854] X.Org Video Driver: 20.0 [ 9.854] X.Org XInput driver : 22.1 [ 9.854] X.Org Server Extension : 9.0 [ 9.855] (++) using VT number 1 [ 9.855] (II) systemd-logind: logind integration requires -keeptty and -keeptty was not provided, disabling logind integration [ 9.856] (II) xfree86: Adding drm device (/dev/dri/card0) [ 9.860] (--) PCI:*(0:0:2:0) 1af4:1050:1af4:1100 rev 1, Mem @ 0xc0000000/8388608, 0x800000000/16384, 0xc0804000/4096, BIOS @ 0x????????/131072 [ 9.860] (II) LoadModule: "glx" [ 9.860] (II) Loading /usr/lib64/xorg/modules/extensions/libglx.so [ 9.862] (II) Module glx: vendor="X.Org Foundation" [ 9.862] compiled for 1.18.4, module version = 1.0.0 [ 9.862] ABI class: X.Org Server Extension, version 9.0 [ 9.862] (==) AIGLX enabled [ 9.862] (==) Matched modesetting as autoconfigured driver 0 [ 9.862] (==) Matched fbdev as autoconfigured driver 1 [ 9.862] (==) Matched vesa as autoconfigured driver 2 [ 9.862] (==) Assigned the driver to the xf86ConfigLayout [ 9.862] (II) LoadModule: "modesetting" [ 9.862] (II) Loading /usr/lib64/xorg/modules/drivers/modesetting_drv.so [ 9.862] (II) Module modesetting: vendor="X.Org Foundation" [ 9.863] compiled for 1.18.4, module version = 1.18.4 [ 9.863] Module class: X.Org Video Driver [ 9.863] ABI class: X.Org Video Driver, version 20.0 [ 9.863] (II) LoadModule: "fbdev" [ 9.863] (II) Loading /usr/lib64/xorg/modules/drivers/fbdev_drv.so [ 9.863] (II) Module fbdev: vendor="X.Org Foundation" [ 9.863] compiled for 1.18.0, module version = 0.4.3 [ 9.863] Module class: X.Org Video Driver [ 9.863] ABI class: X.Org Video Driver, version 20.0 [ 9.863] (II) LoadModule: "vesa" [ 9.863] (II) Loading /usr/lib64/xorg/modules/drivers/vesa_drv.so [ 9.863] (II) Module vesa: vendor="X.Org Foundation" [ 9.863] compiled for 1.18.0, module version = 2.3.2 [ 9.863] Module class: X.Org Video Driver [ 9.863] ABI class: X.Org Video Driver, version 20.0 [ 9.863] (II) modesetting: Driver for Modesetting Kernel Drivers: kms [ 9.863] (II) FBDEV: driver for framebuffer: fbdev [ 9.863] (II) VESA: driver for VESA chipsets: vesa [ 9.863] (WW) Falling back to old probe method for modesetting [ 9.863] (II) modeset(1): using default device [ 9.863] (II) Loading sub module "fbdevhw" [ 9.863] (II) LoadModule: "fbdevhw" [ 9.863] (II) Loading /usr/lib64/xorg/modules/libfbdevhw.so [ 9.864] (II) Module fbdevhw: vendor="X.Org Foundation" [ 9.864] compiled for 1.18.4, module version = 0.0.2 [ 9.864] ABI class: X.Org Video Driver, version 20.0 [ 9.864] (**) FBDEV(2): claimed PCI slot 0@0:2:0 [ 9.864] (II) FBDEV(2): using default device [ 9.864] (WW) Falling back to old probe method for vesa [ 9.864] (II) modeset(G0): using drv /dev/dri/card0 [ 9.864] (EE) Screen 0 deleted because of no matching config section. [ 9.864] (II) UnloadModule: "modesetting" [ 9.864] (EE) Fatal server error: [ 9.864] (EE) Cannot run in framebuffer mode. Please specify busIDs for all framebuffer devices [ 9.864] (EE) [ 9.864] (EE) Please consult the Fedora Project support at http://wiki.x.org for help. [ 9.864] (EE) Please also check the log file at "/var/log/Xorg.0.log" for additional information. [ 9.864] (EE) [ 9.865] (EE) Server terminated with error (1). Closing log file. --------------B8CB89D074D50ACD8C8516FE Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --------------B8CB89D074D50ACD8C8516FE--