From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm: Set connector DPMS status to ON in drm_crtc_helper_set_config Date: Fri, 26 Nov 2010 09:28:56 +0000 Message-ID: <849307$ah36tv@azsmga001.ch.intel.com> References: <1289877046-17780-1-git-send-email-keithp@keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 44A449E807 for ; Fri, 26 Nov 2010 01:29:00 -0800 (PST) In-Reply-To: <1289877046-17780-1-git-send-email-keithp@keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: lkml@vger.kernel.org, dri-devel@lists.freedesktop.org, Dan Carpenter List-Id: dri-devel@lists.freedesktop.org Daniel, this is patch you were looking for earlier wrt to screen blanking. On Tue, 16 Nov 2010 11:10:46 +0800, keithp@keithp.com wrote: > From: Keith Packard > > When setting a new crtc configuration, force the DPMS state of all > connectors to ON. Otherwise, they'll be left at OFF and a future mode set > that disables the specified connector will not turn the connector off. > > Signed-off-by: Keith Packard Reviewed-by: Chris Wilson > --- > drivers/gpu/drm/drm_crtc_helper.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c > index dcbeb98..7804c3d 100644 > --- a/drivers/gpu/drm/drm_crtc_helper.c > +++ b/drivers/gpu/drm/drm_crtc_helper.c > @@ -471,6 +471,7 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set) > int count = 0, ro, fail = 0; > struct drm_crtc_helper_funcs *crtc_funcs; > int ret = 0; > + int i; > > DRM_DEBUG_KMS("\n"); > > @@ -666,6 +667,12 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set) > if (ret != 0) > goto fail; > } > + DRM_DEBUG_KMS("Setting connector DPMS state to on\n"); > + for (i = 0; i < set->num_connectors; i++) { > + DRM_DEBUG_KMS("\t[CONNECTOR:%d:%s] set DPMS on\n", set->connectors[i]->base.id, > + drm_get_connector_name(set->connectors[i])); > + set->connectors[i]->dpms = DRM_MODE_DPMS_ON; > + } > > kfree(save_connectors); > kfree(save_encoders); > -- > 1.7.2.3 > -- Chris Wilson, Intel Open Source Technology Centre