From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH v2 11/11] drm/amdgpu: set TMZ bits in PTEs for secure BO (v4) Date: Thu, 26 Sep 2019 09:21:24 +0200 Message-ID: <84c393e6-3268-d056-2808-4cded12f2a35@gmail.com> References: <1569419090-5304-1-git-send-email-ray.huang@amd.com> <1569419090-5304-12-git-send-email-ray.huang@amd.com> <507b6359-897a-20a1-2fff-28634858f464@amd.com> Reply-To: christian.koenig@amd.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher , "Koenig, Christian" Cc: "Huang, Ray" , "Liu, Aaron" , "amd-gfx@lists.freedesktop.org" , "Tuikov, Luben" , "dri-devel@lists.freedesktop.org" , "Deucher, Alexander" List-Id: dri-devel@lists.freedesktop.org QW0gMjUuMDkuMTkgdW0gMTg6MDEgc2NocmllYiBBbGV4IERldWNoZXI6Cj4gT24gV2VkLCBTZXAg MjUsIDIwMTkgYXQgOTo1OSBBTSBLb2VuaWcsIENocmlzdGlhbgo+IDxDaHJpc3RpYW4uS29lbmln QGFtZC5jb20+IHdyb3RlOgo+PiBBbSAyNS4wOS4xOSB1bSAxNTo0NSBzY2hyaWViIEh1YW5nLCBS YXk6Cj4+PiBGcm9tOiBBbGV4IERldWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cj4+ Pgo+Pj4gSWYgYSBidWZmZXIgb2JqZWN0IGlzIHNlY3VyZSwgaS5lLiBjcmVhdGVkIHdpdGgKPj4+ IEFNREdQVV9HRU1fQ1JFQVRFX0VOQ1JZUFRFRCwgdGhlbiB0aGUgVE1aIGJpdCBvZgo+Pj4gdGhl IFBURXMgdGhhdCBiZWxvbmcgdGhlIGJ1ZmZlciBvYmplY3Qgc2hvdWxkIGJlCj4+PiBzZXQuCj4+ Pgo+Pj4gdjE6IGRlc2lnbiBhbmQgZHJhZnQgdGhlIHNrZWxldGlvbiBvZiBUTVogYml0cyBzZXR0 aW5nIG9uIFBURXMgKEFsZXgpCj4+PiB2MjogcmV0dXJuIGZhaWx1cmUgb25jZSBjcmVhdGUgc2Vj dXJlIEJPIG9uIG5vbi1UTVogcGxhdGZvcm0gIChSYXkpCj4+PiB2MzogYW1kZ3B1X2JvX2VuY3J5 cHRlZCgpIG9ubHkgY2hlY2tzIHRoZSBCTyAoTHViZW4pCj4+PiB2NDogbW92ZSBUTVogZmxhZyBz ZXR0aW5nIGludG8gYW1kZ3B1X3ZtX2JvX3VwZGF0ZSAgKENocmlzdGlhbikKPj4+Cj4+PiBTaWdu ZWQtb2ZmLWJ5OiBBbGV4IERldWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cj4+PiBS ZXZpZXdlZC1ieTogSHVhbmcgUnVpIDxyYXkuaHVhbmdAYW1kLmNvbT4KPj4+IFNpZ25lZC1vZmYt Ynk6IEh1YW5nIFJ1aSA8cmF5Lmh1YW5nQGFtZC5jb20+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBMdWJl biBUdWlrb3YgPGx1YmVuLnR1aWtvdkBhbWQuY29tPgo+Pj4gUmV2aWV3ZWQtYnk6IEFsZXggRGV1 Y2hlciA8YWxleGFuZGVyLmRldWNoZXJAYW1kLmNvbT4KPj4+IC0tLQo+Pj4gICAgZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dlbS5jICAgIHwgMTIgKysrKysrKysrKystCj4+PiAg ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfb2JqZWN0LmggfCAxMSArKysrKysr KysrKwo+Pj4gICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMgICAgIHwg IDUgKysrKysKPj4+ICAgIDMgZmlsZXMgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgMSBkZWxl dGlvbigtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ2VtLmMKPj4+ IGluZGV4IDIyZWFiNzQuLjUzMzIxMDQgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfZ2VtLmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9nZW0uYwo+Pj4gQEAgLTIyMiw3ICsyMjIsOCBAQCBpbnQgYW1kZ3B1X2dlbV9j cmVhdGVfaW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPj4+ICAgICAg ICAgICAgICAgICAgICAgIEFNREdQVV9HRU1fQ1JFQVRFX0NQVV9HVFRfVVNXQyB8Cj4+PiAgICAg ICAgICAgICAgICAgICAgICBBTURHUFVfR0VNX0NSRUFURV9WUkFNX0NMRUFSRUQgfAo+Pj4gICAg ICAgICAgICAgICAgICAgICAgQU1ER1BVX0dFTV9DUkVBVEVfVk1fQUxXQVlTX1ZBTElEIHwKPj4+ IC0gICAgICAgICAgICAgICAgICAgQU1ER1BVX0dFTV9DUkVBVEVfRVhQTElDSVRfU1lOQykpCj4+ PiArICAgICAgICAgICAgICAgICAgIEFNREdQVV9HRU1fQ1JFQVRFX0VYUExJQ0lUX1NZTkMgfAo+ Pj4gKyAgICAgICAgICAgICAgICAgICBBTURHUFVfR0VNX0NSRUFURV9FTkNSWVBURUQpKQo+Pj4K Pj4+ICAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+Pj4KPj4+IEBAIC0yMzAsNiArMjMx LDExIEBAIGludCBhbWRncHVfZ2VtX2NyZWF0ZV9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 LCB2b2lkICpkYXRhLAo+Pj4gICAgICAgIGlmIChhcmdzLT5pbi5kb21haW5zICYgfkFNREdQVV9H RU1fRE9NQUlOX01BU0spCj4+PiAgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPj4+Cj4+ PiArICAgICBpZiAoIWFkZXYtPnRtei5lbmFibGVkICYmIChmbGFncyAmIEFNREdQVV9HRU1fQ1JF QVRFX0VOQ1JZUFRFRCkpIHsKPj4+ICsgICAgICAgICAgICAgRFJNX0VSUk9SKCJDYW5ub3QgYWxs b2NhdGUgc2VjdXJlIGJ1ZmZlciB3aGlsZSB0bXogaXMgZGlzYWJsZWRcbiIpOwo+Pj4gKyAgICAg ICAgICAgICByZXR1cm4gLUVJTlZBTDsKPj4+ICsgICAgIH0KPj4+ICsKPj4+ICAgICAgICAvKiBj cmVhdGUgYSBnZW0gb2JqZWN0IHRvIGNvbnRhaW4gdGhpcyBvYmplY3QgaW4gKi8KPj4+ICAgICAg ICBpZiAoYXJncy0+aW4uZG9tYWlucyAmIChBTURHUFVfR0VNX0RPTUFJTl9HRFMgfAo+Pj4gICAg ICAgICAgICBBTURHUFVfR0VNX0RPTUFJTl9HV1MgfCBBTURHUFVfR0VNX0RPTUFJTl9PQSkpIHsK Pj4+IEBAIC0yNTEsNiArMjU3LDEwIEBAIGludCBhbWRncHVfZ2VtX2NyZWF0ZV9pb2N0bChzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+Pj4gICAgICAgICAgICAgICAgcmVzdiA9 IHZtLT5yb290LmJhc2UuYm8tPnRiby5yZXN2Owo+Pj4gICAgICAgIH0KPj4+Cj4+PiArICAgICBp ZiAoZmxhZ3MgJiBBTURHUFVfR0VNX0NSRUFURV9FTkNSWVBURUQpIHsKPj4+ICsgICAgICAgICAg ICAgLyogWFhYOiBwYWQgb3V0IGFsaWdubWVudCB0byBtZWV0IFRNWiByZXF1aXJlbWVudHMgKi8K Pj4+ICsgICAgIH0KPj4+ICsKPj4+ICAgICAgICByID0gYW1kZ3B1X2dlbV9vYmplY3RfY3JlYXRl KGFkZXYsIHNpemUsIGFyZ3MtPmluLmFsaWdubWVudCwKPj4+ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICh1MzIpKDB4ZmZmZmZmZmYgJiBhcmdzLT5pbi5kb21haW5zKSwKPj4+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZsYWdzLCB0dG1fYm9fdHlwZV9k ZXZpY2UsIHJlc3YsICZnb2JqKTsKPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfb2JqZWN0LmggYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn cHVfb2JqZWN0LmgKPj4+IGluZGV4IDVhM2MxNzcuLjc1YzczOTIgMTAwNjQ0Cj4+PiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfb2JqZWN0LmgKPj4+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9vYmplY3QuaAo+Pj4gQEAgLTIyNCw2ICsyMjQs MTcgQEAgc3RhdGljIGlubGluZSBib29sIGFtZGdwdV9ib19leHBsaWNpdF9zeW5jKHN0cnVjdCBh bWRncHVfYm8gKmJvKQo+Pj4gICAgICAgIHJldHVybiBiby0+ZmxhZ3MgJiBBTURHUFVfR0VNX0NS RUFURV9FWFBMSUNJVF9TWU5DOwo+Pj4gICAgfQo+Pj4KPj4+ICsvKioKPj4+ICsgKiBhbWRncHVf Ym9fZW5jcnlwdGVkIC0gdGVzdCBpZiB0aGUgQk8gaXMgZW5jcnlwdGVkCj4+PiArICogQGJvOiBw b2ludGVyIHRvIGEgYnVmZmVyIG9iamVjdAo+Pj4gKyAqCj4+PiArICogUmV0dXJuIHRydWUgaWYg dGhlIGJ1ZmZlciBvYmplY3QgaXMgZW5jcnlwdGVkLCBmYWxzZSBvdGhlcndpc2UuCj4+PiArICov Cj4+PiArc3RhdGljIGlubGluZSBib29sIGFtZGdwdV9ib19lbmNyeXB0ZWQoc3RydWN0IGFtZGdw dV9ibyAqYm8pCj4+PiArewo+Pj4gKyAgICAgcmV0dXJuIGJvLT5mbGFncyAmIEFNREdQVV9HRU1f Q1JFQVRFX0VOQ1JZUFRFRDsKPj4+ICt9Cj4+PiArCj4+PiAgICBib29sIGFtZGdwdV9ib19pc19h bWRncHVfYm8oc3RydWN0IHR0bV9idWZmZXJfb2JqZWN0ICpibyk7Cj4+PiAgICB2b2lkIGFtZGdw dV9ib19wbGFjZW1lbnRfZnJvbV9kb21haW4oc3RydWN0IGFtZGdwdV9ibyAqYWJvLCB1MzIgZG9t YWluKTsKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X3ZtLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYwo+Pj4gaW5k ZXggYjI4NWFiMi4uOGUxM2IxZmQzIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvYW1kZ3B1X3ZtLmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2FtZGdwdV92bS5jCj4+PiBAQCAtMTY4OCw2ICsxNjg4LDExIEBAIGludCBhbWRncHVfdm1fYm9f dXBkYXRlKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+Pj4KPj4+ICAgICAgICBpZiAoYm8p IHsKPj4+ICAgICAgICAgICAgICAgIGZsYWdzID0gYW1kZ3B1X3R0bV90dF9wdGVfZmxhZ3MoYWRl diwgYm8tPnRiby50dG0sIG1lbSk7Cj4+PiArCj4+PiArICAgICAgICAgICAgIGlmIChhbWRncHVf Ym9fZW5jcnlwdGVkKGJvKSkgewo+Pj4gKyAgICAgICAgICAgICAgICAgICAgIGZsYWdzIHw9IEFN REdQVV9QVEVfVE1aOwo+Pj4gKyAgICAgICAgICAgICB9Cj4+PiArCj4+IFlvdSBjYW4gZHJvcCB0 aGUge30gaGVyZSwgYXBhcnQgZnJvbSB0aGF0IHRoZSBwYXRjaCBpcyBSZXZpZXdlZC1ieToKPj4g Q2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPi4KPj4KPj4gICBGcm9t IHRoZSBkZXNpZ24gaXQgd291bGQgYmUgaW5kZWVkIG5pY2VyIHRvIGhhdmUgdGhhdCBpbgo+PiBh bWRncHVfdHRtX3R0X3B0ZV9mbGFncygpLCBidXQgd2Ugd291bGQgbmVlZCB0byBtYWtlIHN1cmUg dGhhdCB0aGlzIGlzCj4+IG5vdCBjYWxsZWQgYW55IG1vcmUgZnJvbSBiaW5kaW5nIGEgdHQuCj4g RG9uJ3Qgd2UgbmVlZCB0aGF0IGZvciB0aGluZ3MgbGlrZSBldmljdGlvbnMgb2YgdG16IGJ1ZmZl cnM/ICBUaGF0Cj4gbmVlZHMgc3BlY2lhbCBoYW5kbGluZyBpbiBnZW5lcmFsLCB3aGljaCBJIGd1 ZXNzIHdlIGNhbiBhZGRyZXNzIGF0Cj4gdGhhdCB0aW1lLgoKWWVhaCwgZXhhY3RseS4gVGhlIHBy b2JsZW0gaXMgdGhhdCB3ZSBzb21ldGltZXMgZG9lc24ndCB1c2UgYm8tPm1lbSwgYnV0IApyYXRo ZXIgYSBzZXBhcmF0ZSBtZW1vcnkgZGVzY3JpcHRvciB0byBnZXQgdGhlIFBURSBpbmZvcy4KCkkg dGhpbmsgd2UgY291bGQgcmVtb3ZlIHRoZSBjYWxsIGluIGFtZGdwdV90dG1fYmFja2VuZF9iaW5k KCkgd2hlcmUgdGhpcyAKaXMgcmVsZXZhbnQsIGJlY2F1c2Ugd2Ugbm93IG1hbmFnZSBHQVJUIHNl cGFyYXRlbHkuCgpCdXQgdGhhdCdzIGEgbGFyZ2VyIGNoYW5nZSBhbmQgcHJvYmFibHkgbm90IHNv bWV0aGluZyBmb3IgdGhpcyBwYXRjaCBzZXQuCgpHb2luZyB0byBwdXQgaXQgb24gbXkgVE9ETyBs aXN0LgoKQ2hyaXN0aWFuLgoKPgo+IEFsZXgKPgo+PiBSZWdhcmRzLAo+PiBDaHJpc3RpYW4uCj4+ Cj4+PiAgICAgICAgICAgICAgICBib19hZGV2ID0gYW1kZ3B1X3R0bV9hZGV2KGJvLT50Ym8uYmRl dik7Cj4+PiAgICAgICAgfSBlbHNlIHsKPj4+ICAgICAgICAgICAgICAgIGZsYWdzID0gMHgwOwo+ PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBhbWQt Z2Z4IG1haWxpbmcgbGlzdAo+PiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGFtZC1nZnggbWFp bGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==