From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chubb Subject: Re: Can no longer shutdown after drm/radeon: Implement radeon_pci_shutdown Date: Thu, 12 Dec 2013 11:04:00 +1100 Message-ID: <84mwk7djf3.wl%peter.chubb@nicta.com.au> References: <84mwk86x5a.wl%peter.chubb@nicta.com.au> <20131211072658.GA273@x4> <84txefdomu.wl%peter.chubb@nicta.com.au> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from lemon.ertos.nicta.com.au (lemon.ertos.nicta.com.au [203.143.174.143]) by gabe.freedesktop.org (Postfix) with ESMTP id 3DD03FA6C5 for ; Wed, 11 Dec 2013 16:04:20 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: "Deucher, Alexander" Cc: Peter Chubb , "dri-devel@lists.freedesktop.org" , Markus Trippelsdorf List-Id: dri-devel@lists.freedesktop.org >>>>> "Deucher," == Deucher, Alexander writes: >> >> >>>>> "Markus" == Markus Trippelsdorf >> writes: >> Markus> On 2013.12.11 at 11:37 +1100, Peter Chubb wrote: >> Markus> It would be interesting to know where exactly it hangs. Could Markus> you comment out the *_fini(rdev) calls in Markus> radeon_driver_unload_kms >> (drivers/gpu/drm/radeon/radeon_kms.c) Markus> one after the other to find out which one is responsible? >> >> It's radeon_device_fini() that is the problem. Deucher,> I think the problem is that the drm subsystem tears down the Deucher,> device via drm_driver.unload in drm_dev_unregister(), but Deucher,> now that we have a pci_driver.shutdown callback (which is Deucher,> needed for kexec) that gets called too so the driver gets Deucher,> torn down twice. What exactly happens when you say it's Deucher,> broken? The machine hangs, with blank screen, getting hotter and hotter with the fan screaming. Magic sysrq does nothing. Power button sometimes works and sometimes does nothing. The only sure way out is to take the battery out of the laptop. -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA