dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Chubb <peter.chubb@nicta.com.au>
To: markus@trippelsdorf.de, alexander.deucher@amd.com
Cc: dri-devel@lists.freedesktop.org
Subject: Can no longer shutdown after drm/radeon: Implement radeon_pci_shutdown
Date: Wed, 11 Dec 2013 11:37:05 +1100	[thread overview]
Message-ID: <84mwk86x5a.wl%peter.chubb@nicta.com.au> (raw)


On my HP Elitebook 8740w qith a Mobility Radeon HD 5870
commit 846ae41ae99d314bf2a02784152208a6ddf7eddc
breaks shutdown.  The machine hangs when trying to shutdown, kexec or
hibernate, before seeing the usual `machine halted' (or whatever) message.

If I comment out thus:

index 9f5ff28..40bff3c 100644
--- a/drivers/gpu/drm/radeon/radeon_drv.c
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
@@ -514,7 +514,7 @@ radeon_pci_shutdown(struct pci_dev *pdev)
 {
 	struct drm_device *dev = pci_get_drvdata(pdev);
 
-	radeon_driver_unload_kms(dev);
+	/*radeon_driver_unload_kms(dev);*/
 }
 
then everything works again.  Thsi is obviously not the proper fix.

--
Dr Peter Chubb				        peter.chubb AT nicta.com.au
http://www.ssrg.nicta.com.au          Software Systems Research Group/NICTA

             reply	other threads:[~2013-12-11  1:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-11  0:37 Peter Chubb [this message]
2013-12-11  7:26 ` Can no longer shutdown after drm/radeon: Implement radeon_pci_shutdown Markus Trippelsdorf
2013-12-11 22:11   ` Peter Chubb
2013-12-11 23:46     ` Deucher, Alexander
2013-12-12  0:04       ` Peter Chubb
2013-12-12  2:58       ` Markus Trippelsdorf
2013-12-12  3:10         ` Peter Chubb
2013-12-12  3:27         ` Deucher, Alexander
2013-12-12 13:56           ` Markus Trippelsdorf
2013-12-12 14:11             ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84mwk86x5a.wl%peter.chubb@nicta.com.au \
    --to=peter.chubb@nicta.com.au \
    --cc=alexander.deucher@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=markus@trippelsdorf.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox