From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 644D2C433ED for ; Tue, 11 May 2021 14:09:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13D7361480 for ; Tue, 11 May 2021 14:09:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13D7361480 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 58CA26E23F; Tue, 11 May 2021 14:09:18 +0000 (UTC) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2077.outbound.protection.outlook.com [40.107.236.77]) by gabe.freedesktop.org (Postfix) with ESMTPS id B184D6E23F; Tue, 11 May 2021 14:09:17 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g860AhH3rNv/36c/WjwHxlPybMtHbAjJEdNrN3HTOIE4eUEOIda7Sirq0mTYzXxnhk/yZfRVSWxlP6cHMnZ/6B6az6FGT1kp7XNiqMZ/V7Oe73UVuYWoMHOH+9suNybma02BE9YNXKxbN0PGwIB0KH/9qgGeq/zjD/0NBCt3C2nfO+Nxk9YUDTUziXd2qst0AyRWhznxDskZvPLGIJHfws24ZTQg+9Y7oXCHpv00TCOV21Vd4EXJMkKse3lBVWpE2nJnVtKLUXRHVsCiQYhcVm+r9YwoANBIsKxL7XMK/VxQGCR7U6uK+WVrFv12pwqiUNt1jlEhLXwbLL27VagELQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iNtMLZiecHg14iEiDyCPNO6qqXFe74zx23+CuszR7Nc=; b=YxULEDl6anGwClCjkG5eSlTYs37gNCB68FtHgkRbiOBr1delELjiSArLF3G7C5NfuZnCGXszmEIHiBeLMQx3/Kk/DwIk0+f3WWBrocU3sZvEJtKvlArR06u8x0apNPmtPR6CIEMyqORrMLvUDEo9iLXb2a1diCFFQIrxtqOo9Cib4SsEQXpC/Am7vFGZcXSNYQQlpH4rJkx0LLW9dp4A5rJFR0L/SFBwgyvskUc2VMeXgvUxLcHpcLlqJwaP9UtJpqXYSndYB6BrHUPhHEMWCyTuIZ22R7Zw1CWnW2xEl+i0qH/iOlVSvUqHolkLTdiQWt7tFgszNy0/KEAr83acwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iNtMLZiecHg14iEiDyCPNO6qqXFe74zx23+CuszR7Nc=; b=Mmrh33ghAkVGQHBk+PTKacuw34vOvinrzV6vK59E6nYV8otTBntv1Q0AZc6XsN3LDRreFprRdsnVOIN/NFc2Viciccn/OF7CO9s6PBVVVKX/T2w3ftcEoJFNs1IitfXFNn7BuGDBM3oFPUhyvNoNEYPKR4MGvh0hfFT8xK+TTIA= Authentication-Results: lists.freedesktop.org; dkim=none (message not signed) header.d=none; lists.freedesktop.org; dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB3775.namprd12.prod.outlook.com (2603:10b6:208:159::19) by MN2PR12MB4536.namprd12.prod.outlook.com (2603:10b6:208:263::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Tue, 11 May 2021 14:09:14 +0000 Received: from MN2PR12MB3775.namprd12.prod.outlook.com ([fe80::6d4d:4674:1cf6:8d34]) by MN2PR12MB3775.namprd12.prod.outlook.com ([fe80::6d4d:4674:1cf6:8d34%6]) with mapi id 15.20.4108.031; Tue, 11 May 2021 14:09:14 +0000 Subject: Re: [PATCH 6/7] drm/i915/ttm, drm/ttm: Introduce a TTM i915 gem object backend To: =?UTF-8?Q?Thomas_Hellstr=c3=b6m_=28Intel=29?= , =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20210511132525.377190-1-thomas.hellstrom@linux.intel.com> <20210511132525.377190-7-thomas.hellstrom@linux.intel.com> <8ac6bc5c-17c0-2ffd-7f8c-823ab3c8a858@amd.com> <88ea8e22-3314-60a4-8f4b-0b37de444b1d@shipmail.org> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <8551810c-a095-3906-d982-7bc409140c48@amd.com> Date: Tue, 11 May 2021 16:09:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <88ea8e22-3314-60a4-8f4b-0b37de444b1d@shipmail.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [2a02:908:1252:fb60:5935:8b67:3cdd:7cc1] X-ClientProxiedBy: FR3P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::18) To MN2PR12MB3775.namprd12.prod.outlook.com (2603:10b6:208:159::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a02:908:1252:fb60:5935:8b67:3cdd:7cc1] (2a02:908:1252:fb60:5935:8b67:3cdd:7cc1) by FR3P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.12 via Frontend Transport; Tue, 11 May 2021 14:09:13 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 44b39f44-2de9-4f9e-def9-08d914865ba6 X-MS-TrafficTypeDiagnostic: MN2PR12MB4536: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IQOLcDRltpHw5jiyvJVSZTtCVND7htk/6D9LCO2Yn01CFWMv5D7xnyv4tAft0WhHNi6h8DnWmA8I1D2pJoK1+rgP0bx26zJ49iVBPv297Kxotr4VjaZVTaxBdQu/F3vvwbW+d8POCx9kcPYToQIubuoL9wk/5x6WsFly+1i3Wdn5GgMmfL2YrnF8ZoQUk6Dl6DqO/zOS7zVRUUQMhq1AqEZC6BiUJnuFzkmZo3N7LFt/IeMKuUBUfJZJkQMSw5bhutgjhZIQ9xNQsoiFB40znNYVYvfNZ5cLIOd5eFm31NKbM1bPvGmKNCPMjps2ln3LKIWjhVKL0XHHPlqzXKZJFt+BJRstDeixawy44S1+SLl8CX63tjdiMrUeVgLVAS4pC4qXRlafcgcWXylKQwRvF2x8wHlmyR6JrmzhepJeRpRANZa+VfwxT5OwEzOiHjPb6NBhEV+E7vBKwHneUyaeEpnWO/eH+vUFyzG2zQOTimpjunUIkfbmVBbSX+lypjbVjr+miE+QIKpJWSLO75JTzeVLdEjadJzCt85V3Q7zI31LZ1ROsMOk9R1ey2CEwh9vo87cXtGipHXRhyBFF/toa7aapeK6RNV4/1Y1WlCqG4aNm6PEL+N8LmIB8WNdmshkHC+j4JGq4Wan0bSKbVE624jpIn6t2TwPERfh+80L2Bh+u120kd077ZxEFz0gqoIS X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB3775.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6666004)(2906002)(83380400001)(66574015)(186003)(110136005)(498600001)(53546011)(38100700002)(8936002)(31686004)(5660300002)(2616005)(52116002)(36756003)(66476007)(66556008)(8676002)(31696002)(66946007)(86362001)(6486002)(16526019)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?S1Noc2V2MXhHR1pUQkFuS0ZxQklvSXlISnBTOFRQUFpjOTBXSmdHNG8wdDdH?= =?utf-8?B?STVWT3NSa1o1NDZYMEhvOElOMDl1Tytsb2hGdXdZQ0NxYWpEVVZqRHUyeExE?= =?utf-8?B?ZWt1dStoVmNRVjVCVW8zdUdSLzdZMHk0WDJhTm95WTZZZjVLcDY1ZlNvZGFY?= =?utf-8?B?UTNwVWtzbjRHeDRwd3JuMkFaZk9jeDhDcTZMWDFxWTFxRG9hK1lTenNHMGtM?= =?utf-8?B?aTU3OCsxcGR0aytLOUx2ODlUczk2bTB5YnZHUGx1bjFBc0hBZTNlZG9OWUtn?= =?utf-8?B?SCtycFd6aEFLVUtvNDNEeG9ldEtrVlpzYlFvYlBCVk8xQkVUVTV6ekxXRTZF?= =?utf-8?B?ZjNiQjVQMkkxa080amE4T2sxaWoxNWxXVlJmTGxySWtFUUZ5eXQyZm5uQ0Z4?= =?utf-8?B?L3B3K0o4ckc1T09rcGpMbmxyT2VEUnFXeFFWOWtJSlNWNlQwOGpPS0x1SmdG?= =?utf-8?B?Sk9UZDV3WmdSOWg2cVlWV2xUTHhxd0dPUXJOUTl4RHFkSC9rcDVhdGt6L0Yx?= =?utf-8?B?Z2NKYno1dEthQ0xKTERlKzA1SHhrR1ZvcDg0Q0Z3cVdzUkV1U2IwaTBHclpC?= =?utf-8?B?NHlmWHF0amhFV0JaREp1N05zK3czTGNGdFBqRW9oOHB6d1RSNmhNVXZrYnd0?= =?utf-8?B?VklzdDFqZ01TMWtKN3ZKOGdnSVh4a0hGNGtRM2p1bWtEZi9xNlYrNEZFV042?= =?utf-8?B?SUswbDJ1TDVyc3QzTGVsTWQzYlh4UzgwU0JkZFNVWCt2OTBRV0VqNWZRRnhv?= =?utf-8?B?ZWZCNk1HSWtQa1I2THloQ0g2VEI1N0J5b0x0K0hDN0R4bitxdUZMUmpYZ2Ex?= =?utf-8?B?Zmk2cVJxM1FiYU00cnAyaTRpTnc0dVhWdnBKdWtQaFk0Q1d3Rmk3NFVZbitT?= =?utf-8?B?UE1ZZ3NQbE8yNlYxZVIyYlcyUDdERmFaMDM4TlVaQitJVzEza0l4MHM0K1N3?= =?utf-8?B?Wk5aVWJ5c2JmbDh1UWhncVFFOWpTVU4vdGMwcEMxTktoT2ZwRVRHY2dMYlN5?= =?utf-8?B?MDdsdEppTHNQVWJCcWJHMnYrQkt1aTVwN0s1OWkyWlRPVzRtOFhndnhkWksv?= =?utf-8?B?Tkd1cGFISEl3ZHVoZ1BRTkd0MHU1NWZBYkIva0xKcytuL3cyRUN2SExTOFA4?= =?utf-8?B?YzYzNFU2cXJ2QXVYQ3Z0QlJSVFQrL2RlT2M2bWx0cGpBN1FZS2dIbEpEWDUw?= =?utf-8?B?cG05a1Y2WHdCVGRwZWxxemxQcmdJWkNuOTFBMElVS2k4TGxJcHhuQXcxcjB3?= =?utf-8?B?eG5HQ0RhTENBalg2UWlBTThvTWh3VHlVeGgrWmVtbC9rVGZ1ZFJFRVErMWdC?= =?utf-8?B?NzRRRDNrb2FiUTBEc3NrNFFCWEdtME1pRzhpYzFsTEFyZUo0dE9ESy9qQ3BN?= =?utf-8?B?UFUvV2xCUWEwUlBnVTJSYUZBSUdqOTdURWtzK01BNW1IdGNRbi9EMi9RUUlZ?= =?utf-8?B?U1lvRUY2ZjJwRldFSXlvcEl0Z3RDYmM2cG1EU2VjRFdNRUhXN1RPQVMzSVdP?= =?utf-8?B?QnpGOHkyRlpkcmNMY1Bzc2kvdy81NjdIeHVhOGR5YWtlRDZ5bUtBT0lQaTVt?= =?utf-8?B?ZWhGNXJiQUdLSmQ1OG45V3grM0g1clo1RHNZL2x2VW5NZ1F3VjM0WU9HUlhl?= =?utf-8?B?NFVxcWEzTmtsem53dmtaL0ZCRHR1ODhMUWppV0gvWFNQSEU3SThLN3lqTkps?= =?utf-8?B?TDRhZzFIZlE4aHZGK3J1QzIxeGpzbnRaUkxGQWJONExTcXRyMy9saTZGcm1o?= =?utf-8?B?TndqdjlLVFhsT2hqTHBNVEIrdjc5ZDIyeG5CS0N1NEEybWkrd3VpaVFhN3lJ?= =?utf-8?B?TGM0RjhUQU1jZ1VnODI5a29mUUp0M0xIbE81N0V4T2NMeEdPd3dDOUNQbzhH?= =?utf-8?Q?zD6+SZ/qeNF4g?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44b39f44-2de9-4f9e-def9-08d914865ba6 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2021 14:09:14.6940 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Azkc7sF6PJPxfhu/h2RGA+BZjJRrldBX+XCIn+Tt8AtiJ/Ayj9qbbqE8PwXRsj0m X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4536 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am 11.05.21 um 16:06 schrieb Thomas Hellström (Intel): > > On 5/11/21 3:58 PM, Christian König wrote: >> Am 11.05.21 um 15:25 schrieb Thomas Hellström: >>> Most logical place to introduce TTM buffer objects is as an i915 >>> gem object backend. We need to add some ops to account for added >>> functionality like delayed delete and LRU list manipulation. >>> >>> Initially we support only LMEM and SYSTEM memory, but SYSTEM >>> (which in this case means evicted LMEM objects) is not >>> visible to i915 GEM yet. The plan is to move the i915 gem system region >>> over to the TTM system memory type in upcoming patches. >>> >>> We set up GPU bindings directly both from LMEM and from the system >>> region, >>> as there is no need to use the legacy TTM_TT memory type. We reserve >>> that for future porting of GGTT bindings to TTM. >>> >>> There are some changes to TTM to allow for purging system memory buffer >>> objects and to refuse swapping of some objects: Unfortunately i915 gem >>> still relies heavily on short-term object pinning, and we've chosen to >>> keep short-term-pinned buffer objects on the TTM LRU lists for now, >>> meaning that we need some sort of mechanism to tell TTM they are not >>> swappable. A longer term goal is to get rid of the short-term pinning. >> >> Well just use the eviction_valuable interface for this. > > Yes, we do that for vram/lmem eviction, but we have nothing similar > for system swapping. Do I understand you correctly that you want me to > add a call to eviction_valuable() also for that instead of > swap_possible()? You should already have that. eviction_valuable is called in both cases. > > >> >> In general please make separate patches for the TTM changes and for >> the i915 changes using them for easier review. > > I'll respin with a split. Do you want me to do the same also for the > other two patches that minmally touch TTM? Yes, that makes it much easier to review the general usefulness of interface changes. Thanks, Christian. > > Thanks, > > Thomas > >