From: "Wentland, Harry" <Harry.Wentland@amd.com>
To: Mamta Shukla <mamtashukla555@gmail.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"hamohammed.sa@gmail.com" <hamohammed.sa@gmail.com>,
"rodrigosiqueiramelo@gmail.com" <rodrigosiqueiramelo@gmail.com>
Subject: Re: [PATCH v2 2/2] drm/vkms: Modify memset() in compute_crc function
Date: Thu, 31 Jan 2019 16:39:29 +0000 [thread overview]
Message-ID: <85ed4bd7-3a7d-6a96-610a-66514c55e145@amd.com> (raw)
In-Reply-To: <b7f37c793c9f37cddff6dc548a592412335114c6.1548798107.git.mamtashukla555@gmail.com>
On 2019-01-29 5:00 p.m., Mamta Shukla wrote:
> Replace memset(vaddr_out + src_offset + 24, 0, 8) with
> memset(vaddr_out + src_offset + 3, 0, 1) because memset fills
> memory in bytes and not in bits.
>
> Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com>
Series is
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> No changes in v2.
>
> drivers/gpu/drm/vkms/vkms_crc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_crc.c b/drivers/gpu/drm/vkms/vkms_crc.c
> index dc6cb4c2cced..5135642fb204 100644
> --- a/drivers/gpu/drm/vkms/vkms_crc.c
> +++ b/drivers/gpu/drm/vkms/vkms_crc.c
> @@ -31,7 +31,7 @@ static uint32_t compute_crc(void *vaddr_out, struct vkms_crc_data *crc_out)
> + (i * crc_out->pitch)
> + (j * crc_out->cpp);
> /* XRGB format ignores Alpha channel */
> - memset(vaddr_out + src_offset + 24, 0, 8);
> + memset(vaddr_out + src_offset + 3, 0, 1);
> crc = crc32_le(crc, vaddr_out + src_offset,
> sizeof(u32));
> }
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-01-31 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 21:54 [PATCH v2,1/2] drm/vkms: Use alpha for blending in blend() function Mamta Shukla
2019-01-29 22:00 ` [PATCH v2 2/2] drm/vkms: Modify memset() in compute_crc function Mamta Shukla
2019-01-31 16:39 ` Wentland, Harry [this message]
2019-02-14 22:31 ` Rodrigo Siqueira via dri-devel
2019-01-31 12:44 ` [PATCH v2,1/2] drm/vkms: Use alpha for blending in blend() function Rodrigo Siqueira
2019-02-01 17:15 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85ed4bd7-3a7d-6a96-610a-66514c55e145@amd.com \
--to=harry.wentland@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=mamtashukla555@gmail.com \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox