From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFEC5CCFA0D for ; Thu, 6 Nov 2025 03:29:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E39A910E0AE; Thu, 6 Nov 2025 03:29:11 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="CbNksnmp"; dkim-atps=neutral Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com [209.85.222.46]) by gabe.freedesktop.org (Postfix) with ESMTPS id 41CC110E119 for ; Thu, 6 Nov 2025 03:29:11 +0000 (UTC) Received: by mail-ua1-f46.google.com with SMTP id a1e0cc1a2514c-93539c5e2b5so290122241.0 for ; Wed, 05 Nov 2025 19:29:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762399750; x=1763004550; darn=lists.freedesktop.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=n4CaiNtBzk+J1ksip0bh0eyQEO10boIF1xJKJ7rk94I=; b=CbNksnmpt9WJz5dzLjh3JgM10H1AjvbkDC6nA9swDiaA3xnabW7vGkkMpYoe+Dl6I6 BW5JqU8UMUv4fSTjCfkOOy2IdVSQs0TRiapfBlX8fFMofzWLln9RkSvQ7owVb49T7YG3 FbrkhSm3UAKd/NOx5RjlTjYFT4EUzWnqA2bEj6keSD+C9+LPHgTb1ztoXcmYVyQ2SS59 toRA1Oczxsm7N8fKgTr18drsSbD9VJwpuKXbjr1EzYs5cgsPwserVQZgdaomJpeQhEtQ +yH1BrLHOgrXnEIJReERYY5SAnonBAepUEnlkIwTEw8me3F6cGHIUZbQTrCun4DikHcx R+Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762399750; x=1763004550; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n4CaiNtBzk+J1ksip0bh0eyQEO10boIF1xJKJ7rk94I=; b=TDudPhoHs9SzHH5i6qR1wdU4JTS92T07Eg7gswG6chNgNnrQmswNmoqDmh/rmyq4pV 7n3uieuC2QYxMzIeBS03eRBbnEaW2JPohSmUoIrxARafk4Q2CXjThggytAXFQ/DpujHS XT6UB3Q+nSkcg2ljNqeem3UsSOPL4z7T8Q/qrqvh5h43bAV4TU69G/ATuQEm2Wfj5YUn 4HAHjAo8IHmP7MELXA8Z5JBrZthMZGSbcYHUFW9r96GrpubDhWq+A06VSjTk2WUJ2Eax 9e7mIJV2HGu/cqtQnSOV6i19yYwT0qtMTz0nlKx1fkv2wHPJLPzI2bIKXRBHEMqAU2Cf YWmA== X-Forwarded-Encrypted: i=1; AJvYcCXKYyIJlWj/79gJNCTTEOg9UIqJxVRe+tZKa7LsQXV0nqUUKkcxnhDkpI6R1hUOPJ+4Ne7zklN8kOE=@lists.freedesktop.org X-Gm-Message-State: AOJu0YywFkvUadqQBv9h6+///btKTysM0zfWHNKjq4Cerh8NO6ablzIK HqC/tNrqgBOIyUL/Y8I318FgAY20z5qhDzwR1gkaVhYmB4f+z9ujxXj7 X-Gm-Gg: ASbGncsDo7YsrUpm/MEexZWKwh4EMsYkEzjeRrTWIGPq9f9MMYLS+XXvoqmoIhGlTWj ON07Ll5/pZcREZ+6HyUP7LA6IuHWbnFBcCaptZ6SyPEoq09C+f0iGoJKvb9I6QgeZ4d8xsNOaaX q84hKh6yVSpzbT7cuRKSt8vhbzAftGsXlxClrjHuCstuHbAeTlTfCV/WTEGGXkNQD3HRRtzvDuE Visn+NbT+RpZNQw6UsHgIgaBFQ5Kb355Vwzp74d5JfzeL7qp2Y+umH/q6Avq2pE7BToa2KcnTap dkEgzdQ67Y7lIwm5/MSkNlHACXU/zRTbjTcF822TXNDwIoW0R5zeSvikoEwvlDQ/ljapodJnC+Z nFtBYa7zsiYtvZLVrz5p5Hsyn+ml8w+YDZtS9EvU4QXF+1FFplHui/F4qzjWQrX8R3w94F9LSQP 4rV+yl9JAc0KP3ibcHXSlTgdehiVZrrIllak9Wu6hCLCQI0g+HPDkuGtaYZ/0ZJATsvQ== X-Google-Smtp-Source: AGHT+IFz8CjtY22nY8CSkSNf3qcSwgBcNz2TUbUcHnHKwWyMgld/sbQ3g787kvjrkj/fsGZMF1TvTw== X-Received: by 2002:a05:6102:f12:b0:5db:aee2:9964 with SMTP id ada2fe7eead31-5dd9fcfa31bmr711345137.9.1762399749959; Wed, 05 Nov 2025 19:29:09 -0800 (PST) Received: from ?IPv6:2001:4c4e:24ca:a400:c3d8:2d5a:cb81:c0d3? ([2001:4c4e:24ca:a400:c3d8:2d5a:cb81:c0d3]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-937089699dcsm550066241.10.2025.11.05.19.29.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Nov 2025 19:29:09 -0800 (PST) Message-ID: <867953df79b54037ce91cf1886b09ec5c30f7442.camel@gmail.com> Subject: Re: linux-next-20251029 - build error in amdgpu From: Timur =?ISO-8859-1?Q?Krist=F3f?= To: Amit Dhingra Cc: Valdis =?UTF-8?Q?Kl=C4=93tnieks?= , Alex Deucher , Leo Li , David Airlie , amd-gfx list , dri-devel , linux-kernel@vger.kernel.org Date: Thu, 06 Nov 2025 04:29:05 +0100 In-Reply-To: References: <1043551.1761844832@turing-police> <32ed124e9d603cad950c4836c7a14a3ba8bc2068.camel@gmail.com> <1296761.1762045181@turing-police> <149f5bb52a21becedc17a5b0bf1a586672940af6.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 2025-11-05 at 19:24 -0800, Amit Dhingra wrote: > On Thu, Nov 06, 2025 at 03:40:52AM +0100, Timur Krist=C3=B3f wrote: > > On Wed, 2025-11-05 at 18:34 -0800, Amit Dhingra wrote: > > >=20 > > > >=20 > > > > What do I need to do to trigger the warning? > > > >=20 > > > I have the same problem. > > >=20 > > > linux-next on Arch Linux > > > GCC : 15.2.1 20250813 > > >=20 > > >=20 > > > Steps to reproduce the error > > > - make mrproper > > > - make allmodconfig > > > - make drivers/gpu/drm/amd/amdgpu/ > > >=20 > > > Turns out its due to randconfig, See [1] > > >=20 > > > Setting RANDSTRUCT_NONE=3Dy seems to stop the error. > >=20 > > Can you please try and see if this fixes the warning? > > https://pastebin.com/raw/b8j3UABj >=20 > The patch above defining all fields seems to fix the error. >=20 > >=20 > > Alternatively, if anyone has other recommendations on how to fix > > it, > > I'm also open to suggestions. > >=20 >=20 > What seemed to also work for me is to defining the struct as below > without an initialization. >=20 > static const struct stream_encoder_funcs dce110_an_str_enc_funcs; >=20 > Its static so should be initialized zeroed out. objdump shows correct > size > allocation. >=20 > objdump -x dce_stream_encoder.o >=20 > =C2=A0 0000000000000b60 l=C2=A0=C2=A0=C2=A0=C2=A0 O .rodata 0000000000000= 130 > dce110_str_enc_funcs > =C2=A0 0000000000000a00 l=C2=A0=C2=A0=C2=A0=C2=A0 O .rodata 0000000000000= 130 > dce110_an_str_enc_funcs >=20 Thanks! This looks even cleaner. I will submit a patch to fix the warning next week. Can I add your name and email to the Suggested-by tag? Thanks, Timur >=20 > > Thanks, > > Timur > >=20 > >=20 > > > >=20 > > > > Valdis Kl=C4=93tnieks ezt =C3=ADrta (id= =C5=91pont: > > > > 2025. > > > > nov. > > > > 2., Vas 1:59): > > > >=20 > > > > > On Thu, 30 Oct 2025 19:05:30 +0100, Timur Krist=C3=B3f said: > > > > >=20 > > > > > > Can you say how to reproduce that? > > > > > > I use the same version of GCC but it hasn't given me any > > > > > > warning or > > > > > > error for that patch. > > > > >=20 > > > > > Upon further testing, > > > > >=20 > > > > > [/usr/src/linux-next] make > > > > >=20 > > > > > is sufficient on my system. Turns out that it errors out even > > > > > without W=3D1. > > > > > My > > > > > next guess was that it had to do with -Werror, which would > > > > > cause > > > > > warnings > > > > > to > > > > > be treated as errors, but my .config has > > > > >=20 > > > > > # CONFIG_WERROR is not set > > > > > # CONFIG_DRM_WERROR is not set > > > > > # CONFIG_DRM_AMDGPU_WERROR is not set > > > > >=20 > > > > > Do you perhaps have patches in your tree that aren't in next- > > > > > 20251029? > > > > >=20 > > > > > I wonder if Fedora's build of gcc 15.2.1 is different somehow > > > > > from the > > > > > build you're using.... > > > > >=20 > > > > >=20 > > > > >=20 > > > > >=20