From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 2/2] drm/kms: Use the standard VESA timeout for DDC channels Date: Wed, 23 Nov 2011 13:24:33 -0800 Message-ID: <867h2qedm6.fsf@sumi.keithp.com> References: <201110210910.12848.jdelvare@suse.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0279020675==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 0A2059EB46 for ; Wed, 23 Nov 2011 13:24:31 -0800 (PST) In-Reply-To: <201110210910.12848.jdelvare@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jean Delvare , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0279020675== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 21 Oct 2011 09:10:12 +0200, Jean Delvare wrote: > - /* vesa says 2.2 ms is enough, 1 jiffy doesn't seem to always > - * make this, 2 jiffies is a lot more reliable */ > - i2c->algo.bit.timeout =3D 2; > + i2c->algo.bit.timeout =3D usecs_to_jiffies(2200); /* from VESA */ From=20my reading of the usecs_to_jiffies code, it always returns a time at least as long as requested, so this will ensure that you're waiting at least 2.2ms, unlike 2 jiffies which is some random amount of time depending on the HZ setting in the kernel. Reviewed-by: Keith Packard =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIVAwUBTs1kkTYtFsjWk68qAQj05w/+JmI7bOavji5o9cf26Z9nDpjse/D6uMfi 6Gf/HjrtAiEZfnbKhmR26mnuoOklx6XImDY29qn9/2j/4n9yCh9Zho5cD4xsZGsV +i4Q7XRL2kCfqN8FQxkoRm7PUZSDbHjBzNRfUS56Igml8lYWRdmpwtbCpPQxD883 EJcxycojSmTNT2BjIAQCFws+jcWZSAikvbFxYlmdbELFieOjz5j48jnk7+qf0qxz 2tM//9acjksGxeHat8xcn0hA5IF/RnVJZ8i0gQVrbEdhZhH+f9BPalx11JIyd+Na U92sjEvba9D4vBJ32gJJJXN55upgbPTPcPOvYzzKa1oEoAopm+J1653mGGn25KpC kjFYiQeY8URf0nO2/Zw4av+ZhKZmxJDI/0BnFui7voUEoQpy1kqTQjNMsli268eo RCTCSzt/XuxXrFkXgbq+FqLghQ7nuwRKth+mMBoG27bT6YrjqGPXQo5BuTOdn3bI X7fFypx0Gnl507guWd2fRMeDw0YdltbKU5fXXmyrptWyRC+wq8pcKGqTQazq9gjL AqI8XeY19KAUMR6tUdccGcH9mVo9lFY4RDTaNX/u9dVzpk2IgQYA9jKS15QL1oTt PepC/AeGRLLLJ+9J7Dzj3D7VkixUF0T4D1/WbGdCnI/Yqixi4ukM4Fzn4Fsvxcay 95lIiyB1EyE= =/tLe -----END PGP SIGNATURE----- --=-=-=-- --===============0279020675== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0279020675==--