From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 1/2] Revert "drm: omapdrm: Let the DRM core skip plane commit on inactive CRTCs" Date: Mon, 30 Jan 2017 10:48:43 +0200 Message-ID: <8687fdb8-c8a8-86b2-4a7e-74aa0bbce22e@ti.com> References: <4e28061a55b9473631f0793e1a056fcda8163508.1485510281.git.jsarha@ti.com> <1633511.8VzXcN818D@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1958413006==" Return-path: Received: from lelnx193.ext.ti.com (lelnx193.ext.ti.com [198.47.27.77]) by gabe.freedesktop.org (Postfix) with ESMTPS id F41CE6E38C for ; Mon, 30 Jan 2017 08:48:50 +0000 (UTC) In-Reply-To: <1633511.8VzXcN818D@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , Jyri Sarha Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1958413006== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="e7vcfmpMIQG7GnE6o1MKQq21Uv0lGJgR1" --e7vcfmpMIQG7GnE6o1MKQq21Uv0lGJgR1 Content-Type: multipart/mixed; boundary="aVOe95PNhJ08lLaxgfraNL53ErXRt7DOe"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart , Jyri Sarha Cc: dri-devel@lists.freedesktop.org, airlied@linux.ie, daniel@ffwll.ch Message-ID: <8687fdb8-c8a8-86b2-4a7e-74aa0bbce22e@ti.com> Subject: Re: [PATCH 1/2] Revert "drm: omapdrm: Let the DRM core skip plane commit on inactive CRTCs" References: <4e28061a55b9473631f0793e1a056fcda8163508.1485510281.git.jsarha@ti.com> <1633511.8VzXcN818D@avalon> In-Reply-To: <1633511.8VzXcN818D@avalon> --aVOe95PNhJ08lLaxgfraNL53ErXRt7DOe Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 28/01/17 18:11, Laurent Pinchart wrote: > Hi Jyri, >=20 > Thank you for the patch. >=20 > On Friday 27 Jan 2017 12:04:54 Jyri Sarha wrote: >> This reverts commit dadf4659d0608e034b6633f30300c2eff2dafb4c. >> >> If planes are not disabled when the they are not on any crtc anymore >> they will remain active and may show as "ghosts" when the crtc they >> were last on is active again. >=20 > Sorry for the breakage. >=20 > The drm_atomic_helper_commit_planes() helper documentation states >=20 > * Unless otherwise needed, drivers are advised to set the ACTIVE_ONLY = flag in > * @flags in order not to receive plane update notifications related to= a > * disabled CRTC. This avoids the need to manually ignore plane updates= in > * driver code when the driver and/or hardware can't or just don't need= to > * deal with updates on disabled CRTCs, for example when supporting run= time > * PM. >=20 > I wonder what this implies when CRTCs are being disabled. I see very fe= w cases=20 > where the hardware wouldn't need the plane atomic disable operation bei= ng=20 > called when a plane is being disabled due to its CRTC being disabled. M= aybe=20 > this should thus be addressed in the core. Daniel, any comment on this = ? Similar change was done to mali in "drm: mali-dp: Don't set DRM_PLANE_COMMIT_ACTIVE_ONLY", so at least omapdrm is not alone here. I also wonder if this behavior is correct. Tomi --aVOe95PNhJ08lLaxgfraNL53ErXRt7DOe-- --e7vcfmpMIQG7GnE6o1MKQq21Uv0lGJgR1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYjv3rAAoJEPo9qoy8lh71GaIQAIjACZGvZom6XLd2mMoAkzBY iMXPs5MbTjbYBFHKV/MOVK8FKz2zERgQBf7YVRJZM+jwKemgTq4ersBHVmKQFhOn bEg8PH8sXGmKoWscdRmtdirE3pBt6w5GKwT4iicSbIBXminOAkAaDK46zncCEcds EDHjMKcDFafeoEEQduKLHu9C4JDITXlJ5Kz2poyr/ZSXs5Y+HlQCXgfM4LAVfVvH OZKisWwXQ0JDPv9U+Xu5rTD2EEZBucamK8hZixgXpK7BWkGA2eie3enx+khwzzM1 xjpEsT5esjHcT8LtqaEjnfrwFiWIUhLatPCwyWFtfqbRGeuMoJ7AQIRhO77CX/dD 16YkN1mgDR4QavOlq3Mk5CkKJsDWDMlnaXk8KLg00q9DkOmIKnVZCfZUGHxr7f8+ kZ0b/JPDlU46usv9N36xO4lXseHe6Z015B+HIm/D33Y1nBEbX67taGYyRnvgk9an xEPcdUs9QrQ2QnKAMxb0IOU3gNAnX0+OPLyp2FtrcqE8vLM6pNGlBzh7AUJBoVx5 kQxUDouLBWkSlfDceU7oJ0P5iPSm8wnSpHi01YCUWnsCfymHVlBStkGPbGmSAFso dvhNoGtdz2dcGYK0XUuiuSCyKyxxW9ozaCR7U0CVZJ0yTuPt0VBfNFUyD2nBzb+e K3l+v3Q0G4919aVTOtGy =G+Ht -----END PGP SIGNATURE----- --e7vcfmpMIQG7GnE6o1MKQq21Uv0lGJgR1-- --===============1958413006== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1958413006==--