dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Arthur Grillo" <arthurgrillo@riseup.net>,
	dri-devel@lists.freedesktop.org
Cc: tales.aparecida@gmail.com, Helge Deller <deller@gmx.de>,
	Javier Martinez Canillas <javierm@redhat.com>,
	mairacanal@riseup.net, andrealmeid@riseup.net
Subject: Re: [PATCH] drm/tests: Remove CONFIG_DRM_FBDEV_EMULATION on .kunitconfig
Date: Thu, 27 Jul 2023 10:33:40 +0200	[thread overview]
Message-ID: <86fcd546-c2db-41ca-a087-74c3cd5ce341@app.fastmail.com> (raw)
In-Reply-To: <20230726220325.278976-1-arthurgrillo@riseup.net>

On Thu, Jul 27, 2023, at 00:03, Arthur Grillo wrote:
> Using the `kunit_tool` with the command:
>
> tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests/
>
> Lead to this error[0]. Fix it by expliciting removing the
> CONFIG_DRM_FBDEV_EMULATION.
>
> [0]
> ERROR:root:
> WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE
>   Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y]
>   Selected by [y]:
>   - DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n]
>

I think that's a bug in the Kconfig files that should be fixed
by enforcing the correct set of dependencies. I have not encountered
this in my randconfig builds (with a lot of other fixes applied)

In linux-next, CONFIG_VT cannot be disabled if CONFIG_EXPERT=n,
so this does not happen.

> diff --git a/drivers/gpu/drm/tests/.kunitconfig 
> b/drivers/gpu/drm/tests/.kunitconfig
> index 6ec04b4c979d..c50b5a12faae 100644
> --- a/drivers/gpu/drm/tests/.kunitconfig
> +++ b/drivers/gpu/drm/tests/.kunitconfig
> @@ -1,3 +1,4 @@
>  CONFIG_KUNIT=y
>  CONFIG_DRM=y
>  CONFIG_DRM_KUNIT_TEST=y
> +CONFIG_DRM_FBDEV_EMULATION=n
>
> base-commit: 45b58669e532bcdfd6e1593488d1f23eabd55428

Changing the local config should not be required after fixing
the Kconfig files.

    Arnd

  reply	other threads:[~2023-07-27  8:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26 22:03 [PATCH] drm/tests: Remove CONFIG_DRM_FBDEV_EMULATION on .kunitconfig Arthur Grillo
2023-07-27  8:33 ` Arnd Bergmann [this message]
2023-07-27 16:07   ` Javier Martinez Canillas
2023-07-27 16:39     ` Arthur Grillo Queiroz Cabral
2023-07-27 16:45       ` Javier Martinez Canillas
2023-07-27 17:56         ` Arnd Bergmann
2023-07-28 10:41           ` Javier Martinez Canillas
2023-08-04 12:53             ` Javier Martinez Canillas
2023-07-27 16:44   ` Arthur Grillo Queiroz Cabral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86fcd546-c2db-41ca-a087-74c3cd5ce341@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=andrealmeid@riseup.net \
    --cc=arthurgrillo@riseup.net \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=mairacanal@riseup.net \
    --cc=tales.aparecida@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox