From: Keith Packard <keithp@keithp.com>
To: "Eric Anholt" <eric@anholt.net>,
"Kertesz Laszlo" <laszlo.kertesz@gmail.com>,
"Michel Dänzer" <michel@daenzer.net>
Cc: "List, X.Org" <xorg-devel@lists.freedesktop.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor)
Date: Sat, 27 Dec 2014 13:00:31 -0800 [thread overview]
Message-ID: <86lhlsq040.fsf@hiro.keithp.com> (raw)
In-Reply-To: <873881arbn.fsf@eliezer.anholt.net>
[-- Attachment #1.1: Type: text/plain, Size: 796 bytes --]
Eric Anholt <eric@anholt.net> writes:
>> --- a/glamor/glamor_xv.c
>> +++ b/glamor/glamor_xv.c
>> @@ -435,7 +435,7 @@ glamor_xv_put_image(glamor_port_private *port_priv,
>> }
>>
>> top = (src_y) & ~1;
>> - nlines = (src_y + height) - top;
>> + nlines = (src_y + src_h) - top;
>>
>> switch (id) {
>> case FOURCC_YV12:
>
> If the point is to upload only from the src_[xywh] recctangle, shouldn't
> the glamor_upload_sub_pixmap_to_texture() calls be using src_w instead
> of width, too?
It doesn't need to, but it could as an optimization. Skipping lines at
the top and bottom is also just an optimization as the source rectangle
defines a subset of the provided buffer, after all. I just fixed that
optimization.
--
keith.packard@intel.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 810 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-12-27 21:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 12:13 Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor) Laszlo Kertesz
2014-10-28 13:41 ` Alex Deucher
2014-12-18 22:03 ` Kertesz Laszlo
2014-12-18 22:09 ` Alex Deucher
2014-12-26 0:01 ` Kertesz Laszlo
2014-12-26 1:26 ` Michel Dänzer
2014-12-26 3:10 ` Kertesz Laszlo
2014-12-26 3:17 ` Michel Dänzer
2014-12-26 11:43 ` Kertesz Laszlo
[not found] ` <1419594203.1679.1.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-27 17:18 ` Keith Packard
[not found] ` <86a929ypsa.fsf-6d7jPg3SX/+z9DMzp4kqnw@public.gmane.org>
2014-12-27 18:19 ` Eric Anholt
2014-12-27 21:00 ` Keith Packard [this message]
2014-12-28 18:01 ` Eric Anholt
[not found] ` <86lhlsq040.fsf-6d7jPg3SX/+z9DMzp4kqnw@public.gmane.org>
2014-12-28 18:02 ` Eric Anholt
[not found] ` <87vbkvac0o.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
2014-12-28 23:13 ` Keith Packard
2014-12-27 20:21 ` Kertesz Laszlo
2014-12-27 21:01 ` Keith Packard
2014-12-19 2:28 ` Michel Dänzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86lhlsq040.fsf@hiro.keithp.com \
--to=keithp@keithp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=laszlo.kertesz@gmail.com \
--cc=michel@daenzer.net \
--cc=xorg-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).