From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH] present: Send GLX_BufferSwapComplete events from present extension Date: Mon, 25 Nov 2013 18:39:33 -0800 Message-ID: <86ob5751ju.fsf@miki.keithp.com> References: <1385103256-24620-1-git-send-email-keithp@keithp.com> <877gbwcd6l.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0405854880==" Return-path: In-Reply-To: <877gbwcd6l.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mesa-dev-bounces@lists.freedesktop.org Errors-To: mesa-dev-bounces@lists.freedesktop.org To: Eric Anholt , xorg-devel@lists.freedesktop.org Cc: mesa-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0405854880== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable Eric Anholt writes: > There's a minor behavior change that the event now gets sent to the > drawable owner rather than the caller of DRI2SwapBuffers. Yeah, probably not ideal, especially when the GLX drawable is created using the window XID (as is the case for some older GLX clients). I don't have the original client at the time the event is generated, but I think I can go back and stick it in; will require tracking when the client exits, of course. > I don't expect it to matter in practice (I expect that the > swap-requesting client using this GLX extension is also the > drawable-creating one), and either choice seems wrong compared to "send > the event to everyone listening for the event on this drawable". That > would be a separate change, anyway. I think the original behaviour, sending the event to the client who sent the PresentPixmap request is the only sane plan, and only a bit more complicated than sending it to the drawable owner. I'll cook up an alternate patch and send that along; we can then compare the two approaches at least. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIVAwUBUpQJ5tsiGmkAAAARAQgVSA//Xhb9i5N7Y/NfFPSnK3IX3TYTt/3QxIpe 6SZZRTr568wyC3z9D3W8CRbEdit/9LvE2TZou5oR+3Wcl/AcLWq77R3mi7D9jTcx OW+gDFIWSpsTuNT9Em6VcZVyRFNS8gLN57BpPI+QWsSHboIzBgClDtDPvw7ItqWg uUDJC35KVeUgtXQkaOsr0MMFXS3laVPYbzj2AcXSC4CDh7Pl1LwKm8EUneG0X8Og iLbkEVt4zV+FhihLR357hmIXeCAXH1hqfiKZxi3Cusuc0G7UG7M7cHVxLMlwSm6t r2nEuAMJlr2AWFqgGF9gk9dkH8tTunlZ1zEDYvMmuivhy2rKVe3CuHb5AUC0XgNI 9qiOXl2Ymx8QP6JbedV0ONIE+H6q/1FuhPXod3Mv20KzN0x+OEP2leBRiHSWnc// dpqpUegfST92OkUuvGaG2V/Y0Zbuj6YpIy0H8/yDy++DTypr7fXFep6VH7SinjQF 9Ppp+nf7IYUky0lCejf9jB1wSPkjad3ao4W0nTCQ2AJXDmZea1552mTso5y8SebG TH1MvXUh5wHLgkX5xz8101MVbEflT1KgkYCCnbbR7HsSUiugzxCNMOJ6s98gYWrZ CJOtHose3stmjMwE1EAeaaCwS04cwIkxQgg4X0n8nT7DO/sNyhr+3Xv+WPkzB8J0 6xK2CQmi+uI= =s2sT -----END PGP SIGNATURE----- --=-=-=-- --===============0405854880== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev --===============0405854880==--