From: Jani Nikula <jani.nikula@linux.intel.com>
To: He Lugang <helugang@uniontech.com>, rodrigo.vivi@intel.com
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
He Lugang <helugang@uniontech.com>
Subject: Re: [RESEND PATCH] drm/i915:Remove unused parameter in marco
Date: Wed, 02 Oct 2024 16:10:27 +0300 [thread overview]
Message-ID: <871q0ytzuk.fsf@intel.com> (raw)
In-Reply-To: <6C2E07E089F0CB73+20240925064016.733173-1-helugang@uniontech.com>
On Wed, 25 Sep 2024, He Lugang <helugang@uniontech.com> wrote:
> The parameter dev_priv is actually not used in macro PORT_ALPM_CTL
> and PORT_ALPM_LFPS_CTL,so remove it to simplify the code.
>
> Reviewed-by: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: He Lugang <helugang@uniontech.com>
> ---
> drivers/gpu/drm/i915/display/intel_alpm.c | 4 ++--
> drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
> drivers/gpu/drm/i915/display/intel_psr_regs.h | 4 ++--
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
> index 186cf4833f71..57afb25191bd 100644
> --- a/drivers/gpu/drm/i915/display/intel_alpm.c
> +++ b/drivers/gpu/drm/i915/display/intel_alpm.c
> @@ -330,7 +330,7 @@ static void lnl_alpm_configure(struct intel_dp *intel_dp,
> ALPM_CTL_AUX_LESS_WAKE_TIME(intel_dp->alpm_parameters.aux_less_wake_lines);
>
> intel_de_write(display,
> - PORT_ALPM_CTL(display, port),
> + PORT_ALPM_CTL(port),
> PORT_ALPM_CTL_ALPM_AUX_LESS_ENABLE |
> PORT_ALPM_CTL_MAX_PHY_SWING_SETUP(15) |
> PORT_ALPM_CTL_MAX_PHY_SWING_HOLD(0) |
> @@ -338,7 +338,7 @@ static void lnl_alpm_configure(struct intel_dp *intel_dp,
> intel_dp->alpm_parameters.silence_period_sym_clocks));
>
> intel_de_write(display,
> - PORT_ALPM_LFPS_CTL(display, port),
> + PORT_ALPM_LFPS_CTL(port),
> PORT_ALPM_LFPS_CTL_LFPS_CYCLE_COUNT(10) |
> PORT_ALPM_LFPS_CTL_LFPS_HALF_CYCLE_DURATION(
> intel_dp->alpm_parameters.lfps_half_cycle_num_of_syms) |
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 136a0d6ca970..3468a8b55e2b 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -2114,7 +2114,7 @@ static void intel_psr_disable_locked(struct intel_dp *intel_dp)
> ALPM_CTL_ALPM_AUX_LESS_ENABLE, 0);
>
> intel_de_rmw(display,
> - PORT_ALPM_CTL(display, cpu_transcoder),
> + PORT_ALPM_CTL(cpu_transcoder),
> PORT_ALPM_CTL_ALPM_AUX_LESS_ENABLE, 0);
> }
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr_regs.h b/drivers/gpu/drm/i915/display/intel_psr_regs.h
> index 642bb15fb547..98814868d26c 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr_regs.h
> +++ b/drivers/gpu/drm/i915/display/intel_psr_regs.h
> @@ -295,7 +295,7 @@
>
> #define _PORT_ALPM_CTL_A 0x16fa2c
> #define _PORT_ALPM_CTL_B 0x16fc2c
> -#define PORT_ALPM_CTL(dev_priv, port) _MMIO_PORT(port, _PORT_ALPM_CTL_A, _PORT_ALPM_CTL_B)
> +#define PORT_ALPM_CTL(port) _MMIO_PORT(port, _PORT_ALPM_CTL_A, _PORT_ALPM_CTL_B)
> #define PORT_ALPM_CTL_ALPM_AUX_LESS_ENABLE REG_BIT(31)
> #define PORT_ALPM_CTL_MAX_PHY_SWING_SETUP_MASK REG_GENMASK(23, 20)
> #define PORT_ALPM_CTL_MAX_PHY_SWING_SETUP(val) REG_FIELD_PREP(PORT_ALPM_CTL_MAX_PHY_SWING_SETUP_MASK, val)
> @@ -306,7 +306,7 @@
>
> #define _PORT_ALPM_LFPS_CTL_A 0x16fa30
> #define _PORT_ALPM_LFPS_CTL_B 0x16fc30
> -#define PORT_ALPM_LFPS_CTL(dev_priv, port) _MMIO_PORT(port, _PORT_ALPM_LFPS_CTL_A, _PORT_ALPM_LFPS_CTL_B)
> +#define PORT_ALPM_LFPS_CTL(port) _MMIO_PORT(port, _PORT_ALPM_LFPS_CTL_A, _PORT_ALPM_LFPS_CTL_B)
Thanks for the patch, pushed drm-intel-next with the indentation changes
fixed while applying.
BR,
Jani.
> #define PORT_ALPM_LFPS_CTL_LFPS_START_POLARITY REG_BIT(31)
> #define PORT_ALPM_LFPS_CTL_LFPS_CYCLE_COUNT_MASK REG_GENMASK(27, 24)
> #define PORT_ALPM_LFPS_CTL_LFPS_CYCLE_COUNT_MIN 7
--
Jani Nikula, Intel
prev parent reply other threads:[~2024-10-02 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 6:40 [RESEND PATCH] drm/i915:Remove unused parameter in marco He Lugang
2024-10-02 13:10 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q0ytzuk.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=helugang@uniontech.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).