dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Nicolai Stange <nicstange@gmail.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	Nicolai Stange <nicstange@gmail.com>,
	dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops
Date: Sun, 21 May 2017 09:31:09 +0200	[thread overview]
Message-ID: <871srifyyq.fsf@gmail.com> (raw)
In-Reply-To: <cfb91ba052af06117137eec0637543a2626a7979.1495135190.git.lukas@wunner.de> (Lukas Wunner's message of "Thu, 18 May 2017 21:33:44 +0200")

On Thu, May 18 2017, Lukas Wunner wrote:

<snip>

> Reported-by: Nicolai Stange <nicstange@gmail.com>
> Fixes: 7ffb0ce31cf9 ("drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo")
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> ---
>
> Awaiting a Tested-by: from Nicolai, but it's clear this is a bug and
> needs to be fixed, so sending out with a proper commit message now.
> The bug was only introduced to radeon, not amdgpu.

Tested-by: Nicolai Stange <nicstange@gmail.com>

Thanks for the quick fix!


> @Alex Deucher: I could push this to drm-misc-fixes but then it wouldn't
> land before -rc3 because Sean Paul has already sent out the -rc2 pull.
> I notice you haven't sent out a pull for -rc2 yet, so maybe you want to
> take it yourself?  Whichever you prefer.  Thanks & sorry for the breakage!
>
>  drivers/gpu/drm/radeon/radeon_kms.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/radeon_kms.c
> index 6a68d440bc44..d0ad03674250 100644
> --- a/drivers/gpu/drm/radeon/radeon_kms.c
> +++ b/drivers/gpu/drm/radeon/radeon_kms.c
> @@ -116,7 +116,7 @@ int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags)
>  	if ((radeon_runtime_pm != 0) &&
>  	    radeon_has_atpx() &&
>  	    ((flags & RADEON_IS_IGP) == 0) &&
> -	    !pci_is_thunderbolt_attached(rdev->pdev))
> +	    !pci_is_thunderbolt_attached(dev->pdev))
>  		flags |= RADEON_IS_PX;
>  
>  	/* radeon_device_init should report only fatal error
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-05-21  7:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17 21:08 [REGRESSION] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo Nicolai Stange
     [not found] ` <87h90jkx88.fsf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-18  8:05   ` Lukas Wunner
     [not found]     ` <20170518080501.GA31002-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2017-05-18 19:33       ` [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops Lukas Wunner
2017-05-21  7:31         ` Nicolai Stange [this message]
2017-05-22 14:04           ` Lukas Wunner
2017-05-22 19:35             ` Sean Paul
2017-05-23  9:40               ` Lukas Wunner
     [not found]             ` <20170522140407.GA7973-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2017-05-23  3:09               ` Michel Dänzer
     [not found]                 ` <ee3f8e5b-8deb-b5a3-6d07-f43c27ebf84f-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-05-23  3:50                   ` Lukas Wunner
     [not found]                     ` <20170523035053.GB3610-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2017-05-23  3:55                       ` Michel Dänzer
     [not found]                         ` <b6d95951-d28d-f709-adcd-1068aeaa0e0f-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-05-23  7:32                           ` Christian König
     [not found]                             ` <b84f80fd-0cd1-86cf-4e81-cb4547ea6fff-5C7GfCeVMHo@public.gmane.org>
2017-05-23  7:36                               ` Daniel Vetter
2017-05-23  7:43                                 ` Christian König
2017-05-23  7:43                                 ` Daniel Vetter
2017-05-23 10:14                             ` Lukas Wunner
     [not found]                               ` <20170523101414.GC31451-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2017-05-23 10:32                                 ` Christian König
2017-05-23 18:47                       ` Deucher, Alexander
     [not found]                         ` <BN6PR12MB165207FE821EFFFBE14E1676F7F90-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-05-23 20:23                           ` Alex Deucher
2017-05-22 19:24         ` Daniel Vetter
     [not found]           ` <20170522192434.wotowwbpdl7zqki2-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2017-05-23 10:00             ` Lukas Wunner
2017-05-23 12:58               ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871srifyyq.fsf@gmail.com \
    --to=nicstange@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lukas@wunner.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).