From: Eric Anholt <eric@anholt.net>
To: Rob Clark <robdclark@gmail.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/msm: drop quirks binding
Date: Mon, 30 Jan 2017 10:12:21 -0800 [thread overview]
Message-ID: <871svkifi2.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <20170130164921.20744-4-robdclark@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 724 bytes --]
Rob Clark <robdclark@gmail.com> writes:
> This was never documented or used in upstream dtb. It is used by
> downstream bindings from android device kernels. But the quirks are
> a property of the gpu revision, and as such are redundant to be listed
> separately in dt. Instead, move the quirks to the device table.
>
> Signed-off-by: Rob Clark <robdclark@gmail.com>
> ---
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 4 ++--
> drivers/gpu/drm/msm/adreno/adreno_device.c | 18 ++++--------------
> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 1 -
> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 4 +---
> 4 files changed, 7 insertions(+), 20 deletions(-)
Nice cleanup!
Reviewed-by: Eric Anholt <eric@anholt.net>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-01-30 18:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 16:49 [PATCH 0/4] drm/msm: cleanup gpu bindings Rob Clark
[not found] ` <20170130164921.20744-1-robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-30 16:49 ` [PATCH 1/4] drm/msm: remove qcom, gpu-pwrlevels bindings Rob Clark
[not found] ` <20170130164921.20744-2-robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-30 18:21 ` Eric Anholt
[not found] ` <87vaswh0i9.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
2017-01-30 18:35 ` [PATCH 1/4] drm/msm: remove qcom,gpu-pwrlevels bindings Rob Clark
[not found] ` <CAF6AEGt8mj8S+iv8aHVwyqm3f-5NhzmRv5Ajv5TmJXee5YLxVg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-30 19:56 ` [PATCH 1/4] drm/msm: remove qcom, gpu-pwrlevels bindings Eric Anholt
2017-02-01 23:26 ` Jordan Crouse
2017-02-01 17:01 ` Rob Herring
2017-01-30 16:49 ` [PATCH 2/4] drm/msm: drop qcom,chipid Rob Clark
2017-01-30 18:09 ` Eric Anholt
[not found] ` <874m0gifmf.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
2017-01-30 18:19 ` Rob Clark
[not found] ` <CAF6AEGuK9TCdRmyaj4tk3+uu5L5Xvf1T3Kz8gZynX331VqSMfA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-30 19:54 ` Eric Anholt
2017-01-30 20:28 ` Rob Clark
2017-02-01 17:09 ` Rob Herring
2017-02-01 17:25 ` Rob Clark
2017-01-30 16:49 ` [PATCH 3/4] drm/msm: drop quirks binding Rob Clark
2017-01-30 18:12 ` Eric Anholt [this message]
2017-01-30 16:49 ` [PATCH 4/4] drm/msm: drop _clk suffix from clk names Rob Clark
2017-01-30 18:15 ` Eric Anholt
[not found] ` <87y3xsh0st.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
2017-01-30 18:26 ` Rob Clark
2017-02-01 17:11 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871svkifi2.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox