Re: [PATCH v5 0/2] GPD Win Max display fixes

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 29 Dec 2021, Anisse Astier <anisse@astier.eu> wrote:
> This patch series is for making the GPD Win Max display usable with
> Linux.

Thanks, pushed to drm-intel-next. Sorry for the delay in dealing with
the patches.

BR,
Jani.


>
> The GPD Win Max is a small laptop, and its eDP panel does not send an
> EDID over DPCD; the EDID is instead available in the intel opregion, in
> mailbox #5 [1]
>
> The second patch is just to fix the orientation of the panel.
>
> Changes since v1:
>  - rebased on drm-tip
>  - squashed patch 1 & 2
>  - picked up Reviewed-by from Hans de Goede (thanks for the review)
>
> Changes since v2:
>  - rebased on drm-tip
>  - updated commit message
>
> When v2 was initially sent [3] Ville Syrjälä suggested that it might be
> a good idea to use the ACPI _DDC method instead to get the EDID, to
> cover a wider range of hardware. Unfortunately, it doesn't seem
> available on GPD Win Max, so I think this work should be done
> independently, and this patch series considered separately.
>
> Change since v3:
>  - edits following Jani's review:
>     - The EDID from the opregion is now only used as a fallback: if we
>       cannot get any edid from the edp connector, then we attempt to get
>       it from the opregion. This works for the GPD Win Max.
>     - all other remarks should have been taken into account
>  - rebased on drm-tip
>  - added Co-developed-by
>  - reordered signed-off-by and reviewed-by in second patch (thanks
>    Maarten!)
>
> Changes since v4:
>  - checkpatch.pl fixes
>  - rebased on drm-tip
>  - Note: patch #1 is incomplete, still missing Jani's signed-off-by
>
>
> [1]: https://gitlab.freedesktop.org/drm/intel/-/issues/3454
> [2]: https://patchwork.kernel.org/project/intel-gfx/patch/20200828061941.17051-1-jani.nikula@intel.com/
> [3]: https://patchwork.kernel.org/project/intel-gfx/patch/20210531204642.4907-2-anisse@astier.eu/
>
>
> Anisse Astier (2):
>   drm/i915/opregion: add support for mailbox #5 EDID
>   drm: Add orientation quirk for GPD Win Max
>
>  .../gpu/drm/drm_panel_orientation_quirks.c    |  6 ++
>  drivers/gpu/drm/i915/display/intel_dp.c       |  7 +++
>  drivers/gpu/drm/i915/display/intel_opregion.c | 55 ++++++++++++++++++-
>  drivers/gpu/drm/i915/display/intel_opregion.h | 10 ++++
>  4 files changed, 77 insertions(+), 1 deletion(-)

-- 
Jani Nikula, Intel Open Source Graphics Center