From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor) Date: Sat, 27 Dec 2014 08:19:24 -1000 Message-ID: <873881arbn.fsf@eliezer.anholt.net> References: <544F885B.9030206@gmail.com> <1418940218.6596.49.camel@gmail.com> <1419552090.3950.3.camel@gmail.com> <549CB954.9060602@daenzer.net> <1419563434.3950.9.camel@gmail.com> <549CD359.1020608@daenzer.net> <1419594203.1679.1.camel@gmail.com> <86a929ypsa.fsf@hiro.keithp.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1692115860==" Return-path: In-Reply-To: <86a929ypsa.fsf-6d7jPg3SX/+z9DMzp4kqnw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: xorg-devel-bounces-go0+a7rfsptAfugRpC6u6w@public.gmane.org Sender: "xorg-devel" To: Keith Packard , Kertesz Laszlo , Michel =?utf-8?Q?D=C3=A4nzer?= Cc: "List, X.Org" , Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org --===============1692115860== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Keith Packard writes: > Kertesz Laszlo writes: > >> Ok, rebuilt the xserver package with debugging symbols (seems that >> checkinstall strips stuff by default). I got a bigger gdb.txt. See if it >> helps. > > I found a bug -- glamor_xv_put_image was mis-computing the number of > lines of changed video when the client drew only a subset of the > image. I think the client is drawing at src_y=3D1, src_h=3D239 for some > weird reason (I suspect a bug in the client). > > Try this patch: > > From eaa4225413b31314070f9a52d9290649e79a3b0f Mon Sep 17 00:00:00 2001 > From: Keith Packard > Date: Sat, 27 Dec 2014 09:11:33 -0800 > Subject: [PATCH] glamor: Fix nlines in glamor_xv_put_image when src_y is = odd > > The number of lines of video to update in the texture needs to be > computed from the height of the updated source, not the full height of > the source. > > Signed-off-by: Keith Packard > --- > glamor/glamor_xv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/glamor/glamor_xv.c b/glamor/glamor_xv.c > index 1c877da..83e24ad 100644 > --- a/glamor/glamor_xv.c > +++ b/glamor/glamor_xv.c > @@ -435,7 +435,7 @@ glamor_xv_put_image(glamor_port_private *port_priv, > } >=20=20 > top =3D (src_y) & ~1; > - nlines =3D (src_y + height) - top; > + nlines =3D (src_y + src_h) - top; >=20=20 > switch (id) { > case FOURCC_YV12: If the point is to upload only from the src_[xywh] recctangle, shouldn't the glamor_upload_sub_pixmap_to_texture() calls be using src_w instead of width, too? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJUnvgtAAoJELXWKTbR/J7oavYQALr4O5D27ytjCGutH48orPoT XyXSDfLimkPyk13KRVxqFed4cQORydpZDOkP7tcJotns7MPdOjg27UDI8FkWTMvU Oy4U7BMQSHEGbd+pqLL6/B5BjQoxF/hcG+dQW0edWmR2DHSBaZ9yswoC0Mf4vbl0 s1o7dyRIzO0pLpD5NY8yc+Tt7opthIcsXmVDBGC9AyAvxkrfu778aItX5LTcyPaC pmqlf1trNrYa4OuVz0MuMr7bayCucwoadJpppGQcNGeiGVZmzgB3jknTd17jDUTK ovFPM+6wvLwgGrxT2s1s6UozBfR/scLrm3CKGPwU/MbyVGeyHDXYvieOaoQAiFwZ DSEW68385KcBVnmcOoJlHYNMJTeDR4k7dGEeYlJ0i95n7TNtXRKp7xQYPZPLRr3+ GdV7aRCnXr8DQF+MfCI6shwLJuffap0hHZlF6WsJtzKOpcru0UuxYoj+rcwy9FXH griU8vIsexXuyO1znLdI6l0v/nZFuBgu4ArO7yvG6+oVuT/wTQxPtAHi0F6Z7ke3 oTqSgNxQh85MiHHVnKNctoVH7x524mIsvwXjIoH98z2LxdiTftp5OmTN03nYUjYv Pw2fchZZD20JSS+5+ssOaWugA7L4CVXXmFPibt9GWqwSdHShghvTTrg+Gbki2KWi Mj1bd12wY1OiytsNw8L5 =7X9P -----END PGP SIGNATURE----- --=-=-=-- --===============1692115860== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KeG9yZy1kZXZl bEBsaXN0cy54Lm9yZzogWC5PcmcgZGV2ZWxvcG1lbnQKQXJjaGl2ZXM6IGh0dHA6Ly9saXN0cy54 Lm9yZy9hcmNoaXZlcy94b3JnLWRldmVsCkluZm86IGh0dHA6Ly9saXN0cy54Lm9yZy9tYWlsbWFu L2xpc3RpbmZvL3hvcmctZGV2ZWw= --===============1692115860==--