From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Maíra Canal" <mairacanal@riseup.net>,
"Maxime Ripard" <maxime@cerno.tech>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"David Airlie" <airlied@linux.ie>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Florian Fainelli" <f.fainelli@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/tests: helpers: Add module infos
Date: Wed, 16 Nov 2022 13:32:51 +0200 [thread overview]
Message-ID: <874juz2kyk.fsf@intel.com> (raw)
In-Reply-To: <6dba9207-5ba2-5c73-e575-a7a86a2b9520@riseup.net>
On Wed, 16 Nov 2022, Maíra Canal <mairacanal@riseup.net> wrote:
> Hi Maxime,
>
> On 11/16/22 06:17, Maxime Ripard wrote:
>> The MODULE_LICENSE macro is missing from the kunit helpers file, thus
>> leading to a build error.
>>
>> Let's introduce it along with MODULE_AUTHOR.
>>
>> Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers")
>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> It would be nice to add the SPDX-License-Identifier tag in the source
> file as well. Besides that,
It's not just nice, it's basically mandatory to add license boilerplate.
Checkpatch would've warned about this. And actually about a lot of stuff
in the series.
(And our CI checkpatch did too, although we don't send the replies to
the world, just intel-gfx [1].)
BR,
Jani.
[1] https://lore.kernel.org/r/166846421165.32750.1193593124785451784@emeril.freedesktop.org
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-11-16 11:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 9:17 [PATCH 1/3] drm/tests: Include helpers header Maxime Ripard
2022-11-16 9:17 ` [PATCH 2/3] drm/tests: helpers: Add module infos Maxime Ripard
2022-11-16 11:18 ` Maíra Canal
2022-11-16 11:32 ` Jani Nikula [this message]
2022-11-16 15:12 ` Maxime Ripard
2022-11-16 15:23 ` Jani Nikula
2022-11-16 15:15 ` (subset) " Maxime Ripard
2022-11-16 9:17 ` [PATCH 3/3] firmware: raspberrypi: Fix type assignment Maxime Ripard
2022-11-16 11:14 ` [PATCH 1/3] drm/tests: Include helpers header Maíra Canal
2022-11-16 15:15 ` (subset) " Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874juz2kyk.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=f.fainelli@gmail.com \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mairacanal@riseup.net \
--cc=maxime@cerno.tech \
--cc=sfr@canb.auug.org.au \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox