From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A147BC71155 for ; Mon, 30 Nov 2020 10:15:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 190F720727 for ; Mon, 30 Nov 2020 10:15:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 190F720727 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4029C89CF8; Mon, 30 Nov 2020 10:14:59 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id D9DCE89CF3; Mon, 30 Nov 2020 10:14:57 +0000 (UTC) IronPort-SDR: GpTWbjWRq0X/sanEA4ME6UljD3kBKxTtXco9Wsis3ZHS0e2cpoHARRoXlqEhcqEAAt/Fi7XxM4 QMsQcND7R6Ig== X-IronPort-AV: E=McAfee;i="6000,8403,9820"; a="151863384" X-IronPort-AV: E=Sophos;i="5.78,381,1599548400"; d="scan'208";a="151863384" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 02:14:56 -0800 IronPort-SDR: MuxIqRKCIWlZEI+uIJCmGywH7sKX1VbB4QBUHtucnMEUoNbap56ep4oD60IdhPwAEiUvKSDPdG GogvQsCudqhw== X-IronPort-AV: E=Sophos;i="5.78,381,1599548400"; d="scan'208";a="549041096" Received: from cshanno1-mobl.ger.corp.intel.com (HELO localhost) ([10.252.44.44]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 02:14:54 -0800 From: Jani Nikula To: Matthew Auld , intel-gfx@lists.freedesktop.org Subject: Re: [RFC PATCH 096/162] drm/i915: setup the LMEM region In-Reply-To: <20201127120718.454037-97-matthew.auld@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20201127120718.454037-1-matthew.auld@intel.com> <20201127120718.454037-97-matthew.auld@intel.com> Date: Mon, 30 Nov 2020 12:14:50 +0200 Message-ID: <874kl7kv6t.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Abdiel Janulgue , Lucas De Marchi , dri-devel@lists.freedesktop.org, Rodrigo Vivi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 27 Nov 2020, Matthew Auld wrote: > + /* Enables Local Memory functionality in GAM */ > + I915_WRITE(GEN12_LMEM_CFG_ADDR, I915_READ(GEN12_LMEM_CFG_ADDR) | LMEM_ENABLE); Please use intel_uncore_read/write and intel_de_read/write throughout the series. We don't want any new users of I915_READ/I915_WRITE in the driver. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel