From: Jani Nikula <jani.nikula@linux.intel.com>
To: Tian Tao <tiantao6@hisilicon.com>,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org
Cc: linuxarm@huawei.com
Subject: Re: [PATCH] drm/dp: update kernel-doc line comments
Date: Mon, 21 Sep 2020 11:48:25 +0300 [thread overview]
Message-ID: <874knrseg6.fsf@intel.com> (raw)
In-Reply-To: <1600478730-43417-1-git-send-email-tiantao6@hisilicon.com>
On Sat, 19 Sep 2020, Tian Tao <tiantao6@hisilicon.com> wrote:
> Update kernel-doc line comments to fix warnings reported by make W=1.
It's really not a fix if it just turns the kernel-doc comments into
regular comments...
Please fix the warnings instead.
BR,
Jani.
>
> drivers/gpu/drm/drm_dp_helper.c:1036: warning: Function parameter or member
> 'dpcd' not described in 'drm_dp_subconnector_type'
> drivers/gpu/drm/drm_dp_helper.c:1036: warning: Function parameter or member
> 'port_cap' not described in 'drm_dp_subconnector_type'
> drivers/gpu/drm/drm_dp_helper.c:1089: warning: Function parameter or member
> 'connector' not described in 'drm_dp_set_subconnector_property'
> drivers/gpu/drm/drm_dp_helper.c:1089: warning: Function parameter or member
> 'status' not described in 'drm_dp_set_subconnector_property'
> drivers/gpu/drm/drm_dp_helper.c:1089: warning: Function parameter or member
> 'dpcd' not described in 'drm_dp_set_subconnector_property'
> drivers/gpu/drm/drm_dp_helper.c:1089: warning: Function parameter or member
> 'port_cap' not described in 'drm_dp_set_subconnector_property'
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> drivers/gpu/drm/drm_dp_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index 90807a6..a12485f 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -1026,7 +1026,7 @@ void drm_dp_downstream_debug(struct seq_file *m,
> }
> EXPORT_SYMBOL(drm_dp_downstream_debug);
>
> -/**
> +/*
> * drm_dp_subconnector_type() - get DP branch device type
> *
> */
> @@ -1077,7 +1077,7 @@ drm_dp_subconnector_type(const u8 dpcd[DP_RECEIVER_CAP_SIZE],
> }
> EXPORT_SYMBOL(drm_dp_subconnector_type);
>
> -/**
> +/*
> * drm_mode_set_dp_subconnector_property - set subconnector for DP connector
> *
> * Called by a driver on every detect event.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-09-21 8:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 1:25 [PATCH] drm/dp: update kernel-doc line comments Tian Tao
2020-09-21 8:48 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874knrseg6.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linuxarm@huawei.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tiantao6@hisilicon.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox