From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA5EAC5475B for ; Wed, 6 Mar 2024 12:53:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F1F9511315C; Wed, 6 Mar 2024 12:53:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="IUpcDCzK"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id C069611315C for ; Wed, 6 Mar 2024 12:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709729627; x=1741265627; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=9V/0lspOmb9T32u1RMsAnMxMJ1V06Y8m+bgWinFW7ZQ=; b=IUpcDCzKnafxFdI/jWEWpKbiupRkxbNHAqLV1X/nt+BkZqkKAFOSgKbM zAANjLxUAdZ+Mq1TwNjscqZNSgoXfCzrWqylWrltBmUlsm4CJzWia68Zq cvEVbQy7eKSOGNeOl0dlet+NlZQ8+tUGubbRLurtK+8cpwiu5F0/ZCSMO 3WQc5jU/onKixK1DcruIbaSYRneEreRpJqnEQF1x+VLB2PiyZzHWeWGug ZHoa5rXLXlgDD4v0skavbs2KtrKiTi50+WamS6jUfvKvh3XAAO52+W8Ln /NwNFMLa9ZyCO/CHzbhVRx0rnWValMqlKBL/FDfE0/McjA6712WkmOok8 w==; X-IronPort-AV: E=McAfee;i="6600,9927,11004"; a="4270464" X-IronPort-AV: E=Sophos;i="6.06,208,1705392000"; d="scan'208";a="4270464" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2024 04:53:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,208,1705392000"; d="scan'208";a="9678012" Received: from rjongalo-mobl2.ger.corp.intel.com (HELO localhost) ([10.252.33.211]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2024 04:53:43 -0800 From: Jani Nikula To: Hsin-Yi Wang , Doug Anderson Cc: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov Subject: Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240304195214.14563-1-hsinyi@chromium.org> <20240304195214.14563-3-hsinyi@chromium.org> <87a5nd4tsg.fsf@intel.com> <874jdl4k01.fsf@intel.com> <87y1ax2iu1.fsf@intel.com> Date: Wed, 06 Mar 2024 14:53:40 +0200 Message-ID: <875xxzzfl7.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 05 Mar 2024, Hsin-Yi Wang wrote: > On Tue, Mar 5, 2024 at 11:25=E2=80=AFAM Doug Anderson wrote: >> Hmm. As Hsin-Yi pointed out to me offline. Somehow we'll need to get >> the actual panel ID out. Right now in panel-edp.c we have: >> >> dev_warn(dev, >> "Unknown panel %s %#06x, using conservative timings\n", >> vend, product_id); >> >> Where "vend" and "product_id" come from the panel ID of a panel that >> we didn't recognize. For instance: >> >> Unknown panel BOE 0x0731, using conservative timings >> >> We need to still be able to print this message for unrecognized >> panels. Then when we see field reports including this message we know >> that somehow we ended up shipping an unrecognized panel. >> >> Any suggestions on what abstraction you'd like to see to enable us to >> print that message if everything is opaque? > > Sent v4 here: https://lore.kernel.org/lkml/20240306004347.974304-1-hsinyi= @chromium.org/ > > Besides that it still keeps drm_edid_get_panel_id() to be used on the > kernel warning when no panel is matched, other parts I think are > following the comments. Yeah we can keep that for now. BR, Jani. --=20 Jani Nikula, Intel