Re: [Intel-gfx] [PATCH 1/2] drm/dp: note that DPCD 0x2002-0x2003 match 0x200-0x201

[Jani Nikula <jani.nikula@intel.com>]

On Mon, 10 Jan 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Jan 04, 2022 at 08:48:56PM +0200, Jani Nikula wrote:
>> DP_SINK_COUNT_ESI and DP_DEVICE_SERVICE_IRQ_VECTOR_ESI0 have the same
>> contents as DP_SINK_COUNT and DP_DEVICE_SERVICE_IRQ_VECTOR,
>> respectively.
>
> IIRC there was an oversight in the earlier spec revisions that
> showed bit 7 as reserved for one of the locations. But looks like
> that got fixed.

Yeah. Thanks for the review, pushed both to drm-misc-next.

BR,
Jani.


>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  include/drm/drm_dp_helper.h | 7 ++-----
>>  1 file changed, 2 insertions(+), 5 deletions(-)
>> 
>> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
>> index 30359e434c3f..98d020835b49 100644
>> --- a/include/drm/drm_dp_helper.h
>> +++ b/include/drm/drm_dp_helper.h
>> @@ -1038,11 +1038,8 @@ struct drm_panel;
>>  #define DP_SIDEBAND_MSG_UP_REQ_BASE	    0x1600   /* 1.2 MST */
>>  
>>  /* DPRX Event Status Indicator */
>> -#define DP_SINK_COUNT_ESI		    0x2002   /* 1.2 */
>> -/* 0-5 sink count */
>> -# define DP_SINK_COUNT_CP_READY             (1 << 6)
>> -
>> -#define DP_DEVICE_SERVICE_IRQ_VECTOR_ESI0   0x2003   /* 1.2 */
>> +#define DP_SINK_COUNT_ESI                   0x2002   /* same as 0x200 */
>> +#define DP_DEVICE_SERVICE_IRQ_VECTOR_ESI0   0x2003   /* same as 0x201 */
>>  
>>  #define DP_DEVICE_SERVICE_IRQ_VECTOR_ESI1   0x2004   /* 1.2 */
>>  # define DP_RX_GTC_MSTR_REQ_STATUS_CHANGE    (1 << 0)
>> -- 
>> 2.30.2

-- 
Jani Nikula, Intel Open Source Graphics Center